Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Unified Diff: blimp/net/tcp_transport_unittest.cc

Issue 1718333002: Migrate blimp/* to net::IPAddress. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comments eroman Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « blimp/engine/session/blimp_engine_session.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: blimp/net/tcp_transport_unittest.cc
diff --git a/blimp/net/tcp_transport_unittest.cc b/blimp/net/tcp_transport_unittest.cc
index 148f56a5d57a41206499ed69216d0992d71089b1..cef15d37d804899a08e385434cc02632aab7a7e7 100644
--- a/blimp/net/tcp_transport_unittest.cc
+++ b/blimp/net/tcp_transport_unittest.cc
@@ -14,6 +14,7 @@
#include "blimp/net/tcp_engine_transport.h"
#include "blimp/net/test_common.h"
#include "net/base/address_list.h"
+#include "net/base/ip_address.h"
#include "net/base/ip_endpoint.h"
#include "net/base/net_errors.h"
#include "net/base/test_completion_callback.h"
@@ -30,8 +31,7 @@ namespace {
class TCPTransportTest : public testing::Test {
protected:
TCPTransportTest() {
- net::IPEndPoint local_address;
- ParseAddress("127.0.0.1", 0, &local_address);
+ net::IPEndPoint local_address(net::IPAddress(127, 0, 0, 1), 0);
engine_.reset(new TCPEngineTransport(local_address, nullptr));
}
@@ -41,16 +41,6 @@ class TCPTransportTest : public testing::Test {
return net::AddressList(local_address);
}
- void ParseAddress(const std::string& ip_str,
- uint16_t port,
- net::IPEndPoint* address) {
- net::IPAddressNumber ip_number;
- bool rv = net::ParseIPLiteralToNumber(ip_str, &ip_number);
- if (!rv)
- return;
- *address = net::IPEndPoint(ip_number, port);
- }
-
base::MessageLoopForIO message_loop_;
scoped_ptr<TCPEngineTransport> engine_;
};
« no previous file with comments | « blimp/engine/session/blimp_engine_session.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698