Implement 'sequential focus navigation starting point.'

Implement 'sequential focus navigation starting point.'

This CL implements sequential focus navigation starting point.
https://html.spec.whatwg.org/multipage/interaction.html#sequential-focus-navigation-starting-point

Behavior Change:
When TAB or Shift-TAB is pressed and there is not focused element, we start
searching for next focus candidates at the sequential focus navigation point.

 - If a navigation to a url with fragment identifier happened, an element pointed
   by the fragment is set as sequential focus navigation starting point.

 - If an element is focused, the element is set as sequential focus navigation
   starting point.

 - If a mouse button is pressed, an element on the mouse pointer is set as
   sequential focus navigation starting point.

If the element pointed by sequential focus navigation starting point is removed
from the document tree, a point where there was the element at would be the
starting point.

Implementation:
Sequential focus navigation starting point is represented as a Range object, and
it is owned by a Document.

Tests:
 * fast/events/sequential-focus-navigation-starting-point.html
   Added.
 * fast/events/frame-tab-focus.html, fast/html/tab-order.html, and svg/custom/
   tabindex-order.html
   Expectations are updated because element.blur() doesn't reset sequential focus
   navigation starting point.

BUG=454172
Committed: https://crrev.com/8870612f01ca55a123efbd7bf7024b236d6c12a6
Cr-Commit-Position: refs/heads/master@{#376949}

[tkent, 2016-02-23 00:55:59]

Patchset #1 (id:1) has been deleted

[tkent, 2016-02-23 01:05:54]

Description was changed from

==========
Implement 'sequential focus navigation starting point.'

work-in-progress. not ready to be reviewed.

BUG=454172
==========

to

==========
Implement 'sequential focus navigation starting point.'

This CL implements sequential focus navigation starting point.
https://html.spec.whatwg.org/multipage/interaction.html#sequential-focus-navi...

Behavior Change:
When TAB or Shift-TAB is pressed and there is not focused element, we start
searching for next focus candidates at the sequential focus navigation point.

 - If a navigation to a url with fragment identifier happened, an element
pointed
   by the fragment is set as sequential focus navigation starting point.

 - If an element is focused, the element is set as sequential focus navigation
   starting point.

 - If a mouse button is pressed, an element on the mouse pointer is set as
   sequential focus navigation starting point.

If the element pointed by sequential focus navigation starting point is removed
from the document tree, a point where there was the element at would be the
starting point.

Implementation:
Sequential focus navigation starting point is represented as a Range object, and
it is owned by a Document.

BUG=454172
==========

[tkent, 2016-02-23 01:55:40]

Description was changed from

==========
Implement 'sequential focus navigation starting point.'

This CL implements sequential focus navigation starting point.
https://html.spec.whatwg.org/multipage/interaction.html#sequential-focus-navi...

Behavior Change:
When TAB or Shift-TAB is pressed and there is not focused element, we start
searching for next focus candidates at the sequential focus navigation point.

 - If a navigation to a url with fragment identifier happened, an element
pointed
   by the fragment is set as sequential focus navigation starting point.

 - If an element is focused, the element is set as sequential focus navigation
   starting point.

 - If a mouse button is pressed, an element on the mouse pointer is set as
   sequential focus navigation starting point.

If the element pointed by sequential focus navigation starting point is removed
from the document tree, a point where there was the element at would be the
starting point.

Implementation:
Sequential focus navigation starting point is represented as a Range object, and
it is owned by a Document.

BUG=454172
==========

to

==========
Implement 'sequential focus navigation starting point.'

This CL implements sequential focus navigation starting point.
https://html.spec.whatwg.org/multipage/interaction.html#sequential-focus-navi...

Behavior Change:
When TAB or Shift-TAB is pressed and there is not focused element, we start
searching for next focus candidates at the sequential focus navigation point.

 - If a navigation to a url with fragment identifier happened, an element
pointed
   by the fragment is set as sequential focus navigation starting point.

 - If an element is focused, the element is set as sequential focus navigation
   starting point.

 - If a mouse button is pressed, an element on the mouse pointer is set as
   sequential focus navigation starting point.

If the element pointed by sequential focus navigation starting point is removed
from the document tree, a point where there was the element at would be the
starting point.

Implementation:
Sequential focus navigation starting point is represented as a Range object, and
it is owned by a Document.

Tests:
 * fast/events/sequential-focus-navigation-starting-point.html
   Added.
 * fast/events/frame-tab-focus.html, fast/html/tab-order.html, and svg/custom/
   tabindex-order.html
   Expectations are updated because element.blur() doesn't reset sequential
focus
   navigation starting point.


BUG=454172
==========

[tkent, 2016-02-23 01:56:10]

Patchset #1 (id:20001) has been deleted

[tkent, 2016-02-23 02:06:52]

Patchset #1 (id:40001) has been deleted

[tkent, 2016-02-23 02:07:20]

tkent@chromium.org changed reviewers:
+ kochi@chromium.org

[tkent, 2016-02-23 02:07:21]

kochi@, would you review this please?

Try bots are going to be green.

[tkent, 2016-02-23 06:59:06]

I confirmed Patch Set 3 fixed linux_oilpan_rel test failures.

[kochi, 2016-02-23 07:01:06]

LGTM

[tkent, 2016-02-23 08:08:56]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2016-02-23 08:09:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1718153002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1718153002/100001

[commit-bot: I haz the power, 2016-02-23 08:15:38]

Committed patchset #3 (id:100001)

[commit-bot: I haz the power, 2016-02-23 08:17:35]

Description was changed from

==========
Implement 'sequential focus navigation starting point.'

This CL implements sequential focus navigation starting point.
https://html.spec.whatwg.org/multipage/interaction.html#sequential-focus-navi...

Behavior Change:
When TAB or Shift-TAB is pressed and there is not focused element, we start
searching for next focus candidates at the sequential focus navigation point.

 - If a navigation to a url with fragment identifier happened, an element
pointed
   by the fragment is set as sequential focus navigation starting point.

 - If an element is focused, the element is set as sequential focus navigation
   starting point.

 - If a mouse button is pressed, an element on the mouse pointer is set as
   sequential focus navigation starting point.

If the element pointed by sequential focus navigation starting point is removed
from the document tree, a point where there was the element at would be the
starting point.

Implementation:
Sequential focus navigation starting point is represented as a Range object, and
it is owned by a Document.

Tests:
 * fast/events/sequential-focus-navigation-starting-point.html
   Added.
 * fast/events/frame-tab-focus.html, fast/html/tab-order.html, and svg/custom/
   tabindex-order.html
   Expectations are updated because element.blur() doesn't reset sequential
focus
   navigation starting point.


BUG=454172
==========

to

==========
Implement 'sequential focus navigation starting point.'

This CL implements sequential focus navigation starting point.
https://html.spec.whatwg.org/multipage/interaction.html#sequential-focus-navi...

Behavior Change:
When TAB or Shift-TAB is pressed and there is not focused element, we start
searching for next focus candidates at the sequential focus navigation point.

 - If a navigation to a url with fragment identifier happened, an element
pointed
   by the fragment is set as sequential focus navigation starting point.

 - If an element is focused, the element is set as sequential focus navigation
   starting point.

 - If a mouse button is pressed, an element on the mouse pointer is set as
   sequential focus navigation starting point.

If the element pointed by sequential focus navigation starting point is removed
from the document tree, a point where there was the element at would be the
starting point.

Implementation:
Sequential focus navigation starting point is represented as a Range object, and
it is owned by a Document.

Tests:
 * fast/events/sequential-focus-navigation-starting-point.html
   Added.
 * fast/events/frame-tab-focus.html, fast/html/tab-order.html, and svg/custom/
   tabindex-order.html
   Expectations are updated because element.blur() doesn't reset sequential
focus
   navigation starting point.

BUG=454172

Committed: https://crrev.com/8870612f01ca55a123efbd7bf7024b236d6c12a6
Cr-Commit-Position: refs/heads/master@{#376949}
==========

[commit-bot: I haz the power, 2016-02-23 08:17:36]

Patchset 3 (id:??) landed as
https://crrev.com/8870612f01ca55a123efbd7bf7024b236d6c12a6
Cr-Commit-Position: refs/heads/master@{#376949}

[sof, 2016-02-25 12:49:54]

sigbjornf@opera.com changed reviewers:
+ sigbjornf@opera.com

[sof, 2016-02-25 12:49:54]

The addition of m_sequentialFocusNavigationStartingPoint clearing in
Document::dispose() fixed almost all non-Oilpan leaks, but a few remains:


https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20non-Oi...

To fix these I had to add an "is Document detached" check to
Document::setSequentialFocusNavigationStartingPoint()

https://codereview.chromium.org/1718153002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/dom/Document.h (right):

https://codereview.chromium.org/1718153002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/dom/Document.h:1223: RefPtrWillBeMember<Range>
m_sequentialFocusNavigationStartingPoint;
Doesn't this risk creating a leak, with the Range keeping a ref-ptr in the other
direction?

[sof, 2016-02-25 18:28:55]

On 2016/02/25 12:49:54, sof wrote:
> The addition of m_sequentialFocusNavigationStartingPoint clearing in
> Document::dispose() fixed almost all non-Oilpan leaks, but a few remains:
> 
> 
>
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20non-Oi...
> 
> To fix these I had to add an "is Document detached" check to
> Document::setSequentialFocusNavigationStartingPoint()
> 

https://codereview.chromium.org/1739713003/ has the two-liner.

[tkent, 2016-02-25 22:49:07]

On 2016/02/25 at 12:49:54, sigbjornf wrote:
> The addition of m_sequentialFocusNavigationStartingPoint clearing in
Document::dispose() fixed almost all non-Oilpan leaks, but a few remains:
> 
> 
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20non-Oi...
> 
> To fix these I had to add an "is Document detached" check to
Document::setSequentialFocusNavigationStartingPoint()

You're right.  Thank you for fixing it.