third_party/WebKit/Source/core/dom/Document.h - Issue 1718153002: Implement 'sequential focus navigation starting point.'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/Document.h

Issue 1718153002: Implement 'sequential focus navigation starting point.' (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Actual fix for non-oilpan test failures Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/svg/custom/tabindex-order-expected.txt ('k') | third_party/WebKit/Source/core/dom/Document.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/Document.h

diff --git a/third_party/WebKit/Source/core/dom/Document.h b/third_party/WebKit/Source/core/dom/Document.h

index 65ba18dd72f53b7d6725a0fb04ae90d0c4414440..0476926bd2fdfe1be8d808c34e6bd84ed1c76c9c 100644

--- a/third_party/WebKit/Source/core/dom/Document.h

+++ b/third_party/WebKit/Source/core/dom/Document.h

@@ -602,6 +602,8 @@ public:

void setNeedsFocusedElementCheck();

void setAutofocusElement(Element*);

Element* autofocusElement() const { return m_autofocusElement.get(); }

+ void setSequentialFocusNavigationStartingPoint(Node*);

+ Element* sequentialFocusNavigationStartingPoint(WebFocusType) const;

void setActiveHoverElement(PassRefPtrWillBeRawPtr<Element>);

Element* activeHoverElement() const { return m_activeHoverElement.get(); }

@@ -1218,6 +1220,7 @@ private:

Timer<Document> m_clearFocusedElementTimer;

RefPtrWillBeMember<Element> m_autofocusElement;

RefPtrWillBeMember<Element> m_focusedElement;

+ RefPtrWillBeMember<Range> m_sequentialFocusNavigationStartingPoint;

sof 2016/02/25 12:49:54 Doesn't this risk creating a leak, with the Range

RefPtrWillBeMember<Node> m_hoverNode;

RefPtrWillBeMember<Element> m_activeHoverElement;

RefPtrWillBeMember<Element> m_documentElement;