third_party/WebKit/Source/core/frame/FrameView.cpp - Issue 1718153002: Implement 'sequential focus navigation starting point.'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 1718153002: Implement 'sequential focus navigation starting point.' (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Actual fix for non-oilpan test failures Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/dom/Document.h ('K') | « third_party/WebKit/Source/core/dom/Document.cpp ('k') | third_party/WebKit/Source/core/input/EventHandler.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/frame/FrameView.cpp

diff --git a/third_party/WebKit/Source/core/frame/FrameView.cpp b/third_party/WebKit/Source/core/frame/FrameView.cpp

index 6fad532d64459ced233c709e1e3c2dfc6f03f501..ae4738f4f19290b94380f0d41a2578d929600abb 100644

--- a/third_party/WebKit/Source/core/frame/FrameView.cpp

+++ b/third_party/WebKit/Source/core/frame/FrameView.cpp

@@ -1506,10 +1506,13 @@ bool FrameView::processUrlFragmentHelper(const String& name, UrlFragmentBehavior

// clear focus, which matches the behavior of other browsers.

if (anchorNode) {

m_frame->document()->updateLayoutIgnorePendingStylesheets();

- if (behavior == UrlFragmentScroll && anchorNode->isFocusable())

+ if (behavior == UrlFragmentScroll && anchorNode->isFocusable()) {

anchorNode->focus();

- else

+ } else {

+ if (behavior == UrlFragmentScroll)

+ m_frame->document()->setSequentialFocusNavigationStartingPoint(anchorNode);

m_frame->document()->clearFocusedElement();

+ }

}

return true;

}