Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1048)

Issue 1717553002: GN: Fix gn gen for windows debug non-component builds (Closed)

Created:
4 years, 10 months ago by Sam Clegg
Modified:
4 years, 10 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Fix gn gen for windows debug non-component builds Without this change running simply 'gn gen out/x86' on windows will generate: ERROR at //third_party/WebKit/Source/core/BUILD.gn:179:18: Item not found configs -= [ "//build/config/win:default_incremental_linking" ] ^----------------------------------------------- Committed: https://crrev.com/7bb4f393b0bc669ce5ee157289e954648b4b9ad2 Cr-Commit-Position: refs/heads/master@{#376361}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/core/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (5 generated)
Sam Clegg
4 years, 10 months ago (2016-02-19 02:10:47 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1717553002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1717553002/1
4 years, 10 months ago (2016-02-19 02:11:40 UTC) #4
Dirk Pranke
lgtm. Though strictly speaking static debug builds probably don't work at all on Windows for ...
4 years, 10 months ago (2016-02-19 02:14:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1717553002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1717553002/1
4 years, 10 months ago (2016-02-19 02:16:22 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-19 03:29:17 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-19 03:30:22 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7bb4f393b0bc669ce5ee157289e954648b4b9ad2
Cr-Commit-Position: refs/heads/master@{#376361}

Powered by Google App Engine
This is Rietveld 408576698