third_party/WebKit/Source/core/BUILD.gn - Issue 1717553002: GN: Fix gn gen for windows debug non-component builds

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/BUILD.gn

Issue 1717553002: GN: Fix gn gen for windows debug non-component builds (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/BUILD.gn

diff --git a/third_party/WebKit/Source/core/BUILD.gn b/third_party/WebKit/Source/core/BUILD.gn

index 586a241701929660cc376190a6d83258fefca6d7..f2c0082b1a7a6d54de7e1c62255999a8c15c71a1 100644

--- a/third_party/WebKit/Source/core/BUILD.gn

+++ b/third_party/WebKit/Source/core/BUILD.gn

@@ -173,7 +173,7 @@ component("core") {

":svg",

]

- if (is_win && is_debug) {

+ if (is_win && is_debug && is_component_build) {

# Incremental linking doesn't work on this target in debug mode, even

# with symbol_level=1.

configs -= [ "//build/config/win:default_incremental_linking" ]

« no previous file with comments | « no previous file | no next file » | no next file with comments »