[NaCl SDK] Add initial support for building the SDK with gn

[NaCl SDK] Add initial support for building the SDK with gn

build_sdk.py still uses gyp.  I have a followup CL to
convert that to gn.

BUG=585999
Committed: https://crrev.com/fbdaad0aab2ce5e20efd7b231d40724ca8bb4e10
Cr-Commit-Position: refs/heads/master@{#375335}

[Sam Clegg, 2016-02-12 19:37:55]

Description was changed from

==========
[NaCl SDK] Add initial support for building the SDK with gn

build_sdk.py still uses gyp.  I have a followup CL to
convert that to gn.

BUG=585999
==========

to

==========
[NaCl SDK] Add initial support for building the SDK with gn

build_sdk.py still uses gyp.  I have a followup CL to
convert that to gn.

BUG=585999
==========

[Sam Clegg, 2016-02-12 19:37:55]

sbc@chromium.org changed reviewers:
+ binji@chromium.org, dpranke@chromium.org

[Sam Clegg, 2016-02-12 19:38:30]

The CQ bit was checked by sbc@chromium.org to run a CQ dry run

[Sam Clegg, 2016-02-12 19:41:50]

The CQ bit was checked by sbc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-12 19:44:08]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1693053002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1693053002/20001

[commit-bot: I haz the power, 2016-02-12 19:55:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-12 19:55:49]

Dry run: Try jobs failed on following builders:
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[Sam Clegg, 2016-02-12 20:32:43]

The CQ bit was checked by sbc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-12 20:35:44]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1693053002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1693053002/40001

[commit-bot: I haz the power, 2016-02-12 20:44:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-12 20:44:38]

Dry run: Try jobs failed on following builders:
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Dirk Pranke, 2016-02-12 20:47:35]

I'm a little puzzled by this CL; I thought we didn't normally build the SDK as
part of a Chrome build, but maybe I don't know what this change is actually
doing?

(The change itself looks at least plausible, though).

[Sam Clegg, 2016-02-12 21:54:52]

On 2016/02/12 20:47:35, Dirk Pranke wrote:
> I'm a little puzzled by this CL; I thought we didn't normally build the SDK as
> part of a Chrome build, but maybe I don't know what this change is actually
> doing?
> 
> (The change itself looks at least plausible, though).


Perhaps if you look at the followup change it might make things a little more
clear (https://codereview.chromium.org/1688803003).

We currently use gyp to build all the SDK components (the ones that are listed
in this new BUILD.gn file).  This change will allow is to stop using gyp and
make the SDK build much cleaner.

No new targets gn are added by this change, its just adds group of targets that
are all related by the fact that they are included in the NaCl SDK.

[Dirk Pranke, 2016-02-13 00:54:09]

hm, ok. lgtm.

[Sam Clegg, 2016-02-13 01:51:53]

The CQ bit was checked by sbc@chromium.org

[Sam Clegg, 2016-02-13 01:51:54]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/1693053002/#ps80001
(title: " ")

[commit-bot: I haz the power, 2016-02-13 01:52:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1693053002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1693053002/80001

[Sam Clegg, 2016-02-13 01:52:24]

sbc@chromium.org changed reviewers:
+ bradnelson@chromium.org

[Sam Clegg, 2016-02-13 01:52:25]

+bradnelson for ppapi/native_client OWNERS

[bradnelson, 2016-02-13 01:57:02]

lgtm

[commit-bot: I haz the power, 2016-02-13 01:57:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-13 01:57:33]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)

[Sam Clegg, 2016-02-13 02:16:24]

The CQ bit was checked by sbc@chromium.org

[Sam Clegg, 2016-02-13 02:16:25]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, bradnelson@chromium.org
Link to the patchset: https://codereview.chromium.org/1693053002/#ps100001
(title: " ")

[commit-bot: I haz the power, 2016-02-13 02:16:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1693053002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1693053002/100001

[commit-bot: I haz the power, 2016-02-13 03:03:59]

Description was changed from

==========
[NaCl SDK] Add initial support for building the SDK with gn

build_sdk.py still uses gyp.  I have a followup CL to
convert that to gn.

BUG=585999
==========

to

==========
[NaCl SDK] Add initial support for building the SDK with gn

build_sdk.py still uses gyp.  I have a followup CL to
convert that to gn.

BUG=585999
==========

[commit-bot: I haz the power, 2016-02-13 03:04:00]

Committed patchset #6 (id:100001)

[Nico, 2016-02-13 05:08:59]

A revert of this CL (patchset #6 id:100001) has been created in
https://codereview.chromium.org/1693213002/ by thakis@chromium.org.

The reason for reverting is: Doesn't build with clang/win and looks nontrivial
to fix:

https://build.chromium.org/p/chromium.fyi/builders/CrWinClang64%28dbg%29/buil...

FAILED: ninja -t msvc -e environment.x64 -- E:\b\build\goma/gomacc.exe
../../third_party/llvm-build/Release+Asserts/bin/clang-cl.exe /nologo
/showIncludes /FC
@obj/native_client/src/trusted/validator/driver/ncval_new/ncval.obj.rsp /c
../../native_client/src/trusted/validator/driver/ncval.cc
/Foobj/native_client/src/trusted/validator/driver/ncval_new/ncval.obj
/Fdobj/native_client/src/trusted/validator/driver/ncval_new_cc.pdb
../../native_client/src/trusted/validator/driver/ncval.cc(359,36) :  error: ISO
C++11 does not allow conversion from string literal to 'char *'
[-Werror,-Wwritable-strings]
  while ((opt = getopt(argc, argv, "vd")) != -1) {
                                   ^

(and i'm guessing several more).

[commit-bot: I haz the power, 2016-02-16 22:47:14]

Description was changed from

==========
[NaCl SDK] Add initial support for building the SDK with gn

build_sdk.py still uses gyp.  I have a followup CL to
convert that to gn.

BUG=585999
==========

to

==========
[NaCl SDK] Add initial support for building the SDK with gn

build_sdk.py still uses gyp.  I have a followup CL to
convert that to gn.

BUG=585999

Committed: https://crrev.com/fbdaad0aab2ce5e20efd7b231d40724ca8bb4e10
Cr-Commit-Position: refs/heads/master@{#375335}
==========

[commit-bot: I haz the power, 2016-02-16 22:47:14]

Patchset 6 (id:??) landed as
https://crrev.com/fbdaad0aab2ce5e20efd7b231d40724ca8bb4e10
Cr-Commit-Position: refs/heads/master@{#375335}