Switch BlinkGCPluginConsumer to use ranged for-loops.

Switch BlinkGCPluginConsumer to use ranged for-loops.

Modernize and consistently use ranged for-loops where possible.

R=haraken,thakis
BUG=

Committed: https://crrev.com/bbdd322aed279091827ddf5aa50a6723deda641f
Cr-Commit-Position: refs/heads/master@{#376656}

[sof, 2016-02-20 08:31:31]

sigbjornf@opera.com changed reviewers:
+ oilpan-reviews@chromium.org, thakis@chromium.org

[sof, 2016-02-20 08:31:32]

please take a look.

some tidying work i had lying around.. passes unit tests & local Blink building.

[haraken, 2016-02-20 08:44:03]

LGTM

[Nico, 2016-02-20 13:40:19]

On 2016/02/20 08:44:03, haraken wrote:
> LGTM

For loops lgtm. Omitting parameter names is uncommon in both chromium and llvm
code as far as I know, but up to you if you want to keep that.

[sof, 2016-02-20 14:29:26]

On 2016/02/20 13:40:19, Nico (ooo Fri Feb 19) wrote:
> On 2016/02/20 08:44:03, haraken wrote:
> > LGTM
> 
> For loops lgtm. Omitting parameter names is uncommon in both chromium and llvm
> code as far as I know, but up to you if you want to keep that.

I'll add them back to comply.

(Tangential question, will the Blink codebase conversion introduce these
automagically?)

[sof, 2016-02-20 19:03:36]

Description was changed from

==========
Switch BlinkGCPluginConsumer to use ranged for-loops.

Modernize and consistently use ranged for-loops where possible.

R=
BUG=
==========

to

==========
Switch BlinkGCPluginConsumer to use ranged for-loops.

Modernize and consistently use ranged for-loops where possible.

R=haraken,thakis
BUG=
==========

[sof, 2016-02-20 19:04:46]

The CQ bit was checked by sigbjornf@opera.com

[sof, 2016-02-20 19:04:46]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/1717433003/#ps40001
(title: "decl arg tidying")

[commit-bot: I haz the power, 2016-02-20 19:04:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1717433003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1717433003/40001

[commit-bot: I haz the power, 2016-02-20 19:09:52]

Description was changed from

==========
Switch BlinkGCPluginConsumer to use ranged for-loops.

Modernize and consistently use ranged for-loops where possible.

R=haraken,thakis
BUG=
==========

to

==========
Switch BlinkGCPluginConsumer to use ranged for-loops.

Modernize and consistently use ranged for-loops where possible.

R=haraken,thakis
BUG=
==========

[commit-bot: I haz the power, 2016-02-20 19:09:53]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-02-20 19:11:26]

Description was changed from

==========
Switch BlinkGCPluginConsumer to use ranged for-loops.

Modernize and consistently use ranged for-loops where possible.

R=haraken,thakis
BUG=
==========

to

==========
Switch BlinkGCPluginConsumer to use ranged for-loops.

Modernize and consistently use ranged for-loops where possible.

R=haraken,thakis
BUG=

Committed: https://crrev.com/bbdd322aed279091827ddf5aa50a6723deda641f
Cr-Commit-Position: refs/heads/master@{#376656}
==========

[commit-bot: I haz the power, 2016-02-20 19:11:27]

Patchset 3 (id:??) landed as
https://crrev.com/bbdd322aed279091827ddf5aa50a6723deda641f
Cr-Commit-Position: refs/heads/master@{#376656}

[Nico, 2016-02-21 21:49:36]

On 2016/02/20 14:29:26, sof wrote:
> On 2016/02/20 13:40:19, Nico (ooo Fri Feb 19) wrote:
> > On 2016/02/20 08:44:03, haraken wrote:
> > > LGTM
> > 
> > For loops lgtm. Omitting parameter names is uncommon in both chromium and
llvm
> > code as far as I know, but up to you if you want to keep that.
> 
> I'll add them back to comply.
> 
> (Tangential question, will the Blink codebase conversion introduce these
> automagically?)

(IIRC the plan was to squint enough at the google style guide to interpret it
that omitting parameter names is ok and recommending this for code in blink – so
this part of blink style probably won't change. I might misremember though.)