Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Side by Side Diff: tools/clang/blink_gc_plugin/BlinkGCPluginConsumer.h

Issue 1717433003: Switch BlinkGCPluginConsumer to use ranged for-loops. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: decl arg tidying Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | tools/clang/blink_gc_plugin/BlinkGCPluginConsumer.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef TOOLS_BLINK_GC_PLUGIN_BLINK_GC_PLUGIN_CONSUMER_H_ 5 #ifndef TOOLS_BLINK_GC_PLUGIN_BLINK_GC_PLUGIN_CONSUMER_H_
6 #define TOOLS_BLINK_GC_PLUGIN_BLINK_GC_PLUGIN_CONSUMER_H_ 6 #define TOOLS_BLINK_GC_PLUGIN_BLINK_GC_PLUGIN_CONSUMER_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "BlinkGCPluginOptions.h" 10 #include "BlinkGCPluginOptions.h"
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
89 clang::SourceLocation location, 89 clang::SourceLocation location,
90 unsigned diag_id); 90 unsigned diag_id);
91 91
92 void ReportClassMustLeftMostlyDeriveGC(RecordInfo* info); 92 void ReportClassMustLeftMostlyDeriveGC(RecordInfo* info);
93 void ReportClassRequiresTraceMethod(RecordInfo* info); 93 void ReportClassRequiresTraceMethod(RecordInfo* info);
94 void ReportBaseRequiresTracing(RecordInfo* derived, 94 void ReportBaseRequiresTracing(RecordInfo* derived,
95 clang::CXXMethodDecl* trace, 95 clang::CXXMethodDecl* trace,
96 clang::CXXRecordDecl* base); 96 clang::CXXRecordDecl* base);
97 void ReportFieldsRequireTracing(RecordInfo* info, 97 void ReportFieldsRequireTracing(RecordInfo* info,
98 clang::CXXMethodDecl* trace); 98 clang::CXXMethodDecl* trace);
99 void ReportClassContainsInvalidFields(RecordInfo* info, 99 void ReportClassContainsInvalidFields(
100 CheckFieldsVisitor::Errors* errors); 100 RecordInfo* info,
101 const CheckFieldsVisitor::Errors& errors);
101 void ReportClassContainsGCRoots(RecordInfo* info, 102 void ReportClassContainsGCRoots(RecordInfo* info,
102 CheckGCRootsVisitor::Errors* errors); 103 const CheckGCRootsVisitor::Errors& errors);
103 void ReportFinalizerAccessesFinalizedFields( 104 void ReportFinalizerAccessesFinalizedFields(
104 clang::CXXMethodDecl* dtor, 105 clang::CXXMethodDecl* dtor,
105 CheckFinalizerVisitor::Errors* fields); 106 const CheckFinalizerVisitor::Errors& errors);
106 void ReportClassRequiresFinalization(RecordInfo* info); 107 void ReportClassRequiresFinalization(RecordInfo* info);
107 void ReportClassDoesNotRequireFinalization(RecordInfo* info); 108 void ReportClassDoesNotRequireFinalization(RecordInfo* info);
108 void ReportClassMustDeclareGCMixinTraceMethod(RecordInfo* info); 109 void ReportClassMustDeclareGCMixinTraceMethod(RecordInfo* info);
109 void ReportOverriddenNonVirtualTrace(RecordInfo* info, 110 void ReportOverriddenNonVirtualTrace(RecordInfo* info,
110 clang::CXXMethodDecl* trace, 111 clang::CXXMethodDecl* trace,
111 clang::CXXMethodDecl* overridden); 112 clang::CXXMethodDecl* overridden);
112 void ReportMissingTraceDispatchMethod(RecordInfo* info); 113 void ReportMissingTraceDispatchMethod(RecordInfo* info);
113 void ReportMissingFinalizeDispatchMethod(RecordInfo* info); 114 void ReportMissingFinalizeDispatchMethod(RecordInfo* info);
114 void ReportMissingDispatchMethod(RecordInfo* info, unsigned error); 115 void ReportMissingDispatchMethod(RecordInfo* info, unsigned error);
115 void ReportVirtualAndManualDispatch(RecordInfo* info, 116 void ReportVirtualAndManualDispatch(RecordInfo* info,
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
187 188
188 clang::CompilerInstance& instance_; 189 clang::CompilerInstance& instance_;
189 clang::DiagnosticsEngine& diagnostic_; 190 clang::DiagnosticsEngine& diagnostic_;
190 BlinkGCPluginOptions options_; 191 BlinkGCPluginOptions options_;
191 RecordCache cache_; 192 RecordCache cache_;
192 JsonWriter* json_; 193 JsonWriter* json_;
193 }; 194 };
194 195
195 196
196 #endif // TOOLS_BLINK_GC_PLUGIN_BLINK_GC_PLUGIN_CONSUMER_H_ 197 #endif // TOOLS_BLINK_GC_PLUGIN_BLINK_GC_PLUGIN_CONSUMER_H_
OLDNEW
« no previous file with comments | « no previous file | tools/clang/blink_gc_plugin/BlinkGCPluginConsumer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698