Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Unified Diff: tools/clang/blink_gc_plugin/BlinkGCPluginConsumer.h

Issue 1717433003: Switch BlinkGCPluginConsumer to use ranged for-loops. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: decl arg tidying Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/clang/blink_gc_plugin/BlinkGCPluginConsumer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/clang/blink_gc_plugin/BlinkGCPluginConsumer.h
diff --git a/tools/clang/blink_gc_plugin/BlinkGCPluginConsumer.h b/tools/clang/blink_gc_plugin/BlinkGCPluginConsumer.h
index b1e35ce06955b7010815c8ff81cda5a2bb1308cf..d0b49d89bf2a1dc0b7edfd6b4ef6f2320d32a61c 100644
--- a/tools/clang/blink_gc_plugin/BlinkGCPluginConsumer.h
+++ b/tools/clang/blink_gc_plugin/BlinkGCPluginConsumer.h
@@ -96,13 +96,14 @@ class BlinkGCPluginConsumer : public clang::ASTConsumer {
clang::CXXRecordDecl* base);
void ReportFieldsRequireTracing(RecordInfo* info,
clang::CXXMethodDecl* trace);
- void ReportClassContainsInvalidFields(RecordInfo* info,
- CheckFieldsVisitor::Errors* errors);
+ void ReportClassContainsInvalidFields(
+ RecordInfo* info,
+ const CheckFieldsVisitor::Errors& errors);
void ReportClassContainsGCRoots(RecordInfo* info,
- CheckGCRootsVisitor::Errors* errors);
+ const CheckGCRootsVisitor::Errors& errors);
void ReportFinalizerAccessesFinalizedFields(
clang::CXXMethodDecl* dtor,
- CheckFinalizerVisitor::Errors* fields);
+ const CheckFinalizerVisitor::Errors& errors);
void ReportClassRequiresFinalization(RecordInfo* info);
void ReportClassDoesNotRequireFinalization(RecordInfo* info);
void ReportClassMustDeclareGCMixinTraceMethod(RecordInfo* info);
« no previous file with comments | « no previous file | tools/clang/blink_gc_plugin/BlinkGCPluginConsumer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698