[Interpreter] Refactor bytecode generator test suite.

[Interpreter] Refactor bytecode generator test suite.

Bytecode expectations have been moved to external (.golden) files,
one per test. Each test in the suite builds a representation of the
the compiled bytecode using BytecodeExpectationsPrinter. The output is
then compared to the golden file. If the comparision fails, a textual
diff can be used to identify the discrepancies.

Only the test snippets are left in the cc file, which also allows to
make it more compact and meaningful. Leaving the snippets in the cc
file was a deliberate choice to allow keeping the "truth" about the
tests in the cc file, which will rarely change, as opposed to golden
files.

Golden files can be generated and kept up to date using
generate-bytecode-expectations, which also means that the test suite
can be batch updated whenever the bytecode or golden format changes.

The golden format has been slightly amended (no more comments about
`void*`, add size of the bytecode array) following the consideration
made while converting the tests.

There is also a fix: BytecodeExpectationsPrinter::top_level_ was left
uninitialized, leading to undefined behaviour.

BUG=v8:4280
LOG=N

Committed: https://crrev.com/6ae030590dd7e58a914486e53df35571cd91b638
Cr-Commit-Position: refs/heads/master@{#34285}

[Stefano Sanfilippo, 2016-02-22 14:34:19]

The CQ bit was checked by ssanfilippo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-22 14:34:27]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1717293002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1717293002/1

[Stefano Sanfilippo, 2016-02-22 14:34:50]

ssanfilippo@chromium.org changed reviewers:
+ rmcilroy@chromium.org

[Stefano Sanfilippo, 2016-02-22 14:34:51]

Here is the test refactor mega-commit. PTAL.

[commit-bot: I haz the power, 2016-02-22 14:46:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-22 14:46:33]

Dry run: Try jobs failed on following builders:
  v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/...)

[Stefano Sanfilippo, 2016-02-22 15:43:49]

The CQ bit was checked by ssanfilippo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-22 15:43:58]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1717293002/10001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1717293002/10001

[commit-bot: I haz the power, 2016-02-22 15:48:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-22 15:48:50]

Dry run: Try jobs failed on following builders:
  v8_mac_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/15794)

[oth, 2016-02-22 15:54:30]

oth@chromium.org changed reviewers:
+ oth@chromium.org

[oth, 2016-02-22 15:54:31]

Driveby comment below.

https://codereview.chromium.org/1717293002/diff/1/test/cctest/interpreter/Cal...
File test/cctest/interpreter/CallRuntime.golden (right):

https://codereview.chromium.org/1717293002/diff/1/test/cctest/interpreter/Cal...
test/cctest/interpreter/CallRuntime.golden:20: B(CallRuntime), U16(72), R(0),
U8(0),
It will generate less churn if runtime function id constants are identified by
their symbolic name rather than the raw ordinal. Runtime::FunctionForId will
yield this information. One option to help with this would be have a RuntimeId
operand type rather using kIdx16

[Stefano Sanfilippo, 2016-02-22 16:28:33]

The CQ bit was checked by ssanfilippo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-22 16:28:40]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1717293002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1717293002/20001

[commit-bot: I haz the power, 2016-02-22 16:33:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-22 16:33:36]

Dry run: Try jobs failed on following builders:
  v8_mac_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/15801)

[Stefano Sanfilippo, 2016-02-22 16:57:44]

The CQ bit was checked by ssanfilippo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-22 16:57:54]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1717293002/30001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1717293002/30001

[commit-bot: I haz the power, 2016-02-22 17:00:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-22 17:00:35]

Dry run: Try jobs failed on following builders:
  v8_mac_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/15803)

[rmcilroy, 2016-02-22 21:49:50]

Looks good overall. A couple of high level comments - I'll take a more in-depth
look tomorrow.

https://codereview.chromium.org/1717293002/diff/1/test/cctest/interpreter/Cal...
File test/cctest/interpreter/CallRuntime.golden (right):

https://codereview.chromium.org/1717293002/diff/1/test/cctest/interpreter/Cal...
test/cctest/interpreter/CallRuntime.golden:20: B(CallRuntime), U16(72), R(0),
U8(0),
On 2016/02/22 15:54:31, oth wrote:
> It will generate less churn if runtime function id constants are identified by
> their symbolic name rather than the raw ordinal. Runtime::FunctionForId will
> yield this information. One option to help with this would be have a RuntimeId
> operand type rather using kIdx16

+1!

https://codereview.chromium.org/1717293002/diff/30001/test/cctest/cctest.isolate
File test/cctest/cctest.isolate (right):

https://codereview.chromium.org/1717293002/diff/30001/test/cctest/cctest.isol...
test/cctest/cctest.isolate:9: './interpreter/',
Should you add each golden file, or did machenbach@ suggest this?

https://codereview.chromium.org/1717293002/diff/30001/test/cctest/interpreter...
File test/cctest/interpreter/ArrayLiterals.golden (right):

https://codereview.chromium.org/1717293002/diff/30001/test/cctest/interpreter...
test/cctest/interpreter/ArrayLiterals.golden:31: frame size: 4  # in multiples
of sizeof(void*)
nit - drop the comment here

https://codereview.chromium.org/1717293002/diff/30001/test/cctest/interpreter...
test/cctest/interpreter/ArrayLiterals.golden:81: parameter count: 1
Could you add a bytecode length field - this would make it easy to spot if
changes increase or decrease a function's bytecode length.

https://codereview.chromium.org/1717293002/diff/30001/test/cctest/interpreter...
File test/cctest/interpreter/BasicLoops.golden (right):

https://codereview.chromium.org/1717293002/diff/30001/test/cctest/interpreter...
test/cctest/interpreter/BasicLoops.golden:31: var x = 0;while (false) {  x = x +
1;};return x;
please add newlines to the snippets between statements (i.e., add a '\n' before
every newline in the test's snippets).

[Stefano Sanfilippo, 2016-02-23 11:39:59]

The CQ bit was checked by ssanfilippo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-23 11:40:03]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1717293002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1717293002/40001

[commit-bot: I haz the power, 2016-02-23 11:44:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-23 11:44:33]

Dry run: Try jobs failed on following builders:
  v8_mac_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/15845)

[Stefano Sanfilippo, 2016-02-23 13:20:55]

The CQ bit was checked by ssanfilippo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-23 13:20:59]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1717293002/50001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1717293002/50001

[commit-bot: I haz the power, 2016-02-23 13:44:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-23 13:45:00]

Dry run: This issue passed the CQ dry run.

[Stefano Sanfilippo, 2016-02-23 15:57:18]

https://codereview.chromium.org/1717293002/diff/1/test/cctest/interpreter/Cal...
File test/cctest/interpreter/CallRuntime.golden (right):

https://codereview.chromium.org/1717293002/diff/1/test/cctest/interpreter/Cal...
test/cctest/interpreter/CallRuntime.golden:20: B(CallRuntime), U16(72), R(0),
U8(0),
On 2016/02/22 21:49:49, rmcilroy wrote:
> On 2016/02/22 15:54:31, oth wrote:
> > It will generate less churn if runtime function id constants are identified
by
> > their symbolic name rather than the raw ordinal. Runtime::FunctionForId will
> > yield this information. One option to help with this would be have a
RuntimeId
> > operand type rather using kIdx16
> 
> +1!

Definitely. As agreed, I will prepare a follow-up CL for this.

https://codereview.chromium.org/1717293002/diff/30001/test/cctest/cctest.isolate
File test/cctest/cctest.isolate (right):

https://codereview.chromium.org/1717293002/diff/30001/test/cctest/cctest.isol...
test/cctest/cctest.isolate:9: './interpreter/',
On 2016/02/22 21:49:49, rmcilroy wrote:
> Should you add each golden file, or did machenbach@ suggest this?

machenbach@ suggested to do so. This way we also eliminate one possible source
of confusion, when one adds a golden file but forgets to register it here.

We might want to move all .golden files to a subdirectory, e.g.
./interpreter/golden. WDYT?

https://codereview.chromium.org/1717293002/diff/30001/test/cctest/interpreter...
File test/cctest/interpreter/ArrayLiterals.golden (right):

https://codereview.chromium.org/1717293002/diff/30001/test/cctest/interpreter...
test/cctest/interpreter/ArrayLiterals.golden:31: frame size: 4  # in multiples
of sizeof(void*)
On 2016/02/22 21:49:49, rmcilroy wrote:
> nit - drop the comment here

Done.

https://codereview.chromium.org/1717293002/diff/30001/test/cctest/interpreter...
test/cctest/interpreter/ArrayLiterals.golden:81: parameter count: 1
On 2016/02/22 21:49:49, rmcilroy wrote:
> Could you add a bytecode length field - this would make it easy to spot if
> changes increase or decrease a function's bytecode length.

Done.

https://codereview.chromium.org/1717293002/diff/30001/test/cctest/interpreter...
File test/cctest/interpreter/BasicLoops.golden (right):

https://codereview.chromium.org/1717293002/diff/30001/test/cctest/interpreter...
test/cctest/interpreter/BasicLoops.golden:31: var x = 0;while (false) {  x = x +
1;};return x;
On 2016/02/22 21:49:49, rmcilroy wrote:
> please add newlines to the snippets between statements (i.e., add a '\n'
before
> every newline in the test's snippets).

Done.

[Stefano Sanfilippo, 2016-02-23 16:01:37]

Description was changed from

==========
[Interpreter] Refactor bytecode generator test suite.

Bytecode expectations have been moved to external (.golden) files,
one per test. Each test in the suite builds a representation of the
the compiled bytecode using BytecodeExpectationsPrinter. The output is
then compared to the golden file. If the comparision fails, a textual
diff can be used to identify the discrepancies.

Only the test snippets are left in the cc file, which also allows to
make it more compact and meaningful, also cutting the size by a 10
factor. Leaving the snippets in the cc file was a deliberate choice to
allow keeping the "truth" about the tests in the cc file, which will
rarely change, as opposed to the golden files.

Golden files can be generated and kept up to date using
generate-bytecode-expectations, which also means that the test suite
can be batch updated whenever the bytecode or golden format changes.

BUG=v8:4280
LOG=N
==========

to

==========
[Interpreter] Refactor bytecode generator test suite.

Bytecode expectations have been moved to external (.golden) files,
one per test. Each test in the suite builds a representation of the
the compiled bytecode using BytecodeExpectationsPrinter. The output is
then compared to the golden file. If the comparision fails, a textual
diff can be used to identify the discrepancies.

Only the test snippets are left in the cc file, which also allows to
make it more compact and meaningful, also cutting the size by a 10
factor. Leaving the snippets in the cc file was a deliberate choice to
allow keeping the "truth" about the tests in the cc file, which will
rarely change, as opposed to the golden files.

Golden files can be generated and kept up to date using
generate-bytecode-expectations, which also means that the test suite
can be batch updated whenever the bytecode or golden format changes.

The output format has been slightly amended (no more comments about
`void*`, add size of the bytecode array) while converting the tests.

There is also a fix for BytecodeExpectationsPrinter::top_level_, which
previously was left uninitialized, leading to undefined behaviour.

BUG=v8:4280
LOG=N
==========

[Stefano Sanfilippo, 2016-02-23 16:02:12]

Description was changed from

==========
[Interpreter] Refactor bytecode generator test suite.

Bytecode expectations have been moved to external (.golden) files,
one per test. Each test in the suite builds a representation of the
the compiled bytecode using BytecodeExpectationsPrinter. The output is
then compared to the golden file. If the comparision fails, a textual
diff can be used to identify the discrepancies.

Only the test snippets are left in the cc file, which also allows to
make it more compact and meaningful, also cutting the size by a 10
factor. Leaving the snippets in the cc file was a deliberate choice to
allow keeping the "truth" about the tests in the cc file, which will
rarely change, as opposed to the golden files.

Golden files can be generated and kept up to date using
generate-bytecode-expectations, which also means that the test suite
can be batch updated whenever the bytecode or golden format changes.

The output format has been slightly amended (no more comments about
`void*`, add size of the bytecode array) while converting the tests.

There is also a fix for BytecodeExpectationsPrinter::top_level_, which
previously was left uninitialized, leading to undefined behaviour.

BUG=v8:4280
LOG=N
==========

to

==========
[Interpreter] Refactor bytecode generator test suite.

Bytecode expectations have been moved to external (.golden) files,
one per test. Each test in the suite builds a representation of the
the compiled bytecode using BytecodeExpectationsPrinter. The output is
then compared to the golden file. If the comparision fails, a textual
diff can be used to identify the discrepancies.

Only the test snippets are left in the cc file, which also allows to
make it more compact and meaningful, also cutting the size by a 10
factor. Leaving the snippets in the cc file was a deliberate choice to
allow keeping the "truth" about the tests in the cc file, which will
rarely change, as opposed to the golden files.

Golden files can be generated and kept up to date using
generate-bytecode-expectations, which also means that the test suite
can be batch updated whenever the bytecode or golden format changes.

The output format has been slightly amended (no more comments about
`void*`, add size of the bytecode array) following the consideration
made while converting the tests.

There is also a fix for BytecodeExpectationsPrinter::top_level_, which
previously was left uninitialized, leading to undefined behaviour.

BUG=v8:4280
LOG=N
==========

[Stefano Sanfilippo, 2016-02-23 16:02:25]

The CQ bit was checked by ssanfilippo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-23 16:02:31]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1717293002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1717293002/60001

[commit-bot: I haz the power, 2016-02-23 16:39:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-23 16:39:11]

Dry run: This issue passed the CQ dry run.

[Stefano Sanfilippo, 2016-02-23 17:26:03]

The CQ bit was checked by ssanfilippo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-23 17:26:12]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1717293002/70001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1717293002/70001

[Stefano Sanfilippo, 2016-02-23 18:35:03]

The CQ bit was checked by ssanfilippo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-23 18:35:19]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1717293002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1717293002/80001

[commit-bot: I haz the power, 2016-02-23 19:04:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-23 19:04:12]

Dry run: This issue passed the CQ dry run.

[rmcilroy, 2016-02-24 08:55:36]

Looks great overall. Mostly just formatting issues of the snippets which have
been exposed by the new format, however there is also a test which seems to have
been removed accidentally.

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
File test/cctest/interpreter/bytecode_expectations/ArrayLiterals.golden (right):

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/bytecode_expectations/ArrayLiterals.golden:2: #
Autogenerated by generate-bytecode-expectations
nit - fullstop at the end of the header.

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
File test/cctest/interpreter/bytecode_expectations/ClassDeclarations.golden
(right):

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/bytecode_expectations/ClassDeclarations.golden:120: var
n0 = 'a';var n1 = 'b';class N {
newlines between semicolons

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
File test/cctest/interpreter/bytecode_expectations/IfConditions.golden (right):

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/bytecode_expectations/IfConditions.golden:13: function
f() { if (0) { return 1; } else { return -1; } } f()
semicolone and newline between final "}" and "f" (for all the tests in this
file)

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/bytecode_expectations/IfConditions.golden:163: b = a; a
= b;
indent each of these lines

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/bytecode_expectations/IfConditions.golden:391: b = a; a
= b;
ditto

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/bytecode_expectations/IfConditions.golden:700: } else {
fix if / else indentation please

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
File test/cctest/interpreter/bytecode_expectations/LoadGlobal.golden (right):

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/bytecode_expectations/LoadGlobal.golden:75: b.name;
fix indenting

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
File test/cctest/interpreter/bytecode_expectations/LogicalExpressions.golden
(right):

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/bytecode_expectations/LogicalExpressions.golden:150: a =
1, b = 2,
indent the lines by 2 spaces

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/bytecode_expectations/LogicalExpressions.golden:336: a =
1, b = 2,
ditto

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/bytecode_expectations/LogicalExpressions.golden:522: a =
1, b = 2,
ditto

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/bytecode_expectations/LogicalExpressions.golden:711: a =
1, b = 2,
ditto

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
File test/cctest/interpreter/bytecode_expectations/LookupSlotInEval.golden
(right):

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/bytecode_expectations/LookupSlotInEval.golden:16:
eval(\"function t() {return x;        }; f = t; f();\");
Remove extra whitespace (here and below)

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
File test/cctest/interpreter/bytecode_expectations/LookupSlotWideInEval.golden
(right):

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/bytecode_expectations/LookupSlotWideInEval.golden:16:
eval(\"function t() {var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; return x; 
      }; f = t; f();\");
indent and newline between each var.

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/bytecode_expectations/LookupSlotWideInEval.golden:807:
eval(\"function t() {var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; return
typeof x;        }; f = t; f();\");
ditto

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/bytecode_expectations/LookupSlotWideInEval.golden:1599:
eval(\"function t() {var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; x = 10;   
    }; f = t; f();\");
ditto

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/bytecode_expectations/LookupSlotWideInEval.golden:2392:
eval(\"function t() {'use strict';var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; x = 10;        }; f = t; f();\");
ditto

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
File test/cctest/interpreter/bytecode_expectations/ObjectLiteralsWide.golden
(right):

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/bytecode_expectations/ObjectLiteralsWide.golden:268: a =
1.23;return { name: 'string', val: 9.2 };
newline before return

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
File test/cctest/interpreter/bytecode_expectations/PropertyLoads.golden (right):

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/bytecode_expectations/PropertyLoads.golden:100: b =
a.name;
indentation

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/bytecode_expectations/PropertyLoads.golden:228: return
a.name; }
newline before "}"

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/bytecode_expectations/PropertyLoads.golden:764: c =
a[b];
indentation

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/bytecode_expectations/PropertyLoads.golden:891: return
a[b]; }
newline before "}"

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
File test/cctest/interpreter/bytecode_expectations/PropertyStores.golden
(right):

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/bytecode_expectations/PropertyStores.golden:187: a.name
= 1;
indentation

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/bytecode_expectations/PropertyStores.golden:315: a.name
= 2; }
newline before "}"

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/bytecode_expectations/PropertyStores.golden:853: a.name
= 1;
ditto (and below)

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/bytecode_expectations/PropertyStores.golden:980: a.name
= 2; }
ditto (and below)

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
File test/cctest/interpreter/bytecode_expectations/RegExpLiteralsWide.golden
(right):

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/bytecode_expectations/RegExpLiteralsWide.golden:268: a =
1.23;return /ab+d/;
newline

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
File test/cctest/interpreter/bytecode_expectations/StoreGlobal.golden (right):

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/bytecode_expectations/StoreGlobal.golden:100: a =
1;function f(b) {
newline

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/bytecode_expectations/StoreGlobal.golden:102: b.name;
indentation

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/bytecode_expectations/StoreGlobal.golden:229: a = 2; }
newline before "}"

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/bytecode_expectations/StoreGlobal.golden:635: a =
1;function f(b) {
ditto (and below)

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
File test/cctest/interpreter/bytecode_expectations/Switch.golden (right):

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/bytecode_expectations/Switch.golden:307: break;
indentation

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
File test/cctest/interpreter/bytecode_expectations/ThisFunction.golden (right):

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/bytecode_expectations/ThisFunction.golden:14: f =
function f() { }
indentation (and below)

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
File test/cctest/interpreter/bytecode_expectations/Typeof.golden (right):

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/bytecode_expectations/Typeof.golden:16: }; f();
remove extra f() on this line

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/bytecode_expectations/Typeof.golden:39: }; f();
ditto

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
File test/cctest/interpreter/test-bytecode-generator.cc (right):

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/test-bytecode-generator.cc:76: std::cerr <<
golden_filename << '\n';
Is this for debugging? Please remove it, we don't want the tests spamming
std::err.

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/test-bytecode-generator.cc:80: expected_stream <<
"---\n" << expected_file.rdbuf();
Please add a comment on why this is necessary.

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/test-bytecode-generator.cc:100: typedef
BytecodeExpectationsPrinter::ConstantPoolType ConstantPoolType;
can you do this with a "using" instead of a typedef?

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/test-bytecode-generator.cc:266: " var b;\n"
What's happened with the indentation (here and in a load of the tests below?).
The string quotes should all be at the same indent level. Was this git cl
format?

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/test-bytecode-generator.cc:1092: "'use strict';\n"
You've skipped the REPEAT_249_UNIQUE_VARS() test here, please add it back.

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/test-bytecode-generator.cc:1311: // (150+ instructions)
to adapt manually.
Remove TODO

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/test-bytecode-generator.cc:1506: "return (x = 2, y = 3,
x = 4, y = 5)",
nit - I realize this wasn't your change, but please add a ';' at end of each
line

[oth, 2016-02-24 13:43:56]

Wow, biggest CL I've seen :-)

There are a few comments below but nothing serious. Looking good.

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
File test/cctest/interpreter/bytecode_expectations/ArrayLiteralsWide.golden
(right):

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/bytecode_expectations/ArrayLiteralsWide.golden:268: a =
1.23;return [ 1 , 2 ];
newline.

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
File test/cctest/interpreter/test-bytecode-generator.cc (right):

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/test-bytecode-generator.cc:19: namespace interpreter {
I'd be inclined to have some doc comments here that explain how the tests in
this file work and an example showing the use of generate-bytecode-expectations.

Suggesting this would be helpful for people not familiar with the interpreter.
They may find themselves here and some guidance should help reduce the time
spent working on fixes.

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/test-bytecode-generator.cc:574: "var x = 0;\n"
clang-format off

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/test-bytecode-generator.cc:716: "}\n",
clang-format on

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/test-bytecode-generator.cc:1283: const char* snippets[]
= {
// clang-format off

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/test-bytecode-generator.cc:1303: "for (x[0] in [1,2,3])
{ return x[3]; }",
// clang-format on

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/test-bytecode-generator.cc:1676: "x0 = x127;\n"
clang-format off

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/test-bytecode-generator.cc:1707: "return x1;\n",
clang-format on

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/test-bytecode-generator.cc:1846: "class Person {\n"
clang-format off

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/test-bytecode-generator.cc:1865: "return new C();\n",
clang-format on

[oth, 2016-02-24 13:43:59]

Wow, biggest CL I've seen :-)

There are a few comments below but nothing serious. Looking good.

[Stefano Sanfilippo, 2016-02-24 14:55:02]

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
File test/cctest/interpreter/bytecode_expectations/ArrayLiterals.golden (right):

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/bytecode_expectations/ArrayLiterals.golden:2: #
Autogenerated by generate-bytecode-expectations
On 2016/02/24 08:55:34, rmcilroy wrote:
> nit - fullstop at the end of the header.

Done.

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
File test/cctest/interpreter/bytecode_expectations/ArrayLiteralsWide.golden
(right):

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/bytecode_expectations/ArrayLiteralsWide.golden:268: a =
1.23;return [ 1 , 2 ];
On 2016/02/24 13:43:55, oth wrote:
> newline.

Done.

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
File test/cctest/interpreter/bytecode_expectations/ClassDeclarations.golden
(right):

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/bytecode_expectations/ClassDeclarations.golden:120: var
n0 = 'a';var n1 = 'b';class N {
On 2016/02/24 08:55:35, rmcilroy wrote:
> newlines between semicolons

Done.

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
File test/cctest/interpreter/bytecode_expectations/IfConditions.golden (right):

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/bytecode_expectations/IfConditions.golden:13: function
f() { if (0) { return 1; } else { return -1; } } f()
On 2016/02/24 08:55:34, rmcilroy wrote:
> semicolone and newline between final "}" and "f" (for all the tests in this
> file)

Done.

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/bytecode_expectations/IfConditions.golden:163: b = a; a
= b;
On 2016/02/24 08:55:34, rmcilroy wrote:
> indent each of these lines

Done.

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/bytecode_expectations/IfConditions.golden:391: b = a; a
= b;
On 2016/02/24 08:55:34, rmcilroy wrote:
> ditto

Done.

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/bytecode_expectations/IfConditions.golden:700: } else {
On 2016/02/24 08:55:34, rmcilroy wrote:
> fix if / else indentation please

Done.

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
File test/cctest/interpreter/bytecode_expectations/LoadGlobal.golden (right):

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/bytecode_expectations/LoadGlobal.golden:75: b.name;
On 2016/02/24 08:55:36, rmcilroy wrote:
> fix indenting

Done.

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
File test/cctest/interpreter/bytecode_expectations/LogicalExpressions.golden
(right):

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/bytecode_expectations/LogicalExpressions.golden:150: a =
1, b = 2,
On 2016/02/24 08:55:35, rmcilroy wrote:
> indent the lines by 2 spaces

Done.

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/bytecode_expectations/LogicalExpressions.golden:336: a =
1, b = 2,
On 2016/02/24 08:55:35, rmcilroy wrote:
> ditto

Done.

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/bytecode_expectations/LogicalExpressions.golden:522: a =
1, b = 2,
On 2016/02/24 08:55:35, rmcilroy wrote:
> ditto

Done.

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/bytecode_expectations/LogicalExpressions.golden:711: a =
1, b = 2,
On 2016/02/24 08:55:35, rmcilroy wrote:
> ditto

Done.

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
File test/cctest/interpreter/bytecode_expectations/LookupSlotInEval.golden
(right):

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/bytecode_expectations/LookupSlotInEval.golden:16:
eval(\"function t() {return x;        }; f = t; f();\");
On 2016/02/24 08:55:35, rmcilroy wrote:
> Remove extra whitespace (here and below)

Done.

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
File test/cctest/interpreter/bytecode_expectations/LookupSlotWideInEval.golden
(right):

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/bytecode_expectations/LookupSlotWideInEval.golden:16:
eval(\"function t() {var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; return x; 
      }; f = t; f();\");
On 2016/02/24 08:55:34, rmcilroy wrote:
> indent and newline between each var.

Done.

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/bytecode_expectations/LookupSlotWideInEval.golden:807:
eval(\"function t() {var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; return
typeof x;        }; f = t; f();\");
On 2016/02/24 08:55:34, rmcilroy wrote:
> ditto

Done.

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/bytecode_expectations/LookupSlotWideInEval.golden:1599:
eval(\"function t() {var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; x = 10;   
    }; f = t; f();\");
On 2016/02/24 08:55:34, rmcilroy wrote:
> ditto

Done.

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/bytecode_expectations/LookupSlotWideInEval.golden:2392:
eval(\"function t() {'use strict';var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y = 2.3; var y =
2.3; x = 10;        }; f = t; f();\");
On 2016/02/24 08:55:34, rmcilroy wrote:
> ditto

Done.

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
File test/cctest/interpreter/bytecode_expectations/ObjectLiteralsWide.golden
(right):

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/bytecode_expectations/ObjectLiteralsWide.golden:268: a =
1.23;return { name: 'string', val: 9.2 };
On 2016/02/24 08:55:35, rmcilroy wrote:
> newline before return

Done.

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
File test/cctest/interpreter/bytecode_expectations/PropertyLoads.golden (right):

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/bytecode_expectations/PropertyLoads.golden:100: b =
a.name;
On 2016/02/24 08:55:36, rmcilroy wrote:
> indentation

Done.

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/bytecode_expectations/PropertyLoads.golden:228: return
a.name; }
On 2016/02/24 08:55:36, rmcilroy wrote:
> newline before "}"

Done.

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/bytecode_expectations/PropertyLoads.golden:764: c =
a[b];
On 2016/02/24 08:55:36, rmcilroy wrote:
> indentation

Done.

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/bytecode_expectations/PropertyLoads.golden:891: return
a[b]; }
On 2016/02/24 08:55:36, rmcilroy wrote:
> newline before "}"

Done.

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
File test/cctest/interpreter/bytecode_expectations/PropertyStores.golden
(right):

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/bytecode_expectations/PropertyStores.golden:187: a.name
= 1;
On 2016/02/24 08:55:34, rmcilroy wrote:
> indentation

Done.

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/bytecode_expectations/PropertyStores.golden:315: a.name
= 2; }
On 2016/02/24 08:55:34, rmcilroy wrote:
> newline before "}"

Done.

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/bytecode_expectations/PropertyStores.golden:853: a.name
= 1;
On 2016/02/24 08:55:34, rmcilroy wrote:
> ditto (and below)

Done.

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/bytecode_expectations/PropertyStores.golden:980: a.name
= 2; }
On 2016/02/24 08:55:34, rmcilroy wrote:
> ditto (and below)

Done.

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
File test/cctest/interpreter/bytecode_expectations/RegExpLiteralsWide.golden
(right):

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/bytecode_expectations/RegExpLiteralsWide.golden:268: a =
1.23;return /ab+d/;
On 2016/02/24 08:55:35, rmcilroy wrote:
> newline

Done.

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
File test/cctest/interpreter/bytecode_expectations/StoreGlobal.golden (right):

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/bytecode_expectations/StoreGlobal.golden:100: a =
1;function f(b) {
On 2016/02/24 08:55:35, rmcilroy wrote:
> newline

Done.

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/bytecode_expectations/StoreGlobal.golden:102: b.name;
On 2016/02/24 08:55:35, rmcilroy wrote:
> indentation

Done.

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/bytecode_expectations/StoreGlobal.golden:229: a = 2; }
On 2016/02/24 08:55:35, rmcilroy wrote:
> newline before "}"

Done.

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/bytecode_expectations/StoreGlobal.golden:635: a =
1;function f(b) {
On 2016/02/24 08:55:35, rmcilroy wrote:
> ditto (and below)

Done.

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
File test/cctest/interpreter/bytecode_expectations/Switch.golden (right):

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/bytecode_expectations/Switch.golden:307: break;
On 2016/02/24 08:55:35, rmcilroy wrote:
> indentation

Done.

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
File test/cctest/interpreter/bytecode_expectations/ThisFunction.golden (right):

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/bytecode_expectations/ThisFunction.golden:14: f =
function f() { }
On 2016/02/24 08:55:34, rmcilroy wrote:
> indentation (and below)

Done.

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
File test/cctest/interpreter/bytecode_expectations/Typeof.golden (right):

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/bytecode_expectations/Typeof.golden:16: }; f();
On 2016/02/24 08:55:35, rmcilroy wrote:
> remove extra f() on this line

Done.

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/bytecode_expectations/Typeof.golden:39: }; f();
On 2016/02/24 08:55:35, rmcilroy wrote:
> ditto

Done.

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
File test/cctest/interpreter/test-bytecode-generator.cc (right):

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/test-bytecode-generator.cc:19: namespace interpreter {
On 2016/02/24 13:43:55, oth wrote:
> I'd be inclined to have some doc comments here that explain how the tests in
> this file work and an example showing the use of
generate-bytecode-expectations.
> 
> Suggesting this would be helpful for people not familiar with the interpreter.
> They may find themselves here and some guidance should help reduce the time
> spent working on fixes.

Agreed. I am working on it.

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/test-bytecode-generator.cc:76: std::cerr <<
golden_filename << '\n';
On 2016/02/24 08:55:35, rmcilroy wrote:
> Is this for debugging? Please remove it, we don't want the tests spamming
> std::err.

Done.

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/test-bytecode-generator.cc:80: expected_stream <<
"---\n" << expected_file.rdbuf();
On 2016/02/24 08:55:35, rmcilroy wrote:
> Please add a comment on why this is necessary.

Done.

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/test-bytecode-generator.cc:100: typedef
BytecodeExpectationsPrinter::ConstantPoolType ConstantPoolType;
On 2016/02/24 08:55:35, rmcilroy wrote:
> can you do this with a "using" instead of a typedef?

Done.

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/test-bytecode-generator.cc:266: " var b;\n"
On 2016/02/24 08:55:35, rmcilroy wrote:
> What's happened with the indentation (here and in a load of the tests below?).
> The string quotes should all be at the same indent level. Was this git cl
> format?

No it was me. Fixed.

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/test-bytecode-generator.cc:574: "var x = 0;\n"
On 2016/02/24 13:43:55, oth wrote:
> clang-format off

I was discussing with rmcilroy the best way to tell cl format to leave the
snippets as they are formatted and he'd rather not have clang-format off. He
suggested we add a trailing //, but I think it's a bit too much.

Saving this for another patchset and ditto for all the other occurences.

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/test-bytecode-generator.cc:1092: "'use strict';\n"
On 2016/02/24 08:55:35, rmcilroy wrote:
> You've skipped the REPEAT_249_UNIQUE_VARS() test here, please add it back.

Done.

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/test-bytecode-generator.cc:1311: // (150+ instructions)
to adapt manually.
On 2016/02/24 08:55:35, rmcilroy wrote:
> Remove TODO

Done.

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/test-bytecode-generator.cc:1506: "return (x = 2, y = 3,
x = 4, y = 5)",
On 2016/02/24 08:55:35, rmcilroy wrote:
> nit - I realize this wasn't your change, but please add a ';' at end of each
> line

Done.

[Stefano Sanfilippo, 2016-02-24 16:32:15]

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
File test/cctest/interpreter/test-bytecode-generator.cc (right):

https://codereview.chromium.org/1717293002/diff/80001/test/cctest/interpreter...
test/cctest/interpreter/test-bytecode-generator.cc:574: "var x = 0;\n"
On 2016/02/24 13:43:55, oth wrote:
> clang-format off

Actually, I made the cc file go through cl format without any major change, so
we don't need it anymore.

[Stefano Sanfilippo, 2016-02-24 16:43:06]

The CQ bit was checked by ssanfilippo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-24 16:43:13]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1717293002/110001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1717293002/110001

[Stefano Sanfilippo, 2016-02-24 16:45:39]

Description was changed from

==========
[Interpreter] Refactor bytecode generator test suite.

Bytecode expectations have been moved to external (.golden) files,
one per test. Each test in the suite builds a representation of the
the compiled bytecode using BytecodeExpectationsPrinter. The output is
then compared to the golden file. If the comparision fails, a textual
diff can be used to identify the discrepancies.

Only the test snippets are left in the cc file, which also allows to
make it more compact and meaningful, also cutting the size by a 10
factor. Leaving the snippets in the cc file was a deliberate choice to
allow keeping the "truth" about the tests in the cc file, which will
rarely change, as opposed to the golden files.

Golden files can be generated and kept up to date using
generate-bytecode-expectations, which also means that the test suite
can be batch updated whenever the bytecode or golden format changes.

The output format has been slightly amended (no more comments about
`void*`, add size of the bytecode array) following the consideration
made while converting the tests.

There is also a fix for BytecodeExpectationsPrinter::top_level_, which
previously was left uninitialized, leading to undefined behaviour.

BUG=v8:4280
LOG=N
==========

to

==========
[Interpreter] Refactor bytecode generator test suite.

Bytecode expectations have been moved to external (.golden) files,
one per test. Each test in the suite builds a representation of the
the compiled bytecode using BytecodeExpectationsPrinter. The output is
then compared to the golden file. If the comparision fails, a textual
diff can be used to identify the discrepancies.

Only the test snippets are left in the cc file, which also allows to
make it more compact and meaningful. Leaving the snippets in the cc
file was a deliberate choice to allow keeping the "truth" about the
tests in the cc file, which will rarely change, as opposed to the 
golden files.

Golden files can be generated and kept up to date using
generate-bytecode-expectations, which also means that the test suite
can be batch updated whenever the bytecode or golden format changes.

The output format has been slightly amended (no more comments about
`void*`, add size of the bytecode array) following the consideration
made while converting the tests.

There is also a fix for BytecodeExpectationsPrinter::top_level_, which
previously was left uninitialized, leading to undefined behaviour.

BUG=v8:4280
LOG=N
==========

[Stefano Sanfilippo, 2016-02-24 16:46:14]

Description was changed from

==========
[Interpreter] Refactor bytecode generator test suite.

Bytecode expectations have been moved to external (.golden) files,
one per test. Each test in the suite builds a representation of the
the compiled bytecode using BytecodeExpectationsPrinter. The output is
then compared to the golden file. If the comparision fails, a textual
diff can be used to identify the discrepancies.

Only the test snippets are left in the cc file, which also allows to
make it more compact and meaningful. Leaving the snippets in the cc
file was a deliberate choice to allow keeping the "truth" about the
tests in the cc file, which will rarely change, as opposed to the 
golden files.

Golden files can be generated and kept up to date using
generate-bytecode-expectations, which also means that the test suite
can be batch updated whenever the bytecode or golden format changes.

The output format has been slightly amended (no more comments about
`void*`, add size of the bytecode array) following the consideration
made while converting the tests.

There is also a fix for BytecodeExpectationsPrinter::top_level_, which
previously was left uninitialized, leading to undefined behaviour.

BUG=v8:4280
LOG=N
==========

to

==========
[Interpreter] Refactor bytecode generator test suite.

Bytecode expectations have been moved to external (.golden) files,
one per test. Each test in the suite builds a representation of the
the compiled bytecode using BytecodeExpectationsPrinter. The output is
then compared to the golden file. If the comparision fails, a textual
diff can be used to identify the discrepancies.

Only the test snippets are left in the cc file, which also allows to
make it more compact and meaningful. Leaving the snippets in the cc
file was a deliberate choice to allow keeping the "truth" about the
tests in the cc file, which will rarely change, as opposed to the 
golden files.

Golden files can be generated and kept up to date using
generate-bytecode-expectations, which also means that the test suite
can be batch updated whenever the bytecode or golden format changes.

The golden format has been slightly amended (no more comments about
`void*`, add size of the bytecode array) following the consideration
made while converting the tests.

There is also a fix for BytecodeExpectationsPrinter::top_level_, which
previously was left uninitialized, leading to undefined behaviour.

BUG=v8:4280
LOG=N
==========

[commit-bot: I haz the power, 2016-02-24 17:05:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-24 17:05:17]

Dry run: This issue passed the CQ dry run.

[Stefano Sanfilippo, 2016-02-24 17:15:55]

Apparently, a blank line after each snippet is enough to prevent cl format from
putting more than one on a single line.

[rmcilroy, 2016-02-24 17:39:13]

A few final nits, but LGTM. Let's land this beast!

https://codereview.chromium.org/1717293002/diff/110001/test/cctest/interprete...
File test/cctest/interpreter/test-bytecode-generator.cc (right):

https://codereview.chromium.org/1717293002/diff/110001/test/cctest/interprete...
test/cctest/interpreter/test-bytecode-generator.cc:197: REPEAT_32("\n  a = 1, b
= 2, ") "3);",
Could you put the "3);" (i.e., anything following a REPEAT_XXX()) on a newline
(without causing git cl format to mess things up) 

(throughout CL)

https://codereview.chromium.org/1717293002/diff/110001/test/cctest/interprete...
test/cctest/interpreter/test-bytecode-generator.cc:456: "var a = 1;\nfunction
f() { a = 2; }\nf()",
semicolons before newlines. Also, could you add newlines in the cc file where
there are newlines in the snippet?

https://codereview.chromium.org/1717293002/diff/110001/test/cctest/interprete...
test/cctest/interpreter/test-bytecode-generator.cc:1104: "\na = 1.23;")
"\nreturn { name: 'string', val: 9.2 };",
REPEAT_256 on it's own line if possible

https://codereview.chromium.org/1717293002/diff/110001/test/cctest/interprete...
test/cctest/interpreter/test-bytecode-generator.cc:1331: "var global =
1;\nfunction f() { return ++global; }\nf()",
newlines in cc file for newlines in snippet

https://codereview.chromium.org/1717293002/diff/110001/test/cctest/interprete...
test/cctest/interpreter/test-bytecode-generator.cc:1373: "var global =
1;\nfunction f() { return global &= 1; }\nf()",
newlines in cc file for snippet newlines

https://codereview.chromium.org/1717293002/diff/110001/test/cctest/interprete...
test/cctest/interpreter/test-bytecode-generator.cc:1759: "return x;", "x = 10;",
"'use strict'; x = 10;", "return typeof x;",
newline for each snippet

[Stefano Sanfilippo, 2016-02-24 18:08:47]

https://codereview.chromium.org/1717293002/diff/110001/test/cctest/interprete...
File test/cctest/interpreter/test-bytecode-generator.cc (right):

https://codereview.chromium.org/1717293002/diff/110001/test/cctest/interprete...
test/cctest/interpreter/test-bytecode-generator.cc:197: REPEAT_32("\n  a = 1, b
= 2, ") "3);",
On 2016/02/24 17:39:13, rmcilroy wrote:
> Could you put the "3);" (i.e., anything following a REPEAT_XXX()) on a newline
> (without causing git cl format to mess things up) 
> 
> (throughout CL)

Done.

https://codereview.chromium.org/1717293002/diff/110001/test/cctest/interprete...
test/cctest/interpreter/test-bytecode-generator.cc:456: "var a = 1;\nfunction
f() { a = 2; }\nf()",
On 2016/02/24 17:39:13, rmcilroy wrote:
> semicolons before newlines. Also, could you add newlines in the cc file where
> there are newlines in the snippet?

Done.

https://codereview.chromium.org/1717293002/diff/110001/test/cctest/interprete...
test/cctest/interpreter/test-bytecode-generator.cc:1104: "\na = 1.23;")
"\nreturn { name: 'string', val: 9.2 };",
On 2016/02/24 17:39:13, rmcilroy wrote:
> REPEAT_256 on it's own line if possible

Done.

https://codereview.chromium.org/1717293002/diff/110001/test/cctest/interprete...
test/cctest/interpreter/test-bytecode-generator.cc:1331: "var global =
1;\nfunction f() { return ++global; }\nf()",
On 2016/02/24 17:39:13, rmcilroy wrote:
> newlines in cc file for newlines in snippet

Done.

https://codereview.chromium.org/1717293002/diff/110001/test/cctest/interprete...
test/cctest/interpreter/test-bytecode-generator.cc:1373: "var global =
1;\nfunction f() { return global &= 1; }\nf()",
On 2016/02/24 17:39:13, rmcilroy wrote:
> newlines in cc file for snippet newlines

Done.

https://codereview.chromium.org/1717293002/diff/110001/test/cctest/interprete...
test/cctest/interpreter/test-bytecode-generator.cc:1759: "return x;", "x = 10;",
"'use strict'; x = 10;", "return typeof x;",
On 2016/02/24 17:39:13, rmcilroy wrote:
> newline for each snippet

Done.

[Stefano Sanfilippo, 2016-02-24 18:09:05]

The CQ bit was checked by ssanfilippo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-24 18:09:18]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1717293002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1717293002/120001

[commit-bot: I haz the power, 2016-02-24 18:33:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-24 18:33:26]

Dry run: This issue passed the CQ dry run.

[Stefano Sanfilippo, 2016-02-24 20:10:09]

The CQ bit was checked by ssanfilippo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-24 20:10:16]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1717293002/130001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1717293002/130001

[Stefano Sanfilippo, 2016-02-24 20:11:44]

Description was changed from

==========
[Interpreter] Refactor bytecode generator test suite.

Bytecode expectations have been moved to external (.golden) files,
one per test. Each test in the suite builds a representation of the
the compiled bytecode using BytecodeExpectationsPrinter. The output is
then compared to the golden file. If the comparision fails, a textual
diff can be used to identify the discrepancies.

Only the test snippets are left in the cc file, which also allows to
make it more compact and meaningful. Leaving the snippets in the cc
file was a deliberate choice to allow keeping the "truth" about the
tests in the cc file, which will rarely change, as opposed to the 
golden files.

Golden files can be generated and kept up to date using
generate-bytecode-expectations, which also means that the test suite
can be batch updated whenever the bytecode or golden format changes.

The golden format has been slightly amended (no more comments about
`void*`, add size of the bytecode array) following the consideration
made while converting the tests.

There is also a fix for BytecodeExpectationsPrinter::top_level_, which
previously was left uninitialized, leading to undefined behaviour.

BUG=v8:4280
LOG=N
==========

to

==========
[Interpreter] Refactor bytecode generator test suite.

Bytecode expectations have been moved to external (.golden) files,
one per test. Each test in the suite builds a representation of the
the compiled bytecode using BytecodeExpectationsPrinter. The output is
then compared to the golden file. If the comparision fails, a textual
diff can be used to identify the discrepancies.

Only the test snippets are left in the cc file, which also allows to
make it more compact and meaningful. Leaving the snippets in the cc
file was a deliberate choice to allow keeping the "truth" about the
tests in the cc file, which will rarely change, as opposed to the 
golden files.

Golden files can be generated and kept up to date using
generate-bytecode-expectations, which also means that the test suite
can be batch updated whenever the bytecode or golden format changes.

The golden format has been slightly amended (no more comments about
`void*`, add size of the bytecode array) following the consideration
made while converting the tests.

There is also a fix: BytecodeExpectationsPrinter::top_level_ was left
uninitialized, leading to undefined behaviour.

BUG=v8:4280
LOG=N
==========

[commit-bot: I haz the power, 2016-02-24 20:38:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-24 20:38:23]

Dry run: This issue passed the CQ dry run.

[Stefano Sanfilippo, 2016-02-25 10:32:50]

Description was changed from

==========
[Interpreter] Refactor bytecode generator test suite.

Bytecode expectations have been moved to external (.golden) files,
one per test. Each test in the suite builds a representation of the
the compiled bytecode using BytecodeExpectationsPrinter. The output is
then compared to the golden file. If the comparision fails, a textual
diff can be used to identify the discrepancies.

Only the test snippets are left in the cc file, which also allows to
make it more compact and meaningful. Leaving the snippets in the cc
file was a deliberate choice to allow keeping the "truth" about the
tests in the cc file, which will rarely change, as opposed to the 
golden files.

Golden files can be generated and kept up to date using
generate-bytecode-expectations, which also means that the test suite
can be batch updated whenever the bytecode or golden format changes.

The golden format has been slightly amended (no more comments about
`void*`, add size of the bytecode array) following the consideration
made while converting the tests.

There is also a fix: BytecodeExpectationsPrinter::top_level_ was left
uninitialized, leading to undefined behaviour.

BUG=v8:4280
LOG=N
==========

to

==========
[Interpreter] Refactor bytecode generator test suite.

Bytecode expectations have been moved to external (.golden) files,
one per test. Each test in the suite builds a representation of the
the compiled bytecode using BytecodeExpectationsPrinter. The output is
then compared to the golden file. If the comparision fails, a textual
diff can be used to identify the discrepancies.

Only the test snippets are left in the cc file, which also allows to
make it more compact and meaningful. Leaving the snippets in the cc
file was a deliberate choice to allow keeping the "truth" about the
tests in the cc file, which will rarely change, as opposed to golden
files.

Golden files can be generated and kept up to date using
generate-bytecode-expectations, which also means that the test suite
can be batch updated whenever the bytecode or golden format changes.

The golden format has been slightly amended (no more comments about
`void*`, add size of the bytecode array) following the consideration
made while converting the tests.

There is also a fix: BytecodeExpectationsPrinter::top_level_ was left
uninitialized, leading to undefined behaviour.

BUG=v8:4280
LOG=N
==========

[oth, 2016-02-25 10:42:00]

LGTM. A couple of optional comments, but time to land this. The review tool
suffers at this scale :-)

https://codereview.chromium.org/1717293002/diff/130001/test/cctest/interprete...
File test/cctest/interpreter/test-bytecode-generator.cc (right):

https://codereview.chromium.org/1717293002/diff/130001/test/cctest/interprete...
test/cctest/interpreter/test-bytecode-generator.cc:39: REPEAT_8(__VA_ARGS__)
REPEAT_4(__VA_ARGS__) REPEAT_2(__VA_ARGS__) __VA_ARGS__
Retentively, I'd put each REPEAT_X on it's own line here as it's easier for the
reader to scan downwards rather than downwards and across.

https://codereview.chromium.org/1717293002/diff/130001/test/cctest/interprete...
test/cctest/interpreter/test-bytecode-generator.cc:43: REPEAT_64(__VA_ARGS__)  \
Same comment here about scanning for the reader.

[Stefano Sanfilippo, 2016-02-25 11:38:21]

https://codereview.chromium.org/1717293002/diff/130001/test/cctest/interprete...
File test/cctest/interpreter/test-bytecode-generator.cc (right):

https://codereview.chromium.org/1717293002/diff/130001/test/cctest/interprete...
test/cctest/interpreter/test-bytecode-generator.cc:39: REPEAT_8(__VA_ARGS__)
REPEAT_4(__VA_ARGS__) REPEAT_2(__VA_ARGS__) __VA_ARGS__
On 2016/02/25 10:42:00, oth wrote:
> Retentively, I'd put each REPEAT_X on it's own line here as it's easier for
the
> reader to scan downwards rather than downwards and across.

Done.

https://codereview.chromium.org/1717293002/diff/130001/test/cctest/interprete...
test/cctest/interpreter/test-bytecode-generator.cc:43: REPEAT_64(__VA_ARGS__)  \
On 2016/02/25 10:42:00, oth wrote:
> Same comment here about scanning for the reader.

Done.

[Stefano Sanfilippo, 2016-02-25 11:38:47]

The CQ bit was checked by ssanfilippo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-25 11:38:55]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1717293002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1717293002/140001

[commit-bot: I haz the power, 2016-02-25 12:02:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-25 12:02:15]

Dry run: This issue passed the CQ dry run.

[Stefano Sanfilippo, 2016-02-25 12:02:48]

The CQ bit was checked by ssanfilippo@chromium.org

[Stefano Sanfilippo, 2016-02-25 12:02:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
rmcilroy@chromium.org, oth@chromium.org
Link to the patchset: https://codereview.chromium.org/1717293002/#ps140001
(title: "Reflow REPEAT_249 macro.")

[commit-bot: I haz the power, 2016-02-25 12:02:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1717293002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1717293002/140001

[commit-bot: I haz the power, 2016-02-25 12:07:12]

Description was changed from

==========
[Interpreter] Refactor bytecode generator test suite.

Bytecode expectations have been moved to external (.golden) files,
one per test. Each test in the suite builds a representation of the
the compiled bytecode using BytecodeExpectationsPrinter. The output is
then compared to the golden file. If the comparision fails, a textual
diff can be used to identify the discrepancies.

Only the test snippets are left in the cc file, which also allows to
make it more compact and meaningful. Leaving the snippets in the cc
file was a deliberate choice to allow keeping the "truth" about the
tests in the cc file, which will rarely change, as opposed to golden
files.

Golden files can be generated and kept up to date using
generate-bytecode-expectations, which also means that the test suite
can be batch updated whenever the bytecode or golden format changes.

The golden format has been slightly amended (no more comments about
`void*`, add size of the bytecode array) following the consideration
made while converting the tests.

There is also a fix: BytecodeExpectationsPrinter::top_level_ was left
uninitialized, leading to undefined behaviour.

BUG=v8:4280
LOG=N
==========

to

==========
[Interpreter] Refactor bytecode generator test suite.

Bytecode expectations have been moved to external (.golden) files,
one per test. Each test in the suite builds a representation of the
the compiled bytecode using BytecodeExpectationsPrinter. The output is
then compared to the golden file. If the comparision fails, a textual
diff can be used to identify the discrepancies.

Only the test snippets are left in the cc file, which also allows to
make it more compact and meaningful. Leaving the snippets in the cc
file was a deliberate choice to allow keeping the "truth" about the
tests in the cc file, which will rarely change, as opposed to golden
files.

Golden files can be generated and kept up to date using
generate-bytecode-expectations, which also means that the test suite
can be batch updated whenever the bytecode or golden format changes.

The golden format has been slightly amended (no more comments about
`void*`, add size of the bytecode array) following the consideration
made while converting the tests.

There is also a fix: BytecodeExpectationsPrinter::top_level_ was left
uninitialized, leading to undefined behaviour.

BUG=v8:4280
LOG=N
==========

[commit-bot: I haz the power, 2016-02-25 12:07:13]

Committed patchset #15 (id:140001)

[commit-bot: I haz the power, 2016-02-25 12:07:27]

Description was changed from

==========
[Interpreter] Refactor bytecode generator test suite.

Bytecode expectations have been moved to external (.golden) files,
one per test. Each test in the suite builds a representation of the
the compiled bytecode using BytecodeExpectationsPrinter. The output is
then compared to the golden file. If the comparision fails, a textual
diff can be used to identify the discrepancies.

Only the test snippets are left in the cc file, which also allows to
make it more compact and meaningful. Leaving the snippets in the cc
file was a deliberate choice to allow keeping the "truth" about the
tests in the cc file, which will rarely change, as opposed to golden
files.

Golden files can be generated and kept up to date using
generate-bytecode-expectations, which also means that the test suite
can be batch updated whenever the bytecode or golden format changes.

The golden format has been slightly amended (no more comments about
`void*`, add size of the bytecode array) following the consideration
made while converting the tests.

There is also a fix: BytecodeExpectationsPrinter::top_level_ was left
uninitialized, leading to undefined behaviour.

BUG=v8:4280
LOG=N
==========

to

==========
[Interpreter] Refactor bytecode generator test suite.

Bytecode expectations have been moved to external (.golden) files,
one per test. Each test in the suite builds a representation of the
the compiled bytecode using BytecodeExpectationsPrinter. The output is
then compared to the golden file. If the comparision fails, a textual
diff can be used to identify the discrepancies.

Only the test snippets are left in the cc file, which also allows to
make it more compact and meaningful. Leaving the snippets in the cc
file was a deliberate choice to allow keeping the "truth" about the
tests in the cc file, which will rarely change, as opposed to golden
files.

Golden files can be generated and kept up to date using
generate-bytecode-expectations, which also means that the test suite
can be batch updated whenever the bytecode or golden format changes.

The golden format has been slightly amended (no more comments about
`void*`, add size of the bytecode array) following the consideration
made while converting the tests.

There is also a fix: BytecodeExpectationsPrinter::top_level_ was left
uninitialized, leading to undefined behaviour.

BUG=v8:4280
LOG=N

Committed: https://crrev.com/6ae030590dd7e58a914486e53df35571cd91b638
Cr-Commit-Position: refs/heads/master@{#34285}
==========

[commit-bot: I haz the power, 2016-02-25 12:07:29]

Patchset 15 (id:??) landed as
https://crrev.com/6ae030590dd7e58a914486e53df35571cd91b638
Cr-Commit-Position: refs/heads/master@{#34285}