 Chromium Code Reviews
 Chromium Code Reviews Issue 1717293002:
  [Interpreter] Refactor bytecode generator test suite.  (Closed) 
  Base URL: https://chromium.googlesource.com/v8/v8.git@master
    
  
    Issue 1717293002:
  [Interpreter] Refactor bytecode generator test suite.  (Closed) 
  Base URL: https://chromium.googlesource.com/v8/v8.git@master| OLD | NEW | 
|---|---|
| (Empty) | |
| 1 # | |
| 2 # Autogenerated by generate-bytecode-expectations | |
| 3 # | |
| 4 | |
| 5 --- | |
| 6 pool type: mixed | |
| 7 execute: yes | |
| 8 wrap: yes | |
| 9 | |
| 10 --- | |
| 11 snippet: " | |
| 12 class Person { | |
| 13 constructor(name) { this.name = name; } | |
| 14 speak() { console.log(this.name + ' is speaking.'); } | |
| 15 } | |
| 16 " | |
| 17 frame size: 9 | |
| 18 parameter count: 1 | |
| 19 bytecode array length: 71 | |
| 20 bytecodes: [ | |
| 21 B(LdaTheHole), | |
| 22 B(Star), R(1), | |
| 23 B(StackCheck), | |
| 24 B(LdaTheHole), | |
| 25 B(Star), R(0), | |
| 26 B(LdaTheHole), | |
| 27 B(Star), R(2), | |
| 28 B(CreateClosure), U8(0), U8(0), | |
| 29 B(Star), R(3), | |
| 30 B(LdaSmi8), U8(34), | |
| 31 B(Star), R(4), | |
| 32 B(LdaConstant), U8(1), | |
| 33 B(Star), R(5), | |
| 34 B(CallRuntime), U16(Runtime::kDefineClass), R(2), U8(4), | |
| 35 B(Star), R(2), | |
| 36 B(LoadIC), R(2), U8(2), U8(1), | |
| 37 B(Star), R(3), | |
| 38 B(Mov), R(3), R(4), | |
| 39 B(LdaConstant), U8(3), | |
| 40 B(Star), R(5), | |
| 41 B(CreateClosure), U8(4), U8(0), | |
| 42 B(Star), R(6), | |
| 43 B(LdaSmi8), U8(2), | |
| 44 B(Star), R(7), | |
| 45 B(LdaZero), | |
| 46 B(Star), R(8), | |
| 47 B(CallRuntime), U16(Runtime::kDefineDataPropertyInLiteral), R(4), U8(5), | |
| 48 B(CallRuntime), U16(Runtime::kFinalizeClassDefinition), R(2), U8(2), | |
| 49 B(Star), R(0), | |
| 50 B(Star), R(1), | |
| 51 B(LdaUndefined), | |
| 52 B(Return), | |
| 53 ] | |
| 54 constant pool: [ | |
| 55 InstanceType::SHARED_FUNCTION_INFO_TYPE, | |
| 56 kInstanceTypeDontCare, | |
| 57 InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE, | |
| 58 InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE, | |
| 59 InstanceType::SHARED_FUNCTION_INFO_TYPE, | |
| 60 ] | |
| 61 handlers: [ | |
| 62 ] | |
| 63 | |
| 64 --- | |
| 65 snippet: " | |
| 66 class person { | |
| 67 constructor(name) { this.name = name; } | |
| 68 speak() { console.log(this.name + ' is speaking.'); } | |
| 69 } | |
| 70 " | |
| 71 frame size: 9 | |
| 72 parameter count: 1 | |
| 73 bytecode array length: 71 | |
| 74 bytecodes: [ | |
| 75 B(LdaTheHole), | |
| 76 B(Star), R(1), | |
| 77 B(StackCheck), | |
| 78 B(LdaTheHole), | |
| 79 B(Star), R(0), | |
| 80 B(LdaTheHole), | |
| 81 B(Star), R(2), | |
| 82 B(CreateClosure), U8(0), U8(0), | |
| 83 B(Star), R(3), | |
| 84 B(LdaSmi8), U8(34), | |
| 85 B(Star), R(4), | |
| 86 B(LdaConstant), U8(1), | |
| 87 B(Star), R(5), | |
| 88 B(CallRuntime), U16(Runtime::kDefineClass), R(2), U8(4), | |
| 89 B(Star), R(2), | |
| 90 B(LoadIC), R(2), U8(2), U8(1), | |
| 91 B(Star), R(3), | |
| 92 B(Mov), R(3), R(4), | |
| 93 B(LdaConstant), U8(3), | |
| 94 B(Star), R(5), | |
| 95 B(CreateClosure), U8(4), U8(0), | |
| 96 B(Star), R(6), | |
| 97 B(LdaSmi8), U8(2), | |
| 98 B(Star), R(7), | |
| 99 B(LdaZero), | |
| 100 B(Star), R(8), | |
| 101 B(CallRuntime), U16(Runtime::kDefineDataPropertyInLiteral), R(4), U8(5), | |
| 102 B(CallRuntime), U16(Runtime::kFinalizeClassDefinition), R(2), U8(2), | |
| 103 B(Star), R(0), | |
| 104 B(Star), R(1), | |
| 105 B(LdaUndefined), | |
| 106 B(Return), | |
| 107 ] | |
| 108 constant pool: [ | |
| 109 InstanceType::SHARED_FUNCTION_INFO_TYPE, | |
| 110 kInstanceTypeDontCare, | |
| 111 InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE, | |
| 112 InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE, | |
| 113 InstanceType::SHARED_FUNCTION_INFO_TYPE, | |
| 114 ] | |
| 115 handlers: [ | |
| 116 ] | |
| 117 | |
| 118 --- | |
| 119 snippet: " | |
| 120 var n0 = 'a';var n1 = 'b';class N { | |
| 
rmcilroy
2016/02/24 08:55:35
newlines between semicolons
 
Stefano Sanfilippo
2016/02/24 14:55:02
Done.
 | |
| 121 [n0]() { return n0; } | |
| 122 static [n1]() { return n1; } | |
| 123 } | |
| 124 " | |
| 125 frame size: 10 | |
| 126 parameter count: 1 | |
| 127 bytecode array length: 125 | |
| 128 bytecodes: [ | |
| 129 B(CallRuntime), U16(Runtime::kNewFunctionContext), R(closure), U8(1), | |
| 130 B(PushContext), R(2), | |
| 131 B(LdaTheHole), | |
| 132 B(Star), R(1), | |
| 133 B(StackCheck), | |
| 134 B(LdaConstant), U8(0), | |
| 135 B(StaContextSlot), R(context), U8(4), | |
| 136 B(LdaConstant), U8(1), | |
| 137 B(StaContextSlot), R(context), U8(5), | |
| 138 B(LdaTheHole), | |
| 139 B(Star), R(0), | |
| 140 B(LdaTheHole), | |
| 141 B(Star), R(3), | |
| 142 B(CreateClosure), U8(2), U8(0), | |
| 143 B(Star), R(4), | |
| 144 B(LdaSmi8), U8(60), | |
| 145 B(Star), R(5), | |
| 146 B(LdaSmi8), U8(126), | |
| 147 B(Star), R(6), | |
| 148 B(CallRuntime), U16(Runtime::kDefineClass), R(3), U8(4), | |
| 149 B(Star), R(3), | |
| 150 B(LoadIC), R(3), U8(3), U8(1), | |
| 151 B(Star), R(4), | |
| 152 B(Mov), R(4), R(5), | |
| 153 B(LdaContextSlot), R(context), U8(4), | |
| 154 B(ToName), | |
| 155 B(Star), R(6), | |
| 156 B(CreateClosure), U8(4), U8(0), | |
| 157 B(Star), R(7), | |
| 158 B(LdaSmi8), U8(2), | |
| 159 B(Star), R(8), | |
| 160 B(LdaSmi8), U8(1), | |
| 161 B(Star), R(9), | |
| 162 B(CallRuntime), U16(Runtime::kDefineDataPropertyInLiteral), R(5), U8(5), | |
| 163 B(Mov), R(3), R(5), | |
| 164 B(LdaContextSlot), R(context), U8(5), | |
| 165 B(ToName), | |
| 166 B(Star), R(6), | |
| 167 B(LdaConstant), U8(3), | |
| 168 B(TestEqualStrict), R(6), | |
| 169 B(JumpIfFalse), U8(7), | |
| 170 B(CallRuntime), U16(Runtime::kThrowStaticPrototypeError), R(0), U8(0), | |
| 171 B(CreateClosure), U8(5), U8(0), | |
| 172 B(Star), R(7), | |
| 173 B(LdaSmi8), U8(1), | |
| 174 B(Star), R(9), | |
| 175 B(CallRuntime), U16(Runtime::kDefineDataPropertyInLiteral), R(5), U8(5), | |
| 176 B(CallRuntime), U16(Runtime::kFinalizeClassDefinition), R(3), U8(2), | |
| 177 B(Star), R(0), | |
| 178 B(Star), R(1), | |
| 179 B(LdaUndefined), | |
| 180 B(Return), | |
| 181 ] | |
| 182 constant pool: [ | |
| 183 InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE, | |
| 184 InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE, | |
| 185 InstanceType::SHARED_FUNCTION_INFO_TYPE, | |
| 186 InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE, | |
| 187 InstanceType::SHARED_FUNCTION_INFO_TYPE, | |
| 188 InstanceType::SHARED_FUNCTION_INFO_TYPE, | |
| 189 ] | |
| 190 handlers: [ | |
| 191 ] | |
| 192 | |
| 193 --- | |
| 194 snippet: " | |
| 195 var count = 0; | |
| 196 class C { constructor() { count++; }} | |
| 197 return new C(); | |
| 198 " | |
| 199 frame size: 10 | |
| 200 parameter count: 1 | |
| 201 bytecode array length: 74 | |
| 202 bytecodes: [ | |
| 203 B(CallRuntime), U16(Runtime::kNewFunctionContext), R(closure), U8(1), | |
| 204 B(PushContext), R(2), | |
| 205 B(LdaTheHole), | |
| 206 B(Star), R(1), | |
| 207 B(StackCheck), | |
| 208 B(LdaZero), | |
| 209 B(StaContextSlot), R(context), U8(4), | |
| 210 B(LdaTheHole), | |
| 211 B(Star), R(0), | |
| 212 B(LdaTheHole), | |
| 213 B(Star), R(3), | |
| 214 B(CreateClosure), U8(0), U8(0), | |
| 215 B(Star), R(4), | |
| 216 B(LdaSmi8), U8(49), | |
| 217 B(Star), R(5), | |
| 218 B(LdaSmi8), U8(86), | |
| 219 B(Star), R(6), | |
| 220 B(CallRuntime), U16(Runtime::kDefineClass), R(3), U8(4), | |
| 221 B(Star), R(3), | |
| 222 B(LoadIC), R(3), U8(1), U8(1), | |
| 223 B(Star), R(4), | |
| 224 B(CallRuntime), U16(Runtime::kFinalizeClassDefinition), R(3), U8(2), | |
| 225 B(Star), R(0), | |
| 226 B(Star), R(1), | |
| 227 B(JumpIfNotHole), U8(11), | |
| 228 B(LdaConstant), U8(2), | |
| 229 B(Star), R(4), | |
| 230 B(CallRuntime), U16(Runtime::kThrowReferenceError), R(4), U8(1), | |
| 231 B(Star), R(3), | |
| 232 B(New), R(3), R(0), U8(0), | |
| 233 B(Return), | |
| 234 ] | |
| 235 constant pool: [ | |
| 236 InstanceType::SHARED_FUNCTION_INFO_TYPE, | |
| 237 InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE, | |
| 238 InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE, | |
| 239 ] | |
| 240 handlers: [ | |
| 241 ] | |
| 242 | |
| OLD | NEW |