test/cctest/cctest.isolate - Issue 1717293002: [Interpreter] Refactor bytecode generator test suite.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: test/cctest/cctest.isolate

Issue 1717293002: [Interpreter] Refactor bytecode generator test suite. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: std::vector instead of initializer_list, golden path as constant. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 # Copyright 2015 the V8 project authors. All rights reserved.	1 # Copyright 2015 the V8 project authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4 {	4 {

5 'variables': {	5 'variables': {

6 'files': [	6 'files': [

7 './cctest.status',	7 './cctest.status',

8 './testcfg.py',	8 './testcfg.py',

	9 './interpreter/',
	rmcilroy 2016/02/22 21:49:49 Should you add each golden file, or did machenbach Should you add each golden file, or did machenbach@ suggest this? Stefano Sanfilippo 2016/02/23 15:57:18 machenbach@ suggested to do so. This way we also e Show quoted text On 2016/02/22 21:49:49, rmcilroy wrote: > Should you add each golden file, or did machenbach@ suggest this? machenbach@ suggested to do so. This way we also eliminate one possible source of confusion, when one adds a golden file but forgets to register it here. We might want to move all .golden files to a subdirectory, e.g. ./interpreter/golden. WDYT?
9 ],	10 ],

10 },	11 },

11 'includes': [	12 'includes': [

12 'cctest_exe.isolate',	13 'cctest_exe.isolate',

13 '../../tools/testrunner/testrunner.isolate',	14 '../../tools/testrunner/testrunner.isolate',

14 ],	15 ],

15 }	16 }

OLD	NEW