Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(561)

Issue 1717033002: EME: Fix the CDM File IO test when run using unprefixed EME. (Closed)

Created:
4 years, 10 months ago by ddorwin
Modified:
4 years, 10 months ago
Reviewers:
jrummell, xhwang
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

EME: Fix the CDM File IO test when run using unprefixed EME. This test was not registering the unprefixed event handlers, processing the message as the correct type, or enabling required peristent storage capability. The two FileIOTest tests may still not be testing both paths, but the prefixed path will be removed in my next CL. BUG=249976 TEST=ECKEncryptedMediaTest.FileIOTest passes when prefixed EME is manually disabled in the test. Committed: https://crrev.com/7407850b7f1caa33481ec22124c8b5ef4bceac4a Cr-Commit-Position: refs/heads/master@{#376601}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -8 lines) Patch
M media/test/data/eme_player_js/file_io_test_player.js View 1 chunk +8 lines, -5 lines 0 comments Download
M media/test/data/eme_player_js/player_utils.js View 1 chunk +5 lines, -0 lines 0 comments Download
M media/test/data/eme_player_js/utils.js View 2 chunks +2 lines, -3 lines 1 comment Download

Dependent Patchsets:

Messages

Total messages: 9 (3 generated)
ddorwin
https://codereview.chromium.org/1717033002/diff/1/media/test/data/eme_player_js/utils.js File media/test/data/eme_player_js/utils.js (right): https://codereview.chromium.org/1717033002/diff/1/media/test/data/eme_player_js/utils.js#newcode178 media/test/data/eme_player_js/utils.js:178: var message = String.fromCharCode.apply(null, Utils.convertToUint8Array(msg)); Since there is no ...
4 years, 10 months ago (2016-02-20 00:09:10 UTC) #2
jrummell
lgtm
4 years, 10 months ago (2016-02-20 00:15:07 UTC) #3
xhwang
lgtm
4 years, 10 months ago (2016-02-20 00:16:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1717033002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1717033002/1
4 years, 10 months ago (2016-02-20 00:22:11 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-20 01:44:06 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-20 01:45:28 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7407850b7f1caa33481ec22124c8b5ef4bceac4a
Cr-Commit-Position: refs/heads/master@{#376601}

Powered by Google App Engine
This is Rietveld 408576698