Remove prefixed EME.

Remove prefixed EME.

This removes most of the code, including from Blink and WebMediaPlayer*.
Some code that is not trivial to remove still exists. Specifically, there are
some legacy parameters in media::MediaKeys and implementations of it. Also,
although prefixed tests have been disabled, not all related paths have been
removed. In addition, there are some TODOs that will be addressed separately.

The flag to disable (unprefixed) EME is no longer useful and has been removed.

BUG=249976
TEST=Unprefixed EME tests still pass.

Committed: https://crrev.com/fdb9a2bea13a877eef407fe7359b056b56d8ab2e
Cr-Commit-Position: refs/heads/master@{#376828}

[ddorwin, 2016-02-19 00:09:24]

ddorwin@chromium.org changed reviewers:
+ xhwang@chromium.org

[ddorwin, 2016-02-19 00:09:26]

\o/

Many files, but almost entirely deletes.

[ddorwin, 2016-02-19 00:11:11]

Description was changed from

==========
Remove prefixed EME.

This removes most of the code, including from Blink, WMP*, etc.
Some code that is not trivial to remove still exists. Specifically, there are
some legacy parameters in media::MediaKeys and implementations of it. Also,
although prefixed tests have been disabled, not all related paths have been
removed. In addition, there are some TODOs that will be addressed separately.

The flag to disable (unprefixed) EME is no longer useful and has been removed.

BUG=249976
TEST=Unprefixed EME tests still pass.
==========

to

==========
Remove prefixed EME.

This removes most of the code, including from Blink and WebMediaPlayer*.
Some code that is not trivial to remove still exists. Specifically, there are
some legacy parameters in media::MediaKeys and implementations of it. Also,
although prefixed tests have been disabled, not all related paths have been
removed. In addition, there are some TODOs that will be addressed separately.

The flag to disable (unprefixed) EME is no longer useful and has been removed.

BUG=249976
TEST=Unprefixed EME tests still pass.
==========

[xhwang, 2016-02-19 23:39:14]

LGTM % nits

https://chromiumcodereview.appspot.com/1712903002/diff/40001/chrome/browser/m...
File chrome/browser/media/encrypted_media_browsertest.cc (right):

https://chromiumcodereview.appspot.com/1712903002/diff/40001/chrome/browser/m...
chrome/browser/media/encrypted_media_browsertest.cc:434:
query_params.push_back(std::make_pair("usePrefixedEME", "1"));
Can you fix this as well so that we can drop PREFIXED enum? We can keep the
UNPREFIXED enum for now.

https://chromiumcodereview.appspot.com/1712903002/diff/40001/chrome/browser/m...
chrome/browser/media/encrypted_media_browsertest.cc:459:
DCHECK_NE(CurrentEmeVersion(), PREFIXED);
ditto

https://chromiumcodereview.appspot.com/1712903002/diff/40001/media/base/key_s...
File media/base/key_systems_unittest.cc (right):

https://chromiumcodereview.appspot.com/1712903002/diff/40001/media/base/key_s...
media/base/key_systems_unittest.cc:583: // Unprefixed has no parent key system
support.
Now we only have one EME, we probably should stop using "unprefixed" in our code
base..

https://chromiumcodereview.appspot.com/1712903002/diff/40001/media/blink/webm...
File media/blink/webmediaplayer_util.h (right):

https://chromiumcodereview.appspot.com/1712903002/diff/40001/media/blink/webm...
media/blink/webmediaplayer_util.h:40:
ConvertToEmeInitDataType(blink::WebEncryptedMediaInitDataType init_data_type);
Add an empty line? It's kinda hard to read.

https://chromiumcodereview.appspot.com/1712903002/diff/40001/tools/metrics/hi...
File tools/metrics/histograms/histograms.xml (right):

https://chromiumcodereview.appspot.com/1712903002/diff/40001/tools/metrics/hi...
tools/metrics/histograms/histograms.xml:19348: +  </obsolete>
This UMA is also used by unprefixed EME "encrypted" event. We should rename it
instead of marking it as obsolete. There's a TODO to do the renaming.

[ddorwin, 2016-02-20 01:04:46]

I addressed all but one of your comments.

Since PS3, I fixed the File IO browser test and removed all prefixed-related
code from the browser tests. Most changes in media/test/data/ are new. (Some
changes from https://codereview.chromium.org/1717033002/ will be included in a
diff against PS3.)

https://codereview.chromium.org/1712903002/diff/40001/chrome/browser/media/en...
File chrome/browser/media/encrypted_media_browsertest.cc (right):

https://codereview.chromium.org/1712903002/diff/40001/chrome/browser/media/en...
chrome/browser/media/encrypted_media_browsertest.cc:434:
query_params.push_back(std::make_pair("usePrefixedEME", "1"));
On 2016/02/19 23:39:14, xhwang wrote:
> Can you fix this as well so that we can drop PREFIXED enum? We can keep the
> UNPREFIXED enum for now.

Done. Removed both.

https://codereview.chromium.org/1712903002/diff/40001/chrome/browser/media/en...
chrome/browser/media/encrypted_media_browsertest.cc:459:
DCHECK_NE(CurrentEmeVersion(), PREFIXED);
On 2016/02/19 23:39:14, xhwang wrote:
> ditto

Done.

https://codereview.chromium.org/1712903002/diff/40001/media/base/key_systems_...
File media/base/key_systems_unittest.cc (right):

https://codereview.chromium.org/1712903002/diff/40001/media/base/key_systems_...
media/base/key_systems_unittest.cc:583: // Unprefixed has no parent key system
support.
On 2016/02/19 23:39:14, xhwang wrote:
> Now we only have one EME, we probably should stop using "unprefixed" in our
code
> base..

We can fix that as we find it. For this one, the concept of parent key system
will be removed, meaning we can delete this test. For now, it provides a
meaningful differentiation.

https://codereview.chromium.org/1712903002/diff/40001/media/blink/webmediapla...
File media/blink/webmediaplayer_util.h (right):

https://codereview.chromium.org/1712903002/diff/40001/media/blink/webmediapla...
media/blink/webmediaplayer_util.h:40:
ConvertToEmeInitDataType(blink::WebEncryptedMediaInitDataType init_data_type);
On 2016/02/19 23:39:14, xhwang wrote:
> Add an empty line? It's kinda hard to read.

Done.

https://codereview.chromium.org/1712903002/diff/40001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/1712903002/diff/40001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:19348: +  </obsolete>
On 2016/02/19 23:39:14, xhwang wrote:
> This UMA is also used by unprefixed EME "encrypted" event. We should rename it
> instead of marking it as obsolete. There's a TODO to do the renaming.

Done.

https://codereview.chromium.org/1712903002/diff/100001/chrome/browser/media/e...
File chrome/browser/media/encrypted_media_browsertest.cc (right):

https://codereview.chromium.org/1712903002/diff/100001/chrome/browser/media/e...
chrome/browser/media/encrypted_media_browsertest.cc:76: const char
kEmeRenewalMissingHeader[] = "EME_RENEWAL_MISSING_HEADER";
I restored this check.

https://codereview.chromium.org/1712903002/diff/100001/media/test/data/eme_pl...
File media/test/data/eme_player_js/utils.js (right):

https://codereview.chromium.org/1712903002/diff/100001/media/test/data/eme_pl...
media/test/data/eme_player_js/utils.js:192: if (!Utils.hasPrefix(msg,
EME_RENEWAL_MESSAGE_HEADER)) {
Even though this isn't strictly necessary anymore, it still tests the contents
of the renewal message so I restored the check and just dropped the "PREFIXED"
part. We can remove this later if we want.

[xhwang, 2016-02-20 01:17:16]

LGTM++!

[ddorwin, 2016-02-20 01:22:44]

ddorwin@chromium.org changed reviewers:
+ isherman@chromium.org, pfeldman@chromium.org, philipj@opera.com

[ddorwin, 2016-02-20 01:22:45]

Simple review of code deletion.

pfeldman: Please review the following:
* third_party/WebKit/Source/bindings/core/v8/*
* third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in
* third_party/WebKit/Source/web/WebRuntimeFeatures.cpp

philipj: Please review:
* all third_party/WebKit/Source/ files not listed above
* third_party/WebKit/public

isherman: Please review tools/metrics/histograms/histograms.xml. Just
deprecation notes.

[Ilya Sherman, 2016-02-20 01:40:45]

histograms.xml lgtm

[haraken, 2016-02-20 08:01:21]

WebKit/Source/ LGTM

[philipj_slow, 2016-02-20 12:52:20]

third_party/WebKit/ lgtm % nits

https://codereview.chromium.org/1712903002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/html/HTMLMediaElement.cpp (right):

https://codereview.chromium.org/1712903002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/html/HTMLMediaElement.cpp:237:
WebMimeRegistry::SupportsType supported =
Platform::current()->mimeRegistry()->supportsMediaMIMEType(contentMIMEType,
contentTypeCodecs, String());
Drop they keySystem argument from WebMimeRegistry.h as well instead of passing
String()?

https://codereview.chromium.org/1712903002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/html/HTMLMediaElement.idl (left):

https://codereview.chromium.org/1712903002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/html/HTMLMediaElement.idl:90:
[RuntimeEnabled=PrefixedEncryptedMedia, DeprecateAs=CanPlayTypeKeySystem]
DOMString canPlayType(DOMString type, [TreatUndefinedAs=NullString] DOMString?
keySystem);
Also remove CanPlayTypeKeySystem from UseCounter.h

https://codereview.chromium.org/1712903002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in (right):

https://codereview.chromium.org/1712903002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in:71: // We cannot
remove this until we no longer support Android Jelly Bean.
In other words, the flag is needed so that it can be disabled on JB? Comment
could be taken to mean that EncryptedMedia itself "should" be removed.

[ddorwin, 2016-02-22 18:30:46]

PS7 is just a rebase. PS8 contains changes based on philipj's feedback,
including some new files.

https://codereview.chromium.org/1712903002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/html/HTMLMediaElement.cpp (right):

https://codereview.chromium.org/1712903002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/html/HTMLMediaElement.cpp:237:
WebMimeRegistry::SupportsType supported =
Platform::current()->mimeRegistry()->supportsMediaMIMEType(contentMIMEType,
contentTypeCodecs, String());
On 2016/02/20 12:52:20, philipj_UTC7 wrote:
> Drop they keySystem argument from WebMimeRegistry.h as well instead of passing
> String()?

Done.

https://codereview.chromium.org/1712903002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/html/HTMLMediaElement.idl (left):

https://codereview.chromium.org/1712903002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/html/HTMLMediaElement.idl:90:
[RuntimeEnabled=PrefixedEncryptedMedia, DeprecateAs=CanPlayTypeKeySystem]
DOMString canPlayType(DOMString type, [TreatUndefinedAs=NullString] DOMString?
keySystem);
Done. Thanks.

https://codereview.chromium.org/1712903002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in (right):

https://codereview.chromium.org/1712903002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in:71: // We cannot
remove this until we no longer support Android Jelly Bean.
On 2016/02/20 12:52:20, philipj_UTC7 wrote:
> In other words, the flag is needed so that it can be disabled on JB? Comment
> could be taken to mean that EncryptedMedia itself "should" be removed.

Thanks. I now think we can remove this. I replaced this with a bug reference.

[ddorwin, 2016-02-22 18:36:38]

content/child/*
content/renderer/render*

[ddorwin, 2016-02-22 18:38:35]

pfeldman: Please OWNERS review the simple code deletions in the five files at:
content/child/*
content/renderer/render*

(IOW content/ except content/renderer/media/.)

[pfeldman, 2016-02-22 18:47:55]

content lgtm

[ddorwin, 2016-02-22 20:02:46]

The CQ bit was checked by ddorwin@chromium.org

[ddorwin, 2016-02-22 20:02:46]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, xhwang@chromium.org, philipj@opera.com,
isherman@chromium.org, pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/1712903002/#ps160001
(title: "Fix isRenewalMessage() in browser tests.")

[commit-bot: I haz the power, 2016-02-22 20:07:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1712903002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1712903002/160001

[commit-bot: I haz the power, 2016-02-22 22:25:21]

Description was changed from

==========
Remove prefixed EME.

This removes most of the code, including from Blink and WebMediaPlayer*.
Some code that is not trivial to remove still exists. Specifically, there are
some legacy parameters in media::MediaKeys and implementations of it. Also,
although prefixed tests have been disabled, not all related paths have been
removed. In addition, there are some TODOs that will be addressed separately.

The flag to disable (unprefixed) EME is no longer useful and has been removed.

BUG=249976
TEST=Unprefixed EME tests still pass.
==========

to

==========
Remove prefixed EME.

This removes most of the code, including from Blink and WebMediaPlayer*.
Some code that is not trivial to remove still exists. Specifically, there are
some legacy parameters in media::MediaKeys and implementations of it. Also,
although prefixed tests have been disabled, not all related paths have been
removed. In addition, there are some TODOs that will be addressed separately.

The flag to disable (unprefixed) EME is no longer useful and has been removed.

BUG=249976
TEST=Unprefixed EME tests still pass.
==========

[commit-bot: I haz the power, 2016-02-22 22:25:23]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2016-02-22 22:26:41]

Description was changed from

==========
Remove prefixed EME.

This removes most of the code, including from Blink and WebMediaPlayer*.
Some code that is not trivial to remove still exists. Specifically, there are
some legacy parameters in media::MediaKeys and implementations of it. Also,
although prefixed tests have been disabled, not all related paths have been
removed. In addition, there are some TODOs that will be addressed separately.

The flag to disable (unprefixed) EME is no longer useful and has been removed.

BUG=249976
TEST=Unprefixed EME tests still pass.
==========

to

==========
Remove prefixed EME.

This removes most of the code, including from Blink and WebMediaPlayer*.
Some code that is not trivial to remove still exists. Specifically, there are
some legacy parameters in media::MediaKeys and implementations of it. Also,
although prefixed tests have been disabled, not all related paths have been
removed. In addition, there are some TODOs that will be addressed separately.

The flag to disable (unprefixed) EME is no longer useful and has been removed.

BUG=249976
TEST=Unprefixed EME tests still pass.

Committed: https://crrev.com/fdb9a2bea13a877eef407fe7359b056b56d8ab2e
Cr-Commit-Position: refs/heads/master@{#376828}
==========

[commit-bot: I haz the power, 2016-02-22 22:26:43]

Patchset 9 (id:??) landed as
https://crrev.com/fdb9a2bea13a877eef407fe7359b056b56d8ab2e
Cr-Commit-Position: refs/heads/master@{#376828}