Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 171663005: Consistently use ElementTraversal API when looking for an Element (Closed)

Created:
6 years, 10 months ago by Inactive
Modified:
6 years, 10 months ago
Reviewers:
adamk, eseidel
CC:
blink-reviews, shans, eae+blinkwatch, fs, eric.carlson_apple.com, nessy, apavlov+blink_chromium.org, adamk+blink_chromium.org, Steve Block, dino_apple.com, rune+blink, krit, alancutter (OOO until 2018), bemjb+rendering_chromium.org, dsinclair, Timothy Loh, dstockwell, dglazkov+blink, jchaffraix+rendering, pdr., rwlbuis, Eric Willigers, sof, rjwright, zoltan1, philipj_slow, feature-media-reviews_chromium.org, gyuyoung.kim_webkit.org, darktears, vcarbune.chromium, gasubic, leviw+renderwatch, Mike Lawther (Google), ed+blinkwatch_opera.com, f(malita), Stephen Chennney
Visibility:
Public.

Description

Consistently use ElementTraversal API when looking for an Element Consistently use ElementTraversal API when looking for an Element. This often results in simpler code by getting rid of explicit isElementNode() checks. It makes it clear we are only interested in Elements and in some cases, allows the compiler to use faster Element/ContainerNode methods instead of generic Node ones. R=adamk, eseidel Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167462

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -101 lines) Patch
M Source/core/css/RuleFeature.cpp View 2 chunks +7 lines, -12 lines 0 comments Download
M Source/core/dom/Document.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/dom/Node.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLAppletElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLDetailsElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLMediaElement.cpp View 4 chunks +13 lines, -13 lines 0 comments Download
M Source/core/html/HTMLObjectElement.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLTableElement.cpp View 4 chunks +11 lines, -9 lines 0 comments Download
M Source/core/html/HTMLTableRowElement.cpp View 4 chunks +7 lines, -6 lines 0 comments Download
M Source/core/html/HTMLTableSectionElement.cpp View 2 chunks +6 lines, -8 lines 0 comments Download
M Source/core/html/track/LoadableTextTrack.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M Source/core/rendering/svg/ReferenceFilterBuilder.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceClipper.cpp View 6 chunks +18 lines, -18 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceFilter.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceMasker.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGResourcePattern.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGAnimateMotionElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFEMergeElement.cpp View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
eseidel
Did you mean to send this out for review? Rietveld won't send the mail for ...
6 years, 10 months ago (2014-02-19 03:09:36 UTC) #1
eseidel
lgtm Makes one wonder if we shouldn't have a real iterator object. :)
6 years, 10 months ago (2014-02-19 03:11:32 UTC) #2
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 10 months ago (2014-02-19 03:53:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/171663005/1
6 years, 10 months ago (2014-02-19 03:53:50 UTC) #4
Inactive
On 2014/02/19 03:11:32, eseidel wrote: > lgtm > > Makes one wonder if we shouldn't ...
6 years, 10 months ago (2014-02-19 03:54:10 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-19 07:01:58 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=27780
6 years, 10 months ago (2014-02-19 07:01:58 UTC) #7
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 10 months ago (2014-02-19 13:18:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/171663005/1
6 years, 10 months ago (2014-02-19 13:18:53 UTC) #9
Inactive
The CQ bit was unchecked by ch.dumez@samsung.com
6 years, 10 months ago (2014-02-19 17:52:52 UTC) #10
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 10 months ago (2014-02-19 17:53:10 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/171663005/1
6 years, 10 months ago (2014-02-19 21:57:33 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/171663005/1
6 years, 10 months ago (2014-02-19 23:03:30 UTC) #13
commit-bot: I haz the power
6 years, 10 months ago (2014-02-20 07:11:46 UTC) #14
Message was sent while issue was closed. 
Change committed as 167462

Powered by Google App Engine
This is Rietveld 408576698