Source/core/svg/SVGAnimateMotionElement.cpp - Issue 171663005: Consistently use ElementTraversal API when looking for an Element

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/svg/SVGAnimateMotionElement.cpp

Issue 171663005: Consistently use ElementTraversal API when looking for an Element (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/svg/SVGAnimateMotionElement.cpp

diff --git a/Source/core/svg/SVGAnimateMotionElement.cpp b/Source/core/svg/SVGAnimateMotionElement.cpp

index fd9012309ad207d2cc2c42c7ce071726c9b37e70..3dece5644f0e72e2e3c5e5a37452d6eea1f34966 100644

--- a/Source/core/svg/SVGAnimateMotionElement.cpp

+++ b/Source/core/svg/SVGAnimateMotionElement.cpp

@@ -140,7 +140,7 @@ void SVGAnimateMotionElement::updateAnimationPath()

m_animationPath = Path();

bool foundMPath = false;

- for (Node* child = firstChild(); child; child = child->nextSibling()) {

+ for (Element* child = ElementTraversal::firstWithin(*this); child; child = ElementTraversal::nextSibling(*child)) {

if (child->hasTagName(SVGNames::mpathTag)) {

SVGMPathElement* mPath = toSVGMPathElement(child);

SVGPathElement* pathElement = mPath->pathElement();