Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Side by Side Diff: Source/core/html/HTMLTableSectionElement.cpp

Issue 171663005: Consistently use ElementTraversal API when looking for an Element (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/html/HTMLTableRowElement.cpp ('k') | Source/core/html/track/LoadableTextTrack.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 * Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 * (C) 1997 Torben Weis (weis@kde.org) 3 * (C) 1997 Torben Weis (weis@kde.org)
4 * (C) 1998 Waldo Bastian (bastian@kde.org) 4 * (C) 1998 Waldo Bastian (bastian@kde.org)
5 * (C) 1999 Lars Knoll (knoll@kde.org) 5 * (C) 1999 Lars Knoll (knoll@kde.org)
6 * (C) 1999 Antti Koivisto (koivisto@kde.org) 6 * (C) 1999 Antti Koivisto (koivisto@kde.org)
7 * Copyright (C) 2003, 2004, 2005, 2006, 2010 Apple Inc. All rights reserved. 7 * Copyright (C) 2003, 2004, 2005, 2006, 2010 Apple Inc. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
11 * License as published by the Free Software Foundation; either 11 * License as published by the Free Software Foundation; either
12 * version 2 of the License, or (at your option) any later version. 12 * version 2 of the License, or (at your option) any later version.
13 * 13 *
14 * This library is distributed in the hope that it will be useful, 14 * This library is distributed in the hope that it will be useful,
15 * but WITHOUT ANY WARRANTY; without even the implied warranty of 15 * but WITHOUT ANY WARRANTY; without even the implied warranty of
16 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU 16 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
17 * Library General Public License for more details. 17 * Library General Public License for more details.
18 * 18 *
19 * You should have received a copy of the GNU Library General Public License 19 * You should have received a copy of the GNU Library General Public License
20 * along with this library; see the file COPYING.LIB. If not, write to 20 * along with this library; see the file COPYING.LIB. If not, write to
21 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, 21 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
22 * Boston, MA 02110-1301, USA. 22 * Boston, MA 02110-1301, USA.
23 */ 23 */
24 24
25 #include "config.h" 25 #include "config.h"
26 #include "core/html/HTMLTableSectionElement.h" 26 #include "core/html/HTMLTableSectionElement.h"
27 27
28 #include "HTMLNames.h" 28 #include "HTMLNames.h"
29 #include "bindings/v8/ExceptionState.h" 29 #include "bindings/v8/ExceptionState.h"
30 #include "core/dom/ElementTraversal.h"
30 #include "core/dom/ExceptionCode.h" 31 #include "core/dom/ExceptionCode.h"
31 #include "core/html/HTMLCollection.h" 32 #include "core/html/HTMLCollection.h"
32 #include "core/html/HTMLTableElement.h" 33 #include "core/html/HTMLTableElement.h"
33 #include "core/html/HTMLTableRowElement.h" 34 #include "core/html/HTMLTableRowElement.h"
34 35
35 namespace WebCore { 36 namespace WebCore {
36 37
37 using namespace HTMLNames; 38 using namespace HTMLNames;
38 39
39 inline HTMLTableSectionElement::HTMLTableSectionElement(const QualifiedName& tag Name, Document& document) 40 inline HTMLTableSectionElement::HTMLTableSectionElement(const QualifiedName& tag Name, Document& document)
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
88 if (index >= 0 && index < numRows) { 89 if (index >= 0 && index < numRows) {
89 RefPtr<Element> row = children->item(index); 90 RefPtr<Element> row = children->item(index);
90 HTMLElement::removeChild(row.get(), exceptionState); 91 HTMLElement::removeChild(row.get(), exceptionState);
91 } else { 92 } else {
92 exceptionState.throwDOMException(IndexSizeError, "The provided index (" + String::number(index) + " is outside the range [-1, " + String::number(numRows ) + "]."); 93 exceptionState.throwDOMException(IndexSizeError, "The provided index (" + String::number(index) + " is outside the range [-1, " + String::number(numRows ) + "].");
93 } 94 }
94 } 95 }
95 96
96 int HTMLTableSectionElement::numRows() const 97 int HTMLTableSectionElement::numRows() const
97 { 98 {
98 int rows = 0; 99 int rowCount = 0;
99 const Node *n = firstChild(); 100 for (const Element* child = ElementTraversal::firstWithin(*this); child; chi ld = ElementTraversal::nextSibling(*child)) {
100 while (n) { 101 if (child->hasTagName(trTag))
101 if (n->hasTagName(trTag)) 102 ++rowCount;
102 rows++;
103 n = n->nextSibling();
104 } 103 }
105 104 return rowCount;
106 return rows;
107 } 105 }
108 106
109 PassRefPtr<HTMLCollection> HTMLTableSectionElement::rows() 107 PassRefPtr<HTMLCollection> HTMLTableSectionElement::rows()
110 { 108 {
111 return ensureCachedHTMLCollection(TSectionRows); 109 return ensureCachedHTMLCollection(TSectionRows);
112 } 110 }
113 111
114 } 112 }
OLDNEW
« no previous file with comments | « Source/core/html/HTMLTableRowElement.cpp ('k') | Source/core/html/track/LoadableTextTrack.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698