third_party/WebKit/LayoutTests/media/video-source-none-supported.html - Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/media/video-source-none-supported.html

Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add bug ref Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/video-source-moved.html ('k') | third_party/WebKit/LayoutTests/media/video-source-removed.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/media/video-source-none-supported.html

diff --git a/third_party/WebKit/LayoutTests/media/video-source-none-supported.html b/third_party/WebKit/LayoutTests/media/video-source-none-supported.html

index dec894ce0772f77c59e11f8c317cc8e9da9ded2a..76ac192240fce8363ca24c1b4bbc21b550fa4bee 100644

--- a/third_party/WebKit/LayoutTests/media/video-source-none-supported.html

+++ b/third_party/WebKit/LayoutTests/media/video-source-none-supported.html

@@ -2,6 +2,8 @@

<html>

<head>

<title>no usable <source> test</title>

+ <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956

+ (Please avoid writing new tests using video-test.js) -->

document.addEventListener("error", errorEvent, true);

@@ -11,7 +13,7 @@

findMediaElement();

consoleWrite("++ ERROR, src = " + relativeURL(event.target.src) + ", type = \"" + event.target.type + "\"");

testExpected("event.target.tagName", "SOURCE", "==");

// Any more source elements pending?

var nextSource = event.target.nextSibling;

while (video.hasChildNodes()) {

@@ -25,8 +27,8 @@

consoleWrite("");

endTest();

} else {

- // Because the error event is fired asynchronously the network state can be either

- // NETWORK_LOADING or NETWORK_NO_SOURCE, depending on whether or not

+ // Because the error event is fired asynchronously the network state can be either

+ // NETWORK_LOADING or NETWORK_NO_SOURCE, depending on whether or not

testExpected("event.target.parentNode.networkState", HTMLMediaElement.NETWORK_IDLE, ">");

}

@@ -42,7 +44,7 @@

</video>

- <p>1. Test that no usable <source> element leaves the media element with

+ <p>1. Test that no usable <source> element leaves the media element with

networkState == NETWORK_NO_SOURCE</p>

</body>

</html>