third_party/WebKit/LayoutTests/media/video-source-removed.html - Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/media/video-source-removed.html

Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add bug ref Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/video-source-none-supported.html ('k') | third_party/WebKit/LayoutTests/media/video-source-type.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/media/video-source-removed.html

diff --git a/third_party/WebKit/LayoutTests/media/video-source-removed.html b/third_party/WebKit/LayoutTests/media/video-source-removed.html

index 2133697e26244b65cb6ca011ac1166945b1deace..339d405c12d6850e6ba67e316bf32896527feea3 100644

--- a/third_party/WebKit/LayoutTests/media/video-source-removed.html

+++ b/third_party/WebKit/LayoutTests/media/video-source-removed.html

@@ -2,11 +2,13 @@

<html>

<head>

<title>crash after removing <source> test</title>

+ <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956

+ (Please avoid writing new tests using video-test.js) -->

- var testInfo =

+ var testInfo =

{

current : -1,

tests : [removeChild, innerHTML, replaceChild]

@@ -16,7 +18,7 @@

{

consoleWrite("Removing all <source> elements with <i>removeChild()<" + "/i>");

for (var ndx = 0; ndx < sources.length; ++ndx) {

- consoleWrite(" -> removeChild(" + ndx + ")");

+ consoleWrite(" -> removeChild(" + ndx + ")");

video.removeChild(sources[ndx]);

}

@@ -24,7 +26,7 @@

function innerHTML()

{

consoleWrite("Removing all <source> by setting <i>.innerHTML<" + "/i>");

- consoleWrite(" -> video.innerHTML = ''");

+ consoleWrite(" -> video.innerHTML = ''");

}

function replaceChild(sources)

@@ -33,7 +35,7 @@

var span = document.createElement("span")

span.appendChild(document.createTextNode("Yo"));

for (var ndx = 0; ndx < sources.length; ++ndx) {

- consoleWrite(" -> replaceChild(" + ndx + ")");

+ consoleWrite(" -> replaceChild(" + ndx + ")");

video.replaceChild(span, sources[ndx]);

}

@@ -51,7 +53,7 @@

source.type = mimeTypeForExtension(source.src.split('.').pop());

video.appendChild(source);

}

function runNextTest()

{

consoleWrite("");

@@ -65,8 +67,8 @@

document.body.appendChild(video);

video.addEventListener("loadstart", runOneTest);

- // Add a bunch of source elements with bogus urls because we want to remove elements

- // after the media engine begins processing sources, and we can't predict the delay

+ // Add a bunch of source elements with bogus urls because we want to remove elements

+ // after the media engine begins processing sources, and we can't predict the delay

// between when the media element fires an 'error' event and our handler is called,

// but we need to guarantee that there are <source> elements that haven't been processed

// when we run the test.