third_party/WebKit/LayoutTests/media/video-source-moved.html - Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js

Unified Diff: third_party/WebKit/LayoutTests/media/video-source-moved.html

Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add bug ref Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/video-source-media.html ('k') | third_party/WebKit/LayoutTests/media/video-source-none-supported.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/media/video-source-moved.html

diff --git a/third_party/WebKit/LayoutTests/media/video-source-moved.html b/third_party/WebKit/LayoutTests/media/video-source-moved.html

index 43a4b2d14c34d5f14ec46f2b9e21bf6757ac065d..39c2579f21d7708d0ec74e24e02f5f778ab6c35a 100644

--- a/third_party/WebKit/LayoutTests/media/video-source-moved.html

+++ b/third_party/WebKit/LayoutTests/media/video-source-moved.html

@@ -2,14 +2,16 @@

<html>

<head>

<title>moving <source> element test</title>

+ <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956

+ (Please avoid writing new tests using video-test.js) -->

- var testInfo =

+ var testInfo =

{

current : -1,

- tests :

+ tests :

[

{ fcn : moveToEnd, errorCount : 0, moved : null, done : false, iteration : 1},

{ fcn : moveToEnd, errorCount : 0, moved : null, done : false, iteration : 2},

@@ -90,7 +92,7 @@

test.done = true;

return;

} else if (!event.target.nextSibling) {

- logResult(true, "<source> moved was not processed");

+ logResult(true, "<source> moved was not processed");

setTimeout(configureNextTest, 100);

}

break;

@@ -132,7 +134,7 @@

default:

if (event.target == test.moved) {

- logResult(true, "<source> moved was processed a second time.");

+ logResult(true, "<source> moved was processed a second time.");

setTimeout(configureNextTest, 100);

} else if (!event.target.nextSibling) {

// We should never reach the end of the source list since the tests stops

@@ -156,7 +158,7 @@

source.type = mimeTypeForExtension(source.src.split('.').pop());

video.appendChild(source);

}

function runNextTest()

{

consoleWrite("");

@@ -170,8 +172,8 @@

video = mediaElement = document.createElement('video');

document.body.appendChild(video);

- // Add a bunch of source elements with bogus urls because we want to rearrange elements

- // after the media engine begins processing sources, and we can't predict the delay

+ // Add a bunch of source elements with bogus urls because we want to rearrange elements

+ // after the media engine begins processing sources, and we can't predict the delay

// between when the media element fires an 'error' event and our handler is called,

// but we need to guarantee that there are <source> elements that haven't been processed

// when we run the test.

@@ -198,7 +200,7 @@

</head>

<body>

- <div>Test to make sure a <source> moved after the media element begins processing

+ <div>Test to make sure a <source> moved after the media element begins processing

is handled correctly.</div>

</body>