Stop async spellchecker before running the leak detector.

Stop async spellchecker before running the leak detector.

Should a test finish up before all the spellcheck requests that
it (inadvertently?) generates have been asynchronously processed
and completed, it risks beomg reported as leaking.

These requests have no bearing on the correctness of the test
(if they did, the test would have to arrange to wait on their
outcomes), and can safely be cancelled before leak detection goes
ahead. Along with stopping the async spellchecker, this avoids
unnecessary flakiness from tests that involve spellchecking.

R=
BUG=587424
Committed: https://crrev.com/b25827c77b343f26adde09f027372c50b3e2f6b5
Cr-Commit-Position: refs/heads/master@{#376816}

[sof, 2016-02-21 12:41:27]

Description was changed from

==========
Stop async spellchecker before running the leak detector.

R=
BUG=
==========

to

==========
Stop async spellchecker before running the leak detector.

Should a test finish up before all the spellcheck requests that
it (inadvertently?) generates have been asynchronously processed
and completed, it risks causing a leak to be reported.

These requests have no bearing on the correctness of the test
(if they did, the test would have to arrange to wait on their
outcomes), and can safely be cancelled before leak detection goes
ahead. Along with stopping the async spellchecker, this avoids
unnecessary flakiness from tests that involve spellchecking.

R=
BUG=
==========

[sof, 2016-02-21 13:48:38]

Description was changed from

==========
Stop async spellchecker before running the leak detector.

Should a test finish up before all the spellcheck requests that
it (inadvertently?) generates have been asynchronously processed
and completed, it risks causing a leak to be reported.

These requests have no bearing on the correctness of the test
(if they did, the test would have to arrange to wait on their
outcomes), and can safely be cancelled before leak detection goes
ahead. Along with stopping the async spellchecker, this avoids
unnecessary flakiness from tests that involve spellchecking.

R=
BUG=
==========

to

==========
Stop async spellchecker before running the leak detector.

Should a test finish up before all the spellcheck requests that
it (inadvertently?) generates have been asynchronously processed
and completed, it risks beomg reported as leaking.

These requests have no bearing on the correctness of the test
(if they did, the test would have to arrange to wait on their
outcomes), and can safely be cancelled before leak detection goes
ahead. Along with stopping the async spellchecker, this avoids
unnecessary flakiness from tests that involve spellchecking.

R=
BUG=
==========

[sof, 2016-02-21 13:50:42]

Description was changed from

==========
Stop async spellchecker before running the leak detector.

Should a test finish up before all the spellcheck requests that
it (inadvertently?) generates have been asynchronously processed
and completed, it risks beomg reported as leaking.

These requests have no bearing on the correctness of the test
(if they did, the test would have to arrange to wait on their
outcomes), and can safely be cancelled before leak detection goes
ahead. Along with stopping the async spellchecker, this avoids
unnecessary flakiness from tests that involve spellchecking.

R=
BUG=
==========

to

==========
Stop async spellchecker before running the leak detector.

Should a test finish up before all the spellcheck requests that
it (inadvertently?) generates have been asynchronously processed
and completed, it risks beomg reported as leaking.

These requests have no bearing on the correctness of the test
(if they did, the test would have to arrange to wait on their
outcomes), and can safely be cancelled before leak detection goes
ahead. Along with stopping the async spellchecker, this avoids
unnecessary flakiness from tests that involve spellchecking.

R=
BUG=587424
==========

[sof, 2016-02-21 14:09:06]

sigbjornf@opera.com changed reviewers:
+ tkent@chromium.org, yosin@chromium.org

[sof, 2016-02-21 14:09:07]

please take a look.

Addressing leak flakiness wrt spellchecking at the level of individual tests
doesn't seem workable in practice. I prefer addressing it this way, and I don't
think it will hide any leak.

[tkent, 2016-02-22 01:15:54]

lgtm

[sof, 2016-02-22 06:31:03]

sigbjornf@opera.com changed reviewers:
+ jochen@chromium.org

[sof, 2016-02-22 06:31:03]

jochen@: (brief) content/ owner review when you have a moment? tia.

[jochen (gone - plz use gerrit), 2016-02-22 14:11:55]

lgtm

[sof, 2016-02-22 14:14:39]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2016-02-22 14:15:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1715203002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1715203002/60001

[commit-bot: I haz the power, 2016-02-22 16:18:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-22 16:18:09]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sof, 2016-02-22 16:24:40]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2016-02-22 16:25:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1715203002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1715203002/60001

[commit-bot: I haz the power, 2016-02-22 18:28:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-22 18:28:57]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sof, 2016-02-22 20:47:14]

ps#5 takes r366698 into account and allows the leak detector to work over remote
and local frames; i.e., it switches to using WebFrame* rather than
WebLocalFrame*.

I don't think that's a controversial change here, hence going ahead and landing.

[sof, 2016-02-22 20:47:20]

The CQ bit was checked by sigbjornf@opera.com

[sof, 2016-02-22 20:47:20]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org,
jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/1715203002/#ps80001
(title: "rebase + parameterize WebLeakDetector over WebFrames instead")

[commit-bot: I haz the power, 2016-02-22 20:48:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1715203002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1715203002/80001

[commit-bot: I haz the power, 2016-02-22 21:49:22]

Description was changed from

==========
Stop async spellchecker before running the leak detector.

Should a test finish up before all the spellcheck requests that
it (inadvertently?) generates have been asynchronously processed
and completed, it risks beomg reported as leaking.

These requests have no bearing on the correctness of the test
(if they did, the test would have to arrange to wait on their
outcomes), and can safely be cancelled before leak detection goes
ahead. Along with stopping the async spellchecker, this avoids
unnecessary flakiness from tests that involve spellchecking.

R=
BUG=587424
==========

to

==========
Stop async spellchecker before running the leak detector.

Should a test finish up before all the spellcheck requests that
it (inadvertently?) generates have been asynchronously processed
and completed, it risks beomg reported as leaking.

These requests have no bearing on the correctness of the test
(if they did, the test would have to arrange to wait on their
outcomes), and can safely be cancelled before leak detection goes
ahead. Along with stopping the async spellchecker, this avoids
unnecessary flakiness from tests that involve spellchecking.

R=
BUG=587424
==========

[commit-bot: I haz the power, 2016-02-22 21:49:23]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-02-22 21:50:28]

Description was changed from

==========
Stop async spellchecker before running the leak detector.

Should a test finish up before all the spellcheck requests that
it (inadvertently?) generates have been asynchronously processed
and completed, it risks beomg reported as leaking.

These requests have no bearing on the correctness of the test
(if they did, the test would have to arrange to wait on their
outcomes), and can safely be cancelled before leak detection goes
ahead. Along with stopping the async spellchecker, this avoids
unnecessary flakiness from tests that involve spellchecking.

R=
BUG=587424
==========

to

==========
Stop async spellchecker before running the leak detector.

Should a test finish up before all the spellcheck requests that
it (inadvertently?) generates have been asynchronously processed
and completed, it risks beomg reported as leaking.

These requests have no bearing on the correctness of the test
(if they did, the test would have to arrange to wait on their
outcomes), and can safely be cancelled before leak detection goes
ahead. Along with stopping the async spellchecker, this avoids
unnecessary flakiness from tests that involve spellchecking.

R=
BUG=587424

Committed: https://crrev.com/b25827c77b343f26adde09f027372c50b3e2f6b5
Cr-Commit-Position: refs/heads/master@{#376816}
==========

[commit-bot: I haz the power, 2016-02-22 21:50:29]

Patchset 5 (id:??) landed as
https://crrev.com/b25827c77b343f26adde09f027372c50b3e2f6b5
Cr-Commit-Position: refs/heads/master@{#376816}