content/shell/renderer/layout_test/leak_detector.cc - Issue 1715203002: Stop async spellchecker before running the leak detector.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/renderer/layout_test/leak_detector.cc

Issue 1715203002: Stop async spellchecker before running the leak detector. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase + parameterize WebLeakDetector over WebFrames instead Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/shell/renderer/layout_test/leak_detector.h ('k') | third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/renderer/layout_test/leak_detector.cc

diff --git a/content/shell/renderer/layout_test/leak_detector.cc b/content/shell/renderer/layout_test/leak_detector.cc

index 6f857232374df958d11c97c846918591b59bca4c..f5cb3f75aa9c784e4e17b826bd39d3cc79cdfa14 100644

--- a/content/shell/renderer/layout_test/leak_detector.cc

+++ b/content/shell/renderer/layout_test/leak_detector.cc

@@ -59,8 +59,8 @@ LeakDetector::LeakDetector(BlinkTestRunner* test_runner)

LeakDetector::~LeakDetector() {

}

-void LeakDetector::TryLeakDetection(blink::WebLocalFrame* frame) {

- web_leak_detector_->prepareForLeakDetection();

+void LeakDetector::TryLeakDetection(blink::WebFrame* frame) {

+ web_leak_detector_->prepareForLeakDetection(frame);

web_leak_detector_->collectGarbageAndReport();

}