Stop async spellchecker before running the leak detector.

third_party/WebKit/Source/web/WebLeakDetector.cpp

 /*
  * Copyright (C) 2014 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 17 matching lines @@
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "public/web/WebLeakDetector.h"
 
 #include "bindings/core/v8/ScriptPromise.h"
 #include "bindings/core/v8/V8Binding.h"
 #include "bindings/core/v8/V8GCController.h"
 #include "core/dom/ActiveDOMObject.h"
 #include "core/dom/Document.h"
+#include "core/editing/spellcheck/SpellChecker.h"
 #include "core/fetch/MemoryCache.h"
 #include "core/inspector/InstanceCounters.h"
 #include "core/layout/LayoutObject.h"
 #include "core/workers/WorkerThread.h"
 #include "modules/webaudio/AudioNode.h"
 #include "platform/Timer.h"
 #include "public/web/WebDocument.h"
-#include "public/web/WebLocalFrame.h"
+#include "public/web/WebFrame.h"
+#include "web/WebLocalFrameImpl.h"
 
 namespace blink {
 
 namespace {
 
 class WebLeakDetectorImpl final : public WebLeakDetector {
 WTF_MAKE_NONCOPYABLE(WebLeakDetectorImpl);
 public:
     explicit WebLeakDetectorImpl(WebLeakDetectorClient* client)
         : m_client(client)
         , m_delayedGCAndReportTimer(this, &WebLeakDetectorImpl::delayedGCAndReport)
         , m_delayedReportTimer(this, &WebLeakDetectorImpl::delayedReport)
         , m_numberOfGCNeeded(0)
     {
         ASSERT(m_client);
     }
 
     ~WebLeakDetectorImpl() override {}
 
-    void prepareForLeakDetection() override;
+    void prepareForLeakDetection(WebFrame*) override;
     void collectGarbageAndReport() override;
 
 private:
     void delayedGCAndReport(Timer<WebLeakDetectorImpl>*);
     void delayedReport(Timer<WebLeakDetectorImpl>*);
 
     WebLeakDetectorClient* m_client;
     Timer<WebLeakDetectorImpl> m_delayedGCAndReportTimer;
     Timer<WebLeakDetectorImpl> m_delayedReportTimer;
     int m_numberOfGCNeeded;
 };
 
-void WebLeakDetectorImpl::prepareForLeakDetection()
+void WebLeakDetectorImpl::prepareForLeakDetection(WebFrame* frame)
 {
     v8::Isolate* isolate = v8::Isolate::GetCurrent();
     v8::HandleScope handleScope(isolate);
 
     // For example, calling isValidEmailAddress in EmailInputType.cpp with a
     // non-empty string creates a static ScriptRegexp value which holds a
     // V8PerContextData indirectly. This affects the number of V8PerContextData.
     // To ensure that context data is created, call ensureScriptRegexpContext
     // here.
     V8PerIsolateData::from(isolate)->ensureScriptRegexpContext();
 
     WorkerThread::terminateAndWaitForAllWorkers();
     memoryCache()->evictResources();
 
+    // If the spellchecker is allowed to continue issuing requests while the
+    // leak detector runs, leaks may flakily be reported as the requests keep
+    // their associated element (and document) alive.
+    //
+    // Stop the spellchecker to prevent this.
+    if (frame->isWebLocalFrame()) {
+        WebLocalFrameImpl* localFrame = toWebLocalFrameImpl(frame);
+        SpellChecker& spellChecker = localFrame->frame()->spellChecker();
+        spellChecker.prepareForLeakDetection();
+    }
+
     // FIXME: HTML5 Notification should be closed because notification affects the result of number of DOM objects.
 
     V8PerIsolateData::from(isolate)->clearScriptRegexpContext();
 }
 
 void WebLeakDetectorImpl::collectGarbageAndReport()
 {
     V8GCController::collectAllGarbageForTesting(V8PerIsolateData::mainThreadIsolate());
     // Note: Oilpan precise GC is scheduled at the end of the event loop.
 
@@ skipping 44 matching lines @@
 }
 
 } // namespace
 
 WebLeakDetector* WebLeakDetector::create(WebLeakDetectorClient* client)
 {
     return new WebLeakDetectorImpl(client);
 }
 
 } // namespace blink