Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(600)

Issue 1714773002: Revert of Add a useful error message for run-webkit-tests broken --target handling. (Closed)

Created:
4 years, 10 months ago by dstockwell
Modified:
4 years, 10 months ago
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add a useful error message for run-webkit-tests broken --target handling. (patchset #1 id:1 of https://codereview.chromium.org/1708973002/ ) Reason for revert: Broke workflows not using the "blessed" output directories. See: https://codereview.chromium.org/1705233003#msg6 Original issue's description: > Add a useful error message for run-webkit-tests broken --target handling. > > This will hopefully prevent some wasted time until the underlying > problem is fixed. > > R=kbr@chromium.org, skobes@chromium.org > BUG=539509 > > Committed: https://crrev.com/afd25fb38db90dea1058240aceb6bbc02578f947 > Cr-Commit-Position: refs/heads/master@{#376092} TBR=kbr@chromium.org,skobes@chromium.org,dpranke@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=539509 Committed: https://crrev.com/006a19483ec7c5bfdd32b4be322745290dd4bd8f Cr-Commit-Position: refs/heads/master@{#376365}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
dstockwell
Created Revert of Add a useful error message for run-webkit-tests broken --target handling.
4 years, 10 months ago (2016-02-19 03:02:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1714773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1714773002/1
4 years, 10 months ago (2016-02-19 03:05:38 UTC) #3
Dirk Pranke
(un-cq'ing temporarily) I didn't mean you could revert this change without at least discussing it ...
4 years, 10 months ago (2016-02-19 03:06:10 UTC) #4
Ken Russell (switch to Gerrit)
On 2016/02/19 03:06:10, Dirk Pranke wrote: > (un-cq'ing temporarily) > > I didn't mean you ...
4 years, 10 months ago (2016-02-19 03:12:27 UTC) #6
Dirk Pranke
re-CQ'ing. We will revert the error check for now and try to get a real ...
4 years, 10 months ago (2016-02-19 03:25:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1714773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1714773002/1
4 years, 10 months ago (2016-02-19 03:29:11 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-19 03:40:14 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-19 03:41:17 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/006a19483ec7c5bfdd32b4be322745290dd4bd8f
Cr-Commit-Position: refs/heads/master@{#376365}

Powered by Google App Engine
This is Rietveld 408576698