third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py - Issue 1714773002: Revert of Add a useful error message for run-webkit-tests broken --target handling.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py

Issue 1714773002: Revert of Add a useful error message for run-webkit-tests broken --target handling. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py

index ab51899fdfed89307ee3e1589cb3622d0a7f5464..e27855b767a9a0e2dd6d320b2387dd82b54a1fc3 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py

@@ -60,12 +60,6 @@

host = Host()

try:

- # TODO: crbug.com/539509 - Drop this check and make --target work properly.

- if options.configuration not in (None, 'Debug', 'Release', 'Debug_x64', 'Release_x64'):

- raise NotImplementedError('--target must be either "Debug" or "Release"; other values do not work\n.'

- 'Use multiple //out directories for multiple builds if necessary.\n'

- 'See crbug.com/539509.')

port = host.port_factory.get(options.platform, options)

except NotImplementedError, e:

# FIXME: is this the best way to handle unsupported port names?

« no previous file with comments | « no previous file | no next file » | no next file with comments »