Add --accept-crbug-539509 flag to run-webkit-tests

Add --accept-crbug-539509 flag to run-webkit-tests

This change adds an --accept-crbug-539509 flag to run-webkit-tests
to allow non-standard values for --target with the caveat that
TestExpectations will not be followed correctly.

BUG=539509

[alancutter (OOO until 2018), 2016-02-18 06:36:24]

alancutter@chromium.org changed reviewers:
+ dpranke@chromium.org

[Ken Russell (switch to Gerrit), 2016-02-18 16:41:14]

kbr@chromium.org changed reviewers:
+ kbr@chromium.org

[Ken Russell (switch to Gerrit), 2016-02-18 16:41:15]

https://codereview.chromium.org/1705233003/diff/1/third_party/WebKit/Tools/Sc...
File third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory.py
(right):

https://codereview.chromium.org/1705233003/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory.py:63:
help='Run tests with a non-standard --target despite https://crbug.com/539509'),
Rather than add this command line flag, could you help by parsing
out/${target}/args.gn and determine whether the build is Debug or Release from
the flags there? It shouldn't be more than about 10 lines of Python code and
will be the correct fix, rather than adding a broken workaround.

[Ken Russell (switch to Gerrit), 2016-02-18 16:42:10]

On 2016/02/18 16:41:15, Ken Russell wrote:
>
https://codereview.chromium.org/1705233003/diff/1/third_party/WebKit/Tools/Sc...
> File third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory.py
> (right):
> 
>
https://codereview.chromium.org/1705233003/diff/1/third_party/WebKit/Tools/Sc...
> third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory.py:63:
> help='Run tests with a non-standard --target despite
https://crbug.com/539509),
> Rather than add this command line flag, could you help by parsing
> out/${target}/args.gn and determine whether the build is Debug or Release from
> the flags there? It shouldn't be more than about 10 lines of Python code and
> will be the correct fix, rather than adding a broken workaround.

...and yes, it was necessary to disable other values of --target. I wasted a
couple of hours debugging why TestExpectations weren't being applied to my MSAN
build of content_shell in out/msan/ , and other have, too.

[Dirk Pranke, 2016-02-18 18:55:04]

We can revert the original change (to enforce values of --target), or fix the
underlying problem,
but I don't think we should add this override. Supporting a broken code path
would be kinda strange.

[alancutter (OOO until 2018), 2016-02-19 03:41:16]

On 2016/02/18 at 18:55:04, dpranke wrote:
> We can revert the original change (to enforce values of --target), or fix the
underlying problem,
> but I don't think we should add this override. Supporting a broken code path
would be kinda strange.

Closing this since the original change got reverted:
https://codereview.chromium.org/1708973002