Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(781)

Issue 1714643002: printing: Sandboxed processes must ask the browser to allocate shared memory. (Closed)

Created:
4 years, 10 months ago by erikchen
Modified:
4 years, 10 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

printing: Sandboxed processes must ask the browser to allocate shared memory. SharedMemory is being changed on Windows so that the underlying File Mapping Object is always named. This means that sandboxed processes must request the object from the browser process, just like on POSIX. BUG=493414 Committed: https://crrev.com/72780b29dcf5642ad50df5c3421e6e2e625c704e Cr-Commit-Position: refs/heads/master@{#376335}

Patch Set 1 #

Patch Set 2 : Fix compile error. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -16 lines) Patch
M components/printing/renderer/print_web_view_helper.cc View 1 2 chunks +3 lines, -16 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1714643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1714643002/1
4 years, 10 months ago (2016-02-18 21:57:17 UTC) #2
erikchen
thestig: Please review. Note that this CL is doing the same thing as https://codereview.chromium.org/1705863003/, just ...
4 years, 10 months ago (2016-02-18 21:58:20 UTC) #4
Lei Zhang
lgtm, horray for consistency.
4 years, 10 months ago (2016-02-18 22:04:52 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/23827) android_compile_dbg on ...
4 years, 10 months ago (2016-02-18 22:19:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1714643002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1714643002/20001
4 years, 10 months ago (2016-02-18 22:24:22 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/145453)
4 years, 10 months ago (2016-02-18 22:50:40 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1714643002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1714643002/20001
4 years, 10 months ago (2016-02-19 00:27:07 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-19 01:30:24 UTC) #15
commit-bot: I haz the power
4 years, 10 months ago (2016-02-19 01:31:26 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/72780b29dcf5642ad50df5c3421e6e2e625c704e
Cr-Commit-Position: refs/heads/master@{#376335}

Powered by Google App Engine
This is Rietveld 408576698