Sandboxed processes must ask the browser to allocate shared memory.

Sandboxed processes must ask the browser to allocate shared memory.

SharedMemory is being changed on Windows so that the underlying File Mapping
Object is always named. This means that sandboxed processes must request the
object from the browser process, just like on POSIX.

BUG=493414
Committed: https://crrev.com/7c654311054fad66c925efb9dc8b3731c9c018b0
Cr-Commit-Position: refs/heads/master@{#376228}

[erikchen, 2016-02-18 00:51:26]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-18 00:54:26]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1705863003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1705863003/1

[commit-bot: I haz the power, 2016-02-18 02:09:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-18 02:09:37]

Dry run: This issue passed the CQ dry run.

[erikchen, 2016-02-18 02:40:42]

erikchen@chromium.org changed reviewers:
+ jschuh@chromium.org

[erikchen, 2016-02-18 02:40:42]

jschuh: Please review.

[jschuh, 2016-02-18 05:14:04]

lgtm with the comment nit, but you'll still need a content owner.

[jschuh, 2016-02-18 05:14:22]

comment nit

https://codereview.chromium.org/1705863003/diff/1/content/child/child_thread_...
File content/child/child_thread_impl.cc (right):

https://codereview.chromium.org/1705863003/diff/1/content/child/child_thread_...
content/child/child_thread_impl.cc:573: // by the sandbox.
Just for accuracy, I'd go with "blocked by the sandbox on most platforms."

[erikchen, 2016-02-18 05:39:23]

erikchen@chromium.org changed reviewers:
+ avi@chromium.org

[erikchen, 2016-02-18 05:39:23]

avi: Please review.

https://codereview.chromium.org/1705863003/diff/1/content/child/child_thread_...
File content/child/child_thread_impl.cc (right):

https://codereview.chromium.org/1705863003/diff/1/content/child/child_thread_...
content/child/child_thread_impl.cc:573: // by the sandbox.
On 2016/02/18 05:14:22, jschuh (very slow) wrote:
> Just for accuracy, I'd go with "blocked by the sandbox on most platforms."

Done.

[Avi (use Gerrit), 2016-02-18 15:59:17]

lgtm

[erikchen, 2016-02-18 18:07:37]

The CQ bit was checked by erikchen@chromium.org

[erikchen, 2016-02-18 18:07:37]

The patchset sent to the CQ was uploaded after l-g-t-m from jschuh@chromium.org
Link to the patchset: https://codereview.chromium.org/1705863003/#ps20001
(title: "Comments from jschuh.")

[commit-bot: I haz the power, 2016-02-18 18:10:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1705863003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1705863003/20001

[commit-bot: I haz the power, 2016-02-18 19:22:28]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-18 19:23:37]

Description was changed from

==========
Sandboxed processes must ask the browser to allocate shared memory.

SharedMemory is being changed on Windows so that the underlying File Mapping
Object is always named. This means that sandboxed processes must request the
object from the browser process, just like on POSIX.

BUG=493414
==========

to

==========
Sandboxed processes must ask the browser to allocate shared memory.

SharedMemory is being changed on Windows so that the underlying File Mapping
Object is always named. This means that sandboxed processes must request the
object from the browser process, just like on POSIX.

BUG=493414

Committed: https://crrev.com/7c654311054fad66c925efb9dc8b3731c9c018b0
Cr-Commit-Position: refs/heads/master@{#376228}
==========

[commit-bot: I haz the power, 2016-02-18 19:23:38]

Patchset 2 (id:??) landed as
https://crrev.com/7c654311054fad66c925efb9dc8b3731c9c018b0
Cr-Commit-Position: refs/heads/master@{#376228}