X87: Change the test case for X87 RunRoundUint32ToFloat32.

X87: Change the test case for X87 RunRoundUint32ToFloat32.

  The CL #33796 (https://codereview.chromium.org/1628133002) added the RunRoundUint32ToFloat32 test case and X87 failed at it.

  The reason is same as the CL #33630 (Issue 1649323002: X87: Change the test case for X87 RunRoundInt32ToFloat32), please refer: https://codereview.chromium.org/1649323002.

  Here is the key comments from CL #33630:
  Some new test cases use CheckFloatEq(...) and CheckDoubleEq(...) function for result check. When GCC compiling the CheckFloatEq() and CheckDoubleEq() function,
  those inlined functions has different behavior comparing with GCC ia32 build and x87 build.
  The major difference is sse float register still has single precision rounding semantic. While X87 register has no such rounding precsion semantic when directly use register value.
  The V8 turbofan JITTed has exactly same result in both X87 and IA32 port.

  For CHECK_EQ(a, b) function, if a and b are doubles, it will has similar behaviors like CheckFloatEq(...) and CheckDoubleEq(...) function when compiled by GCC and causes the test case
  fail.

  So we add the following sentence to do type case to keep the same precision for RunRoundUint32ToFloat32. Such as: volatile double expect = static_cast<float>(*i).

BUG=

Committed: https://crrev.com/2cd9485644bc12b67ace4ae62ae6e4b4ebe18977
Cr-Commit-Position: refs/heads/master@{#34202}

[zhengxing.li, 2016-02-22 07:20:41]

Description was changed from

==========
X87: Change the test case for X87 RunRoundUint32ToFloat32.

  The CL #33796 (https://codereview.chromium.org/1628133002) added the
RunRoundUint32ToFloat32 test case and X87 failed at it.

  The reason is same as the CL #33630 (Issue 1649323002: X87: Change the test
case for X87 RunRoundInt32ToFloat32), please refer:
ttps://codereview.chromium.org/1649323002.

  Here is the key comments from CL #33630:
  Some new test cases use CheckFloatEq(...) and CheckDoubleEq(...) function for
result check. When GCC compiling the CheckFloatEq() and CheckDoubleEq()
function, those inlined functions has different behavior comparing with GCC ia32
build and x87 build. The major difference is sse float register still has single
precision rounding semantic. While X87 register has no such rounding precsion
semantic when directly use register value. The V8 turbofan JITTed has exactly
same result in both X87 and IA32 port. For CHECK_EQ(a, b) function, if a and b
are doubles, it will has similar behaviors like CheckFloatEq(...) and
CheckDoubleEq(...) function when compiled by GCC and causes the test case fail.

  So we add the following sentence to do type case to keep the same precision
for RunRoundUint32ToFloat32. Such as: volatile double expect =
static_cast<float>(*i).

BUG=
==========

to

==========
X87: Change the test case for X87 RunRoundUint32ToFloat32.

  The CL #33796 (https://codereview.chromium.org/1628133002) added the
RunRoundUint32ToFloat32 test case and X87 failed at it.

  The reason is same as the CL #33630 (Issue 1649323002: X87: Change the test
case for X87 RunRoundInt32ToFloat32), please refer:
ttps://codereview.chromium.org/1649323002.

  Here is the key comments from CL #33630:
 Some new test cases use CheckFloatEq(...) and CheckDoubleEq(...) function for
result check. When GCC compiling the CheckFloatEq() and CheckDoubleEq()
function,
 those inlined functions has different behavior comparing with GCC ia32 build
and x87 build.
 The major difference is sse float register still has single precision rounding
semantic. While X87 register has no such rounding precsion semantic when
directly use register value.
 The V8 turbofan JITTed has exactly same result in both X87 and IA32 port.

 For CHECK_EQ(a, b) function, if a and b are doubles, it will has similar
behaviors like CheckFloatEq(...) and CheckDoubleEq(...) function when compiled
by GCC and causes the test case
 fail.

  So we add the following sentence to do type case to keep the same precision
for RunRoundUint32ToFloat32. Such as: volatile double expect =
static_cast<float>(*i).

BUG=
==========

[zhengxing.li, 2016-02-22 07:21:38]

Description was changed from

==========
X87: Change the test case for X87 RunRoundUint32ToFloat32.

  The CL #33796 (https://codereview.chromium.org/1628133002) added the
RunRoundUint32ToFloat32 test case and X87 failed at it.

  The reason is same as the CL #33630 (Issue 1649323002: X87: Change the test
case for X87 RunRoundInt32ToFloat32), please refer:
ttps://codereview.chromium.org/1649323002.

  Here is the key comments from CL #33630:
 Some new test cases use CheckFloatEq(...) and CheckDoubleEq(...) function for
result check. When GCC compiling the CheckFloatEq() and CheckDoubleEq()
function,
 those inlined functions has different behavior comparing with GCC ia32 build
and x87 build.
 The major difference is sse float register still has single precision rounding
semantic. While X87 register has no such rounding precsion semantic when
directly use register value.
 The V8 turbofan JITTed has exactly same result in both X87 and IA32 port.

 For CHECK_EQ(a, b) function, if a and b are doubles, it will has similar
behaviors like CheckFloatEq(...) and CheckDoubleEq(...) function when compiled
by GCC and causes the test case
 fail.

  So we add the following sentence to do type case to keep the same precision
for RunRoundUint32ToFloat32. Such as: volatile double expect =
static_cast<float>(*i).

BUG=
==========

to

==========
X87: Change the test case for X87 RunRoundUint32ToFloat32.

  The CL #33796 (https://codereview.chromium.org/1628133002) added the
RunRoundUint32ToFloat32 test case and X87 failed at it.

  The reason is same as the CL #33630 (Issue 1649323002: X87: Change the test
case for X87 RunRoundInt32ToFloat32), please refer:
ttps://codereview.chromium.org/1649323002.

  Here is the key comments from CL #33630:
  Some new test cases use CheckFloatEq(...) and CheckDoubleEq(...) function for
result check. When GCC compiling the CheckFloatEq() and CheckDoubleEq()
function,
  those inlined functions has different behavior comparing with GCC ia32 build
and x87 build.
  The major difference is sse float register still has single precision rounding
semantic. While X87 register has no such rounding precsion semantic when
directly use register value.
  The V8 turbofan JITTed has exactly same result in both X87 and IA32 port.

  For CHECK_EQ(a, b) function, if a and b are doubles, it will has similar
behaviors like CheckFloatEq(...) and CheckDoubleEq(...) function when compiled
by GCC and causes the test case
 fail.

  So we add the following sentence to do type case to keep the same precision
for RunRoundUint32ToFloat32. Such as: volatile double expect =
static_cast<float>(*i).

BUG=
==========

[zhengxing.li, 2016-02-22 07:22:04]

Description was changed from

==========
X87: Change the test case for X87 RunRoundUint32ToFloat32.

  The CL #33796 (https://codereview.chromium.org/1628133002) added the
RunRoundUint32ToFloat32 test case and X87 failed at it.

  The reason is same as the CL #33630 (Issue 1649323002: X87: Change the test
case for X87 RunRoundInt32ToFloat32), please refer:
ttps://codereview.chromium.org/1649323002.

  Here is the key comments from CL #33630:
  Some new test cases use CheckFloatEq(...) and CheckDoubleEq(...) function for
result check. When GCC compiling the CheckFloatEq() and CheckDoubleEq()
function,
  those inlined functions has different behavior comparing with GCC ia32 build
and x87 build.
  The major difference is sse float register still has single precision rounding
semantic. While X87 register has no such rounding precsion semantic when
directly use register value.
  The V8 turbofan JITTed has exactly same result in both X87 and IA32 port.

  For CHECK_EQ(a, b) function, if a and b are doubles, it will has similar
behaviors like CheckFloatEq(...) and CheckDoubleEq(...) function when compiled
by GCC and causes the test case
 fail.

  So we add the following sentence to do type case to keep the same precision
for RunRoundUint32ToFloat32. Such as: volatile double expect =
static_cast<float>(*i).

BUG=
==========

to

==========
X87: Change the test case for X87 RunRoundUint32ToFloat32.

  The CL #33796 (https://codereview.chromium.org/1628133002) added the
RunRoundUint32ToFloat32 test case and X87 failed at it.

  The reason is same as the CL #33630 (Issue 1649323002: X87: Change the test
case for X87 RunRoundInt32ToFloat32), please refer:
ttps://codereview.chromium.org/1649323002.

  Here is the key comments from CL #33630:
  Some new test cases use CheckFloatEq(...) and CheckDoubleEq(...) function for
result check. When GCC compiling the CheckFloatEq() and CheckDoubleEq()
function,
  those inlined functions has different behavior comparing with GCC ia32 build
and x87 build.
  The major difference is sse float register still has single precision rounding
semantic. While X87 register has no such rounding precsion semantic when
directly use register value.
  The V8 turbofan JITTed has exactly same result in both X87 and IA32 port.

  For CHECK_EQ(a, b) function, if a and b are doubles, it will has similar
behaviors like CheckFloatEq(...) and CheckDoubleEq(...) function when compiled
by GCC and causes the test case
  fail.

  So we add the following sentence to do type case to keep the same precision
for RunRoundUint32ToFloat32. Such as: volatile double expect =
static_cast<float>(*i).

BUG=
==========

[zhengxing.li, 2016-02-22 07:22:36]

Description was changed from

==========
X87: Change the test case for X87 RunRoundUint32ToFloat32.

  The CL #33796 (https://codereview.chromium.org/1628133002) added the
RunRoundUint32ToFloat32 test case and X87 failed at it.

  The reason is same as the CL #33630 (Issue 1649323002: X87: Change the test
case for X87 RunRoundInt32ToFloat32), please refer:
ttps://codereview.chromium.org/1649323002.

  Here is the key comments from CL #33630:
  Some new test cases use CheckFloatEq(...) and CheckDoubleEq(...) function for
result check. When GCC compiling the CheckFloatEq() and CheckDoubleEq()
function,
  those inlined functions has different behavior comparing with GCC ia32 build
and x87 build.
  The major difference is sse float register still has single precision rounding
semantic. While X87 register has no such rounding precsion semantic when
directly use register value.
  The V8 turbofan JITTed has exactly same result in both X87 and IA32 port.

  For CHECK_EQ(a, b) function, if a and b are doubles, it will has similar
behaviors like CheckFloatEq(...) and CheckDoubleEq(...) function when compiled
by GCC and causes the test case
  fail.

  So we add the following sentence to do type case to keep the same precision
for RunRoundUint32ToFloat32. Such as: volatile double expect =
static_cast<float>(*i).

BUG=
==========

to

==========
X87: Change the test case for X87 RunRoundUint32ToFloat32.

  The CL #33796 (https://codereview.chromium.org/1628133002) added the
RunRoundUint32ToFloat32 test case and X87 failed at it.

  The reason is same as the CL #33630 (Issue 1649323002: X87: Change the test
case for X87 RunRoundInt32ToFloat32), please refer:
https://codereview.chromium.org/1649323002.

  Here is the key comments from CL #33630:
  Some new test cases use CheckFloatEq(...) and CheckDoubleEq(...) function for
result check. When GCC compiling the CheckFloatEq() and CheckDoubleEq()
function,
  those inlined functions has different behavior comparing with GCC ia32 build
and x87 build.
  The major difference is sse float register still has single precision rounding
semantic. While X87 register has no such rounding precsion semantic when
directly use register value.
  The V8 turbofan JITTed has exactly same result in both X87 and IA32 port.

  For CHECK_EQ(a, b) function, if a and b are doubles, it will has similar
behaviors like CheckFloatEq(...) and CheckDoubleEq(...) function when compiled
by GCC and causes the test case
  fail.

  So we add the following sentence to do type case to keep the same precision
for RunRoundUint32ToFloat32. Such as: volatile double expect =
static_cast<float>(*i).

BUG=
==========

[zhengxing.li, 2016-02-22 07:25:33]

zhengxing.li@intel.com changed reviewers:
+ chunyang.dai@intel.com, titzer@chromium.org, weiliang.lin@intel.com

[zhengxing.li, 2016-02-22 07:25:34]

PTAL, thanks!

[zhengxing.li, 2016-02-22 07:27:20]

zhengxing.li@intel.com changed reviewers:
+ jing.bao@intel.com

[zhengxing.li, 2016-02-22 07:27:20]

PTAL, thanks!

[titzer, 2016-02-23 01:00:10]

lgtm

[zhengxing.li, 2016-02-23 01:28:16]

The CQ bit was checked by zhengxing.li@intel.com

[commit-bot: I haz the power, 2016-02-23 01:28:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1714413002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1714413002/1

[commit-bot: I haz the power, 2016-02-23 01:49:50]

Description was changed from

==========
X87: Change the test case for X87 RunRoundUint32ToFloat32.

  The CL #33796 (https://codereview.chromium.org/1628133002) added the
RunRoundUint32ToFloat32 test case and X87 failed at it.

  The reason is same as the CL #33630 (Issue 1649323002: X87: Change the test
case for X87 RunRoundInt32ToFloat32), please refer:
https://codereview.chromium.org/1649323002.

  Here is the key comments from CL #33630:
  Some new test cases use CheckFloatEq(...) and CheckDoubleEq(...) function for
result check. When GCC compiling the CheckFloatEq() and CheckDoubleEq()
function,
  those inlined functions has different behavior comparing with GCC ia32 build
and x87 build.
  The major difference is sse float register still has single precision rounding
semantic. While X87 register has no such rounding precsion semantic when
directly use register value.
  The V8 turbofan JITTed has exactly same result in both X87 and IA32 port.

  For CHECK_EQ(a, b) function, if a and b are doubles, it will has similar
behaviors like CheckFloatEq(...) and CheckDoubleEq(...) function when compiled
by GCC and causes the test case
  fail.

  So we add the following sentence to do type case to keep the same precision
for RunRoundUint32ToFloat32. Such as: volatile double expect =
static_cast<float>(*i).

BUG=
==========

to

==========
X87: Change the test case for X87 RunRoundUint32ToFloat32.

  The CL #33796 (https://codereview.chromium.org/1628133002) added the
RunRoundUint32ToFloat32 test case and X87 failed at it.

  The reason is same as the CL #33630 (Issue 1649323002: X87: Change the test
case for X87 RunRoundInt32ToFloat32), please refer:
https://codereview.chromium.org/1649323002.

  Here is the key comments from CL #33630:
  Some new test cases use CheckFloatEq(...) and CheckDoubleEq(...) function for
result check. When GCC compiling the CheckFloatEq() and CheckDoubleEq()
function,
  those inlined functions has different behavior comparing with GCC ia32 build
and x87 build.
  The major difference is sse float register still has single precision rounding
semantic. While X87 register has no such rounding precsion semantic when
directly use register value.
  The V8 turbofan JITTed has exactly same result in both X87 and IA32 port.

  For CHECK_EQ(a, b) function, if a and b are doubles, it will has similar
behaviors like CheckFloatEq(...) and CheckDoubleEq(...) function when compiled
by GCC and causes the test case
  fail.

  So we add the following sentence to do type case to keep the same precision
for RunRoundUint32ToFloat32. Such as: volatile double expect =
static_cast<float>(*i).

BUG=
==========

[commit-bot: I haz the power, 2016-02-23 01:49:51]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-02-23 01:50:46]

Description was changed from

==========
X87: Change the test case for X87 RunRoundUint32ToFloat32.

  The CL #33796 (https://codereview.chromium.org/1628133002) added the
RunRoundUint32ToFloat32 test case and X87 failed at it.

  The reason is same as the CL #33630 (Issue 1649323002: X87: Change the test
case for X87 RunRoundInt32ToFloat32), please refer:
https://codereview.chromium.org/1649323002.

  Here is the key comments from CL #33630:
  Some new test cases use CheckFloatEq(...) and CheckDoubleEq(...) function for
result check. When GCC compiling the CheckFloatEq() and CheckDoubleEq()
function,
  those inlined functions has different behavior comparing with GCC ia32 build
and x87 build.
  The major difference is sse float register still has single precision rounding
semantic. While X87 register has no such rounding precsion semantic when
directly use register value.
  The V8 turbofan JITTed has exactly same result in both X87 and IA32 port.

  For CHECK_EQ(a, b) function, if a and b are doubles, it will has similar
behaviors like CheckFloatEq(...) and CheckDoubleEq(...) function when compiled
by GCC and causes the test case
  fail.

  So we add the following sentence to do type case to keep the same precision
for RunRoundUint32ToFloat32. Such as: volatile double expect =
static_cast<float>(*i).

BUG=
==========

to

==========
X87: Change the test case for X87 RunRoundUint32ToFloat32.

  The CL #33796 (https://codereview.chromium.org/1628133002) added the
RunRoundUint32ToFloat32 test case and X87 failed at it.

  The reason is same as the CL #33630 (Issue 1649323002: X87: Change the test
case for X87 RunRoundInt32ToFloat32), please refer:
https://codereview.chromium.org/1649323002.

  Here is the key comments from CL #33630:
  Some new test cases use CheckFloatEq(...) and CheckDoubleEq(...) function for
result check. When GCC compiling the CheckFloatEq() and CheckDoubleEq()
function,
  those inlined functions has different behavior comparing with GCC ia32 build
and x87 build.
  The major difference is sse float register still has single precision rounding
semantic. While X87 register has no such rounding precsion semantic when
directly use register value.
  The V8 turbofan JITTed has exactly same result in both X87 and IA32 port.

  For CHECK_EQ(a, b) function, if a and b are doubles, it will has similar
behaviors like CheckFloatEq(...) and CheckDoubleEq(...) function when compiled
by GCC and causes the test case
  fail.

  So we add the following sentence to do type case to keep the same precision
for RunRoundUint32ToFloat32. Such as: volatile double expect =
static_cast<float>(*i).

BUG=

Committed: https://crrev.com/2cd9485644bc12b67ace4ae62ae6e4b4ebe18977
Cr-Commit-Position: refs/heads/master@{#34202}
==========

[commit-bot: I haz the power, 2016-02-23 01:50:46]

Patchset 1 (id:??) landed as
https://crrev.com/2cd9485644bc12b67ace4ae62ae6e4b4ebe18977
Cr-Commit-Position: refs/heads/master@{#34202}