Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 1649323002: X87: Change the test case for X87 RunRoundInt32ToFloat32. (Closed)

Created:
4 years, 10 months ago by zhengxing.li
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Change the test case for X87 RunRoundInt32ToFloat32. The CL #33347 (https://codereview.chromium.org/1589363002) added the RunRoundInt32ToFloat32 test case and X87 failed at it. The reason is same as the CL #31808 (issue 1430943002, X87: Change the test case for X87 float operations), please refer: https://codereview.chromium.org/1430943002/. Here is the key comments from CL #31808 Some new test cases use CheckFloatEq(...) and CheckDoubleEq(...) function for result check. When GCC compiling the CheckFloatEq() and CheckDoubleEq() function, those inlined functions has different behavior comparing with GCC ia32 build and x87 build. The major difference is sse float register still has single precision rounding semantic. While X87 register has no such rounding precsion semantic when directly use register value. The V8 turbofan JITTed has exactly same result in both X87 and IA32 port. For CHECK_EQ(a, b) function, if a and b are doubles, it will has similar behaviors like CheckFloatEq(...) and CheckDoubleEq(...) function when compiled by GCC and causes the test case fail. So we add the following sentence to do type case to keep the same precision for RunRoundInt32ToFloat32. Such as: volatile double expect = static_cast<float>(*i). BUG= Committed: https://crrev.com/587ad6fcc0c6850d7edf5c79f621aed0efb4d9be Cr-Commit-Position: refs/heads/master@{#33630}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M test/cctest/compiler/test-run-machops.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 10 months ago (2016-02-01 02:13:25 UTC) #2
ahaas
lgtm
4 years, 10 months ago (2016-02-01 07:57:55 UTC) #3
titzer
lgtm
4 years, 10 months ago (2016-02-01 08:01:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1649323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1649323002/1
4 years, 10 months ago (2016-02-01 08:03:20 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-01 08:27:50 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-01 08:28:01 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/587ad6fcc0c6850d7edf5c79f621aed0efb4d9be
Cr-Commit-Position: refs/heads/master@{#33630}

Powered by Google App Engine
This is Rietveld 408576698