Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 171413004: Analytic rrect clip for cicular corners, radius >= .5 (Closed)

Created:
6 years, 10 months ago by bsalomon
Modified:
6 years, 10 months ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Analytic rrect clip for cicular corners, radius >= 0.5 BUG=skia:2181 Committed: http://code.google.com/p/skia/source/detail?r=13498

Patch Set 1 #

Patch Set 2 : assert #

Patch Set 3 : reduce number of max operations #

Patch Set 4 : Make threshold radius less conservative, add small radii to rrect* GMs #

Patch Set 5 : minor comment improvement #

Total comments: 4

Patch Set 6 : Address Rob's comments: #

Patch Set 7 : fix windows warning in rrects.cpp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+229 lines, -4 lines) Patch
M expectations/gm/ignored-tests.txt View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download
M gm/rrects.cpp View 1 2 3 4 5 6 2 chunks +6 lines, -1 line 0 comments Download
M gyp/gpu.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M include/core/SkRRect.h View 1 chunk +3 lines, -0 lines 0 comments Download
M include/gpu/GrTBackendEffectFactory.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrClipMaskManager.cpp View 2 chunks +4 lines, -0 lines 0 comments Download
M src/gpu/effects/GrConvexPolyEffect.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/effects/GrConvexPolyEffect.cpp View 1 chunk +0 lines, -1 line 0 comments Download
A src/gpu/effects/GrRRectEffect.h View 1 chunk +49 lines, -0 lines 0 comments Download
A src/gpu/effects/GrRRectEffect.cpp View 1 2 3 4 5 1 chunk +155 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
bsalomon
6 years, 10 months ago (2014-02-18 23:29:38 UTC) #1
robertphillips
lgtm + nits. Any performance numbers? https://codereview.chromium.org/171413004/diff/190001/src/gpu/effects/GrRRectEffect.cpp File src/gpu/effects/GrRRectEffect.cpp (right): https://codereview.chromium.org/171413004/diff/190001/src/gpu/effects/GrRRectEffect.cpp#newcode15 src/gpu/effects/GrRRectEffect.cpp:15: // This effect ...
6 years, 10 months ago (2014-02-19 13:39:56 UTC) #2
bsalomon
desk_googleplus.skp goes from ~100 to ~55 on the N10. https://codereview.chromium.org/171413004/diff/190001/src/gpu/effects/GrRRectEffect.cpp File src/gpu/effects/GrRRectEffect.cpp (right): https://codereview.chromium.org/171413004/diff/190001/src/gpu/effects/GrRRectEffect.cpp#newcode15 src/gpu/effects/GrRRectEffect.cpp:15: ...
6 years, 10 months ago (2014-02-19 14:39:41 UTC) #3
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 10 months ago (2014-02-19 14:40:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/171413004/400001
6 years, 10 months ago (2014-02-19 14:40:49 UTC) #5
bsalomon
The CQ bit was unchecked by bsalomon@google.com
6 years, 10 months ago (2014-02-19 14:45:41 UTC) #6
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 10 months ago (2014-02-19 14:47:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/171413004/460001
6 years, 10 months ago (2014-02-19 14:47:08 UTC) #8
commit-bot: I haz the power
Change committed as 13498
6 years, 10 months ago (2014-02-19 15:18:11 UTC) #9
epoger
6 years, 10 months ago (2014-02-19 15:47:36 UTC) #10
Message was sent while issue was closed. 
Filed https://code.google.com/p/skia/issues/detail?id=2195 ('Mac10.6 builders
broken by "Analytic rrect clip for cicular corners, radius >= 0.5"')

Powered by Google App Engine
This is Rietveld 408576698