Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1711503002: Mac Overlays: Add unittests for CALayerTree (Closed)

Created:
4 years, 10 months ago by ccameron
Modified:
4 years, 10 months ago
Reviewers:
erikchen
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mac Overlays: Add unittests for CALayerTree BUG= Committed: https://crrev.com/0ae2b64845116b42d470e477914a3a61d64b3c91 Cr-Commit-Position: refs/heads/master@{#376042}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+744 lines, -2 lines) Patch
M content/common/gpu/ca_layer_tree_mac.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/common/gpu/ca_layer_tree_mac.mm View 1 chunk +1 line, -1 line 1 comment Download
A content/common/gpu/ca_layer_tree_unittest_mac.mm View 1 chunk +740 lines, -0 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
ccameron
Tests!! https://codereview.chromium.org/1711503002/diff/1/content/common/gpu/ca_layer_tree_mac.mm File content/common/gpu/ca_layer_tree_mac.mm (right): https://codereview.chromium.org/1711503002/diff/1/content/common/gpu/ca_layer_tree_mac.mm#newcode306 content/common/gpu/ca_layer_tree_mac.mm:306: update_clip_rect = update_is_clipped || old_layer->clip_rect != clip_rect; Oops, ...
4 years, 10 months ago (2016-02-17 22:53:33 UTC) #2
erikchen
this is a delightful amount of test coverage. thanks! lgtm
4 years, 10 months ago (2016-02-17 23:00:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1711503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1711503002/1
4 years, 10 months ago (2016-02-17 23:04:47 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-18 00:08:22 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-18 00:09:31 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/0ae2b64845116b42d470e477914a3a61d64b3c91
Cr-Commit-Position: refs/heads/master@{#376042}

Powered by Google App Engine
This is Rietveld 408576698