content/common/gpu/ca_layer_tree_mac.mm - Issue 1711503002: Mac Overlays: Add unittests for CALayerTree

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/ca_layer_tree_mac.mm

Issue 1711503002: Mac Overlays: Add unittests for CALayerTree (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/common/gpu/ca_layer_tree_mac.mm

diff --git a/content/common/gpu/ca_layer_tree_mac.mm b/content/common/gpu/ca_layer_tree_mac.mm

index 8c7d93886a5876d72e9d7749e090e0908845d0a5..49d0218f9b9fa9ba6621ff772aa527c987176d31 100644

--- a/content/common/gpu/ca_layer_tree_mac.mm

+++ b/content/common/gpu/ca_layer_tree_mac.mm

@@ -303,7 +303,7 @@ void CALayerTree::ClipAndSortingLayer::CommitToCA(

DCHECK(old_layer->ca_layer);

std::swap(ca_layer, old_layer->ca_layer);

update_is_clipped = old_layer->is_clipped != is_clipped;

- update_clip_rect = old_layer->clip_rect != clip_rect;

+ update_clip_rect = update_is_clipped || old_layer->clip_rect != clip_rect;

ccameron 2016/02/17 22:53:33 Oops, tests discovered a bug.

} else {

ca_layer.reset([[CALayer alloc] init]);

[ca_layer setAnchorPoint:CGPointZero];