Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 1710573002: Revert of Add Scoped Context Info (Isolate) to V8 Traces (Closed)

Created:
4 years, 10 months ago by Michael Achenbach
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Add Scoped Context Info (Isolate) to V8 Traces (patchset #5 id:80001 of https://codereview.chromium.org/1686233002/ ) Reason for revert: [Sheriff] Breaks arm cross-compile: https://build.chromium.org/p/client.v8/builders/V8%20Arm%20-%20debug%20builder/builds/7825/ Original issue's description: > Add Scoped Context Info (Isolate) to V8 Traces > > This patch adds the newly added support for contexts in V8 Tracing, as well > as use it to mark all the entry points for a V8 Isolate. > > BUG=v8:4565 > LOG=N > > Committed: https://crrev.com/44823c3c6965966c63b7e2e2361d0f2a58d196ea > Cr-Commit-Position: refs/heads/master@{#34092} TBR=jochen@chromium.org,fmeawad@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4565 Committed: https://crrev.com/8934994e369c710862737b39caa878c5f897351f Cr-Commit-Position: refs/heads/master@{#34095}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -199 lines) Patch
M include/v8-platform.h View 1 chunk +0 lines, -14 lines 0 comments Download
M src/api.cc View 9 chunks +0 lines, -9 lines 0 comments Download
M src/d8.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/libplatform/default-platform.h View 1 chunk +3 lines, -4 lines 0 comments Download
M src/libplatform/default-platform.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/log-inl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/tracing/trace-event.h View 11 chunks +74 lines, -140 lines 0 comments Download
M test/cctest/test-trace-event.cc View 1 chunk +0 lines, -24 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Achenbach
Created Revert of Add Scoped Context Info (Isolate) to V8 Traces
4 years, 10 months ago (2016-02-17 20:29:40 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1710573002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1710573002/1
4 years, 10 months ago (2016-02-17 20:29:43 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-17 20:29:56 UTC) #4
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 20:30:52 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8934994e369c710862737b39caa878c5f897351f
Cr-Commit-Position: refs/heads/master@{#34095}

Powered by Google App Engine
This is Rietveld 408576698