Add Scoped Context Info (Isolate) to V8 Traces

Add Scoped Context Info (Isolate) to V8 Traces

This patch adds the newly added support for contexts in V8 Tracing, as well
as use it to mark all the entry points for a V8 Isolate.

BUG=v8:4565
LOG=N

Committed: https://crrev.com/44823c3c6965966c63b7e2e2361d0f2a58d196ea
Cr-Commit-Position: refs/heads/master@{#34092}

[fmeawad, 2016-02-16 23:16:40]

Description was changed from

==========
Add Scoped Context Info (Isolate) to V8 Traces

This patch adds the newly added support for contexts in V8 Tracing, as well
as use it to mark all the entry points for a V8 Isolate.

BUG=v8:4565
LOG=N
==========

to

==========
Add Scoped Context Info (Isolate) to V8 Traces

This patch adds the newly added support for contexts in V8 Tracing, as well
as use it to mark all the entry points for a V8 Isolate.

BUG=v8:4565
LOG=N
==========

[fmeawad, 2016-02-16 23:16:40]

fmeawad@chromium.org changed reviewers:
+ jochen@chromium.org

[fmeawad, 2016-02-16 23:16:49]

The CQ bit was checked by fmeawad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-16 23:16:52]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1686233002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1686233002/60001

[fmeawad, 2016-02-16 23:16:55]

PTAL

[commit-bot: I haz the power, 2016-02-16 23:43:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-16 23:43:50]

Dry run: This issue passed the CQ dry run.

[jochen (gone - plz use gerrit), 2016-02-17 10:50:03]

lgtm if it compiles

https://codereview.chromium.org/1686233002/diff/60001/test/cctest/test-trace-...
File test/cctest/test-trace-event.cc (right):

https://codereview.chromium.org/1686233002/diff/60001/test/cctest/test-trace-...
test/cctest/test-trace-event.cc:275: CHECK_EQ(isolate_id,
*(uint64_t*)(GET_TRACE_OBJECT(0)->id));
does that compile on 32bit?

[fmeawad, 2016-02-17 19:19:13]

https://codereview.chromium.org/1686233002/diff/60001/test/cctest/test-trace-...
File test/cctest/test-trace-event.cc (right):

https://codereview.chromium.org/1686233002/diff/60001/test/cctest/test-trace-...
test/cctest/test-trace-event.cc:275: CHECK_EQ(isolate_id,
*(uint64_t*)(GET_TRACE_OBJECT(0)->id));
On 2016/02/17 10:50:03, jochen wrote:
> does that compile on 32bit?

It did compile, but I also simplified the test (was over-complicated, reverted
to the chromium version of the test)

[fmeawad, 2016-02-17 19:19:17]

The CQ bit was checked by fmeawad@chromium.org

[fmeawad, 2016-02-17 19:19:17]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/1686233002/#ps80001
(title: "Simplify the test")

[commit-bot: I haz the power, 2016-02-17 19:19:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1686233002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1686233002/80001

[commit-bot: I haz the power, 2016-02-17 19:56:15]

Description was changed from

==========
Add Scoped Context Info (Isolate) to V8 Traces

This patch adds the newly added support for contexts in V8 Tracing, as well
as use it to mark all the entry points for a V8 Isolate.

BUG=v8:4565
LOG=N
==========

to

==========
Add Scoped Context Info (Isolate) to V8 Traces

This patch adds the newly added support for contexts in V8 Tracing, as well
as use it to mark all the entry points for a V8 Isolate.

BUG=v8:4565
LOG=N
==========

[commit-bot: I haz the power, 2016-02-17 19:56:16]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-02-17 19:56:43]

Description was changed from

==========
Add Scoped Context Info (Isolate) to V8 Traces

This patch adds the newly added support for contexts in V8 Tracing, as well
as use it to mark all the entry points for a V8 Isolate.

BUG=v8:4565
LOG=N
==========

to

==========
Add Scoped Context Info (Isolate) to V8 Traces

This patch adds the newly added support for contexts in V8 Tracing, as well
as use it to mark all the entry points for a V8 Isolate.

BUG=v8:4565
LOG=N

Committed: https://crrev.com/44823c3c6965966c63b7e2e2361d0f2a58d196ea
Cr-Commit-Position: refs/heads/master@{#34092}
==========

[commit-bot: I haz the power, 2016-02-17 19:56:44]

Patchset 5 (id:??) landed as
https://crrev.com/44823c3c6965966c63b7e2e2361d0f2a58d196ea
Cr-Commit-Position: refs/heads/master@{#34092}

[Michael Achenbach, 2016-02-17 20:29:40]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/1710573002/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] Breaks arm cross-compile:
https://build.chromium.org/p/client.v8/builders/V8%20Arm%20-%20debug%20builde....