Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Unified Diff: test/cctest/test-trace-event.cc

Issue 1710573002: Revert of Add Scoped Context Info (Isolate) to V8 Traces (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/tracing/trace-event.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-trace-event.cc
diff --git a/test/cctest/test-trace-event.cc b/test/cctest/test-trace-event.cc
index 3106bbd07f4bac53d5dee2e30385a192504d0c70..a889e088f667dcdcd5907b8e2c48a5459920c920 100644
--- a/test/cctest/test-trace-event.cc
+++ b/test/cctest/test-trace-event.cc
@@ -256,27 +256,3 @@
i::V8::SetPlatformForTesting(old_platform);
}
-
-TEST(TestEventInContext) {
- v8::Platform* old_platform = i::V8::GetCurrentPlatform();
- MockTracingPlatform platform(old_platform);
- i::V8::SetPlatformForTesting(&platform);
-
- static uint64_t isolate_id = 0x20151021;
- {
- TRACE_EVENT_SCOPED_CONTEXT("v8-cat", "Isolate", isolate_id);
- TRACE_EVENT0("v8-cat", "e");
- }
-
- CHECK_EQ(3, GET_TRACE_OBJECTS_LIST->length());
- CHECK_EQ(TRACE_EVENT_PHASE_ENTER_CONTEXT, GET_TRACE_OBJECT(0)->phase);
- CHECK_EQ("Isolate", GET_TRACE_OBJECT(0)->name);
- CHECK_EQ(isolate_id, GET_TRACE_OBJECT(0)->id);
- CHECK_EQ(TRACE_EVENT_PHASE_COMPLETE, GET_TRACE_OBJECT(1)->phase);
- CHECK_EQ("e", GET_TRACE_OBJECT(1)->name);
- CHECK_EQ(TRACE_EVENT_PHASE_LEAVE_CONTEXT, GET_TRACE_OBJECT(2)->phase);
- CHECK_EQ("Isolate", GET_TRACE_OBJECT(2)->name);
- CHECK_EQ(isolate_id, GET_TRACE_OBJECT(2)->id);
-
- i::V8::SetPlatformForTesting(old_platform);
-}
« no previous file with comments | « src/tracing/trace-event.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698