Fix for crash bug in PluginProcessHost::OnGetCookies - it likes like this can...

Fix for crash bug in PluginProcessHost::OnGetCookies - it likes like this can be called when we don't have a URLContext from which to return cookies. 

Previously we crashed, this patch just logs an error and returns an empty string instead. 

BUG=http://crbug.com/10706



Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23568

[jam, 2009-08-17 18:05:40]

http://codereview.chromium.org/171050/diff/1/2
File chrome/browser/plugin_process_host.cc (right):

http://codereview.chromium.org/171050/diff/1/2#newcode532
Line 532: *cookies = context->cookie_store()->GetCookies(url);
the first check is not needed since it's already checked a few lines above

[robertshield, 2009-08-17 18:10:34]

http://codereview.chromium.org/171050/diff/1/2
File chrome/browser/plugin_process_host.cc (right):

http://codereview.chromium.org/171050/diff/1/2#newcode532
Line 532: *cookies = context->cookie_store()->GetCookies(url);
On 2009/08/17 18:05:41, John Abd-El-Malek wrote:
> the first check is not needed since it's already checked a few lines above

It appears that Profile::GetDefaultRequestContext() can also return NULL so I'm
checking again.

[jam, 2009-08-17 18:19:08]

http://codereview.chromium.org/171050/diff/1/2
File chrome/browser/plugin_process_host.cc (right):

http://codereview.chromium.org/171050/diff/1/2#newcode532
Line 532: *cookies = context->cookie_store()->GetCookies(url);
On 2009/08/17 18:10:35, robertshield wrote:
> On 2009/08/17 18:05:41, John Abd-El-Malek wrote:
> > the first check is not needed since it's already checked a few lines above
> 
> It appears that Profile::GetDefaultRequestContext() can also return NULL so
I'm
> checking again.

ah, I didn't know that, sorry for the noise.

lgtm

[ananta, 2009-08-17 18:50:31]

LGTM