Fix for crash bug in PluginProcessHost::OnGetCookies - it likes like this can...

chrome/browser/plugin_process_host.cc

Index: chrome/browser/plugin_process_host.cc
===================================================================
--- chrome/browser/plugin_process_host.cc	(revision 23543)
+++ chrome/browser/plugin_process_host.cc	(working copy)
@@ -25,6 +25,7 @@
 #include "base/path_service.h"
 #include "base/process_util.h"
 #include "base/scoped_ptr.h"
+#include "base/string_util.h"
 #include "base/thread.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/child_process_security_policy.h"
@@ -527,7 +528,12 @@
 
   // Note: We don't have a first_party_for_cookies check because plugins bypass
   // third-party cookie blocking.
-  *cookies = context->cookie_store()->GetCookies(url);
+  if (context && context->cookie_store()) {
+    *cookies = context->cookie_store()->GetCookies(url);

[jam, 2009/08/17 18:05:41]

the first check is not needed since it's already checked a few lines above

[robertshield, 2009/08/17 18:10:35]

It appears that Profile::GetDefaultRequestContext() can also return NULL so I'm
checking again.

[jam, 2009/08/17 18:19:08]

ah, I didn't know that, sorry for the noise.

lgtm

+  } else {
+    DLOG(ERROR) << "Could not serve plugin cookies request.";
+    *cookies = EmptyString();
+  }
 }
 
 void PluginProcessHost::OnAccessFiles(int process_id,