Fix for crash bug in PluginProcessHost::OnGetCookies - it likes like this can...

chrome/browser/plugin_process_host.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "build/build_config.h"
 
 #include "chrome/browser/plugin_process_host.h"
 
 #if defined(OS_WIN)
 #include <windows.h>
 #endif
 
 #include <vector>
 
 #include "app/app_switches.h"
 #include "base/command_line.h"
 #if defined(OS_POSIX)
 #include "base/global_descriptors_posix.h"
 #endif
 #include "base/file_path.h"
 #include "base/file_util.h"
 #include "base/file_version_info.h"
 #include "base/gfx/native_widget_types.h"
 #include "base/logging.h"
 #include "base/path_service.h"
 #include "base/process_util.h"
 #include "base/scoped_ptr.h"
+#include "base/string_util.h"
 #include "base/thread.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/child_process_security_policy.h"
 #include "chrome/browser/chrome_plugin_browsing_context.h"
 #include "chrome/browser/chrome_thread.h"
 #include "chrome/browser/plugin_service.h"
 #include "chrome/browser/profile.h"
 #include "chrome/browser/renderer_host/browser_render_process_host.h"
 #include "chrome/browser/renderer_host/render_process_host.h"
 #include "chrome/browser/renderer_host/resource_dispatcher_host.h"
@@ skipping 482 matching lines @@
                                      const GURL& url,
                                      std::string* cookies) {
   URLRequestContext* context = CPBrowsingContextManager::Instance()->
         ToURLRequestContext(request_context);
   // TODO(mpcomplete): remove fallback case when Gears support is prevalent.
   if (!context)
     context = Profile::GetDefaultRequestContext();
 
   // Note: We don't have a first_party_for_cookies check because plugins bypass
   // third-party cookie blocking.
-  *cookies = context->cookie_store()->GetCookies(url);
+  if (context && context->cookie_store()) {
+    *cookies = context->cookie_store()->GetCookies(url);

[jam, 2009/08/17 18:05:41]

the first check is not needed since it's already checked a few lines above

[robertshield, 2009/08/17 18:10:35]

It appears that Profile::GetDefaultRequestContext() can also return NULL so I'm
checking again.

[jam, 2009/08/17 18:19:08]

ah, I didn't know that, sorry for the noise.

lgtm

+  } else {
+    DLOG(ERROR) << "Could not serve plugin cookies request.";
+    *cookies = EmptyString();
+  }
 }
 
 void PluginProcessHost::OnAccessFiles(int process_id,
                                       const std::vector<std::string>& files,
                                       bool* allowed) {
   ChildProcessSecurityPolicy* policy =
       ChildProcessSecurityPolicy::GetInstance();
 
   for (size_t i = 0; i < files.size(); ++i) {
     const FilePath path = FilePath::FromWStringHack(UTF8ToWide(files[i]));
@@ skipping 84 matching lines @@
   DCHECK(MessageLoop::current() ==
          ChromeThread::GetMessageLoop(ChromeThread::IO));
 
   ChromePluginLib *chrome_plugin = ChromePluginLib::Find(info_.path);
   if (chrome_plugin) {
     void *data_ptr = const_cast<void*>(reinterpret_cast<const void*>(&data[0]));
     uint32 data_len = static_cast<uint32>(data.size());
     chrome_plugin->functions().on_message(data_ptr, data_len);
   }
 }