Fix background compilation: allocate stubs at safepoint

Fix background compilation: allocate stubs at safepoint

BUG=
R=asiva@google.com

Committed: https://github.com/dart-lang/sdk/commit/f5392ea09ad62de2826e4b696303235783d1d7d4

[srdjan, 2016-02-17 20:57:42]

srdjan@google.com changed reviewers:
+ asiva@google.com

[siva, 2016-02-17 21:07:49]

https://codereview.chromium.org/1710443003/diff/40001/runtime/vm/stub_code.cc
File runtime/vm/stub_code.cc (right):

https://codereview.chromium.org/1710443003/diff/40001/runtime/vm/stub_code.cc...
runtime/vm/stub_code.cc:10: #include "vm/compiler.h"  //
SafepointOperationScope.
#include "vm/safepoint.h"

(SafepointOperationScope is defined here).

https://codereview.chromium.org/1710443003/diff/40001/runtime/vm/stub_code.cc...
runtime/vm/stub_code.cc:130: // This part of compilation must be at a safepoint.
This part of stub code generation must be at a safepoint.

https://codereview.chromium.org/1710443003/diff/40001/runtime/vm/stub_code.cc...
runtime/vm/stub_code.cc:150: }
I am wondering if it makes sense to move this to Code::FinalizeCode instead of
repeating it twice here and in the compiler.

https://codereview.chromium.org/1710443003/diff/40001/runtime/vm/virtual_memo...
File runtime/vm/virtual_memory_macos.cc (right):

https://codereview.chromium.org/1710443003/diff/40001/runtime/vm/virtual_memo...
runtime/vm/virtual_memory_macos.cc:17: #include "vm/thread.h"
These header files are not included in the other OS files.
Also just 
#include "vm/isolate.h"
should be sufficient as "vm/thread.h" is included inside vm/isolate.h

[siva, 2016-02-17 21:08:06]

LGTM with comments.

[srdjan, 2016-02-17 21:15:15]

https://codereview.chromium.org/1710443003/diff/40001/runtime/vm/stub_code.cc
File runtime/vm/stub_code.cc (right):

https://codereview.chromium.org/1710443003/diff/40001/runtime/vm/stub_code.cc...
runtime/vm/stub_code.cc:10: #include "vm/compiler.h"  //
SafepointOperationScope.
On 2016/02/17 21:07:49, siva wrote:
> #include "vm/safepoint.h"
> 
> (SafepointOperationScope is defined here).

Done.

https://codereview.chromium.org/1710443003/diff/40001/runtime/vm/stub_code.cc...
runtime/vm/stub_code.cc:130: // This part of compilation must be at a safepoint.
On 2016/02/17 21:07:49, siva wrote:
> This part of stub code generation must be at a safepoint.

Done.

https://codereview.chromium.org/1710443003/diff/40001/runtime/vm/stub_code.cc...
runtime/vm/stub_code.cc:150: }
On 2016/02/17 21:07:49, siva wrote:
> I am wondering if it makes sense to move this to Code::FinalizeCode instead of
> repeating it twice here and in the compiler.

The situations are not exactly identical. Leaving it as it is.

https://codereview.chromium.org/1710443003/diff/40001/runtime/vm/virtual_memo...
File runtime/vm/virtual_memory_macos.cc (right):

https://codereview.chromium.org/1710443003/diff/40001/runtime/vm/virtual_memo...
runtime/vm/virtual_memory_macos.cc:17: #include "vm/thread.h"
On 2016/02/17 21:07:49, siva wrote:
> These header files are not included in the other OS files.
> Also just 
> #include "vm/isolate.h"
> should be sufficient as "vm/thread.h" is included inside vm/isolate.h

Removed thread.h; added it to other OS-s as well.

[srdjan, 2016-02-17 21:17:30]

Description was changed from

==========
Fix background compilation: allocate stubs at safepoint

BUG=
==========

to

==========
Fix background compilation: allocate stubs at safepoint

BUG=
R=asiva@google.com

Committed:
https://github.com/dart-lang/sdk/commit/f5392ea09ad62de2826e4b696303235783d1d7d4
==========

[srdjan, 2016-02-17 21:17:31]

Committed patchset #4 (id:60001) manually as
f5392ea09ad62de2826e4b696303235783d1d7d4 (presubmit successful).