Fix background compilation: allocate stubs at safepoint

runtime/vm/virtual_memory_macos.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"
 #if defined(TARGET_OS_MACOS)
 
 #include "vm/virtual_memory.h"
 
 #include <sys/mman.h>  // NOLINT
 #include <unistd.h>  // NOLINT
 
 #include "platform/assert.h"
 #include "platform/utils.h"
 
+#include "vm/isolate.h"
+#include "vm/thread.h"

[siva, 2016/02/17 21:07:49]

These header files are not included in the other OS files.
Also just 
#include "vm/isolate.h"
should be sufficient as "vm/thread.h" is included inside vm/isolate.h

[srdjan, 2016/02/17 21:15:15]

Removed thread.h; added it to other OS-s as well.

+
 namespace dart {
 
 // standard MAP_FAILED causes "error: use of old-style cast" as it
 // defines MAP_FAILED as ((void *) -1)
 #undef MAP_FAILED
 #define MAP_FAILED reinterpret_cast<void*>(-1)
 
 uword VirtualMemory::page_size_ = 0;
 
 
@@ skipping 47 matching lines @@
                        MAP_PRIVATE | MAP_ANON | MAP_FIXED,
                        -1, 0);
   if (address == MAP_FAILED) {
     return false;
   }
   return true;
 }
 
 
 bool VirtualMemory::Protect(void* address, intptr_t size, Protection mode) {
+  ASSERT(Thread::Current()->IsMutatorThread() ||
+         Isolate::Current()->mutator_thread()->IsAtSafepoint());
   uword start_address = reinterpret_cast<uword>(address);
   uword end_address = start_address + size;
   uword page_address = Utils::RoundDown(start_address, PageSize());
   int prot = 0;
   switch (mode) {
     case kNoAccess:
       prot = PROT_NONE;
       break;
     case kReadOnly:
       prot = PROT_READ;
       break;
     case kReadWrite:
       prot = PROT_READ | PROT_WRITE;
       break;
     case kReadExecute:
       prot = PROT_READ | PROT_EXEC;
       break;
     case kReadWriteExecute:
       prot = PROT_READ | PROT_WRITE | PROT_EXEC;
       break;
   }
   return (mprotect(reinterpret_cast<void*>(page_address),
                    end_address - page_address,
                    prot) == 0);
 }
 
 }  // namespace dart
 
 #endif  // defined(TARGET_OS_MACOS)