Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: runtime/vm/virtual_memory_linux.cc

Issue 1710443003: Fix background compilation: allocate stubs at safepoint (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Comments Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/virtual_memory_android.cc ('k') | runtime/vm/virtual_memory_macos.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" 5 #include "vm/globals.h"
6 #if defined(TARGET_OS_LINUX) 6 #if defined(TARGET_OS_LINUX)
7 7
8 #include "vm/virtual_memory.h" 8 #include "vm/virtual_memory.h"
9 9
10 #include <sys/mman.h> // NOLINT 10 #include <sys/mman.h> // NOLINT
11 #include <unistd.h> // NOLINT 11 #include <unistd.h> // NOLINT
12 12
13 #include "platform/assert.h" 13 #include "platform/assert.h"
14 #include "platform/utils.h" 14 #include "platform/utils.h"
15 15
16 #include "vm/isolate.h"
17
16 namespace dart { 18 namespace dart {
17 19
18 // standard MAP_FAILED causes "error: use of old-style cast" as it 20 // standard MAP_FAILED causes "error: use of old-style cast" as it
19 // defines MAP_FAILED as ((void *) -1) 21 // defines MAP_FAILED as ((void *) -1)
20 #undef MAP_FAILED 22 #undef MAP_FAILED
21 #define MAP_FAILED reinterpret_cast<void*>(-1) 23 #define MAP_FAILED reinterpret_cast<void*>(-1)
22 24
23 uword VirtualMemory::page_size_ = 0; 25 uword VirtualMemory::page_size_ = 0;
24 26
25 27
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
72 MAP_PRIVATE | MAP_ANON | MAP_FIXED, 74 MAP_PRIVATE | MAP_ANON | MAP_FIXED,
73 -1, 0); 75 -1, 0);
74 if (address == MAP_FAILED) { 76 if (address == MAP_FAILED) {
75 return false; 77 return false;
76 } 78 }
77 return true; 79 return true;
78 } 80 }
79 81
80 82
81 bool VirtualMemory::Protect(void* address, intptr_t size, Protection mode) { 83 bool VirtualMemory::Protect(void* address, intptr_t size, Protection mode) {
84 ASSERT(Thread::Current()->IsMutatorThread() ||
85 Isolate::Current()->mutator_thread()->IsAtSafepoint());
82 uword start_address = reinterpret_cast<uword>(address); 86 uword start_address = reinterpret_cast<uword>(address);
83 uword end_address = start_address + size; 87 uword end_address = start_address + size;
84 uword page_address = Utils::RoundDown(start_address, PageSize()); 88 uword page_address = Utils::RoundDown(start_address, PageSize());
85 int prot = 0; 89 int prot = 0;
86 switch (mode) { 90 switch (mode) {
87 case kNoAccess: 91 case kNoAccess:
88 prot = PROT_NONE; 92 prot = PROT_NONE;
89 break; 93 break;
90 case kReadOnly: 94 case kReadOnly:
91 prot = PROT_READ; 95 prot = PROT_READ;
(...skipping 10 matching lines...) Expand all
102 } 106 }
103 return (mprotect(reinterpret_cast<void*>(page_address), 107 return (mprotect(reinterpret_cast<void*>(page_address),
104 end_address - page_address, 108 end_address - page_address,
105 prot) == 0); 109 prot) == 0);
106 } 110 }
107 111
108 112
109 } // namespace dart 113 } // namespace dart
110 114
111 #endif // defined(TARGET_OS_LINUX) 115 #endif // defined(TARGET_OS_LINUX)
OLDNEW
« no previous file with comments | « runtime/vm/virtual_memory_android.cc ('k') | runtime/vm/virtual_memory_macos.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698