Unprefix multicol properties.

Unprefix multicol properties.

The prefixed versions will be retained as aliases for the unprefixed ones.
Might take some decades before the world wide web has stopped using them,
so we probably cannot deprecate (and remove) them any time soon.

Most tests are still prefixed. Will clean that up in due course. For now, just
unprefix one random unit test and one random LayoutTest.

BUG=492297
Committed: https://crrev.com/ef0bbaa58e53dc720970aec40a06f24ca66f7b0d
Cr-Commit-Position: refs/heads/master@{#376249}

[mstensho (USE GERRIT), 2016-02-18 15:50:05]

mstensho@opera.com changed reviewers:
+ leviw@chromium.org

[mstensho (USE GERRIT), 2016-02-18 15:50:06]

Season finale! Unprefix multicol for realz.

[mstensho (USE GERRIT), 2016-02-18 19:02:19]

mstensho@opera.com changed reviewers:
+ dglazkov@chromium.org, philipj@opera.com

[mstensho (USE GERRIT), 2016-02-18 19:02:19]

And with webexposed changes, we need approval from an API owner too.

[dglazkov, 2016-02-18 19:02:42]

lgtm

[mstensho (USE GERRIT), 2016-02-18 19:17:21]

Thank you dglazkov. We still need leviw to review the rest - unless you want to
go through everything? :)

[dglazkov, 2016-02-18 19:26:13]

/me looks at levi <__<.

[leviw_travelin_and_unemployed, 2016-02-18 19:32:57]

LGTM with a question.

https://codereview.chromium.org/1710003002/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/css/style-enumerate-properties.html
(right):

https://codereview.chromium.org/1710003002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/css/style-enumerate-properties.html:45: if
(++cssPropertyCount <= 150)
Where'd this number come from?

[mstensho (USE GERRIT), 2016-02-18 19:59:31]

https://codereview.chromium.org/1710003002/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/css/style-enumerate-properties.html
(right):

https://codereview.chromium.org/1710003002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/css/style-enumerate-properties.html:45: if
(++cssPropertyCount <= 150)
On 2016/02/18 19:32:57, leviw wrote:
> Where'd this number come from?

Suddenly, there are more than 100 properties between "alignmentBaseline" and
"filter", because I've added a few "column*" properties. I guess 150 should last
a few years. :)

I suppose it would be possible to rewrite the test to run through the entire set
of properties, rather than stopping at some arbitrary number, like 100 or 150.

[mstensho (USE GERRIT), 2016-02-18 20:22:39]

The CQ bit was checked by mstensho@opera.com

[commit-bot: I haz the power, 2016-02-18 20:25:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1710003002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1710003002/40001

[commit-bot: I haz the power, 2016-02-18 20:42:32]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-02-18 20:43:24]

Description was changed from

==========
Unprefix multicol properties.

The prefixed versions will be retained as aliases for the unprefixed ones.
Might take some decades before the world wide web has stopped using them,
so we probably cannot deprecate (and remove) them any time soon.

Most tests are still prefixed. Will clean that up in due course. For now, just
unprefix one random unit test and one random LayoutTest.

BUG=492297
==========

to

==========
Unprefix multicol properties.

The prefixed versions will be retained as aliases for the unprefixed ones.
Might take some decades before the world wide web has stopped using them,
so we probably cannot deprecate (and remove) them any time soon.

Most tests are still prefixed. Will clean that up in due course. For now, just
unprefix one random unit test and one random LayoutTest.

BUG=492297

Committed: https://crrev.com/ef0bbaa58e53dc720970aec40a06f24ca66f7b0d
Cr-Commit-Position: refs/heads/master@{#376249}
==========

[commit-bot: I haz the power, 2016-02-18 20:43:25]

Patchset 3 (id:??) landed as
https://crrev.com/ef0bbaa58e53dc720970aec40a06f24ca66f7b0d
Cr-Commit-Position: refs/heads/master@{#376249}

[leviw_travelin_and_unemployed, 2016-02-18 20:48:46]

On 2016/02/18 at 19:59:31, mstensho wrote:
>
https://codereview.chromium.org/1710003002/diff/40001/third_party/WebKit/Layo...
> File third_party/WebKit/LayoutTests/fast/css/style-enumerate-properties.html
(right):
> 
>
https://codereview.chromium.org/1710003002/diff/40001/third_party/WebKit/Layo...
> third_party/WebKit/LayoutTests/fast/css/style-enumerate-properties.html:45: if
(++cssPropertyCount <= 150)
> On 2016/02/18 19:32:57, leviw wrote:
> > Where'd this number come from?
> 
> Suddenly, there are more than 100 properties between "alignmentBaseline" and
"filter", because I've added a few "column*" properties. I guess 150 should last
a few years. :)
> 
> I suppose it would be possible to rewrite the test to run through the entire
set of properties, rather than stopping at some arbitrary number, like 100 or
150.

I don't like the arbitrary number nonsense, but fine. Thanks for explaining :p

[drott, 2016-02-22 06:43:26]

Could it be that this is missing the tools/metrics/histograms/histograms.xml
update?

See 
    // 3. Run the update_use_counter_css.py script in
    // chromium/src/tools/metrics/histograms to update the UMA histogram names.
in UseCounter.cpp

[mstensho (USE GERRIT), 2016-02-22 10:37:36]

On 2016/02/22 06:43:26, drott wrote:
> Could it be that this is missing the tools/metrics/histograms/histograms.xml
> update?
> 
> See 
>     // 3. Run the update_use_counter_css.py script in
>     // chromium/src/tools/metrics/histograms to update the UMA histogram
names.
> in UseCounter.cpp

Indeed. Missing for this CL, for https://codereview.chromium.org/1681273003/
(also mine), and https://codereview.chromium.org/1696373003 (snap-height).

I really wonder, though: Since we're able to teach computers to do pretty much
anything these days, could we perhaps teach them to run this script for us too,
or at least refuse to land a CL when some human has forgotten to do it.

Filed CL for histograms.xml: https://codereview.chromium.org/1720823002/

[drott, 2016-02-25 07:48:03]

On 2016/02/22 at 10:37:36, mstensho wrote:

> I really wonder, though: Since we're able to teach computers to do pretty much
anything these days, could we perhaps teach them to run this script for us too,
or at least refuse to land a CL when some human has forgotten to do it.

I'd hope so, too. That's the FIXME in UseCounter.cpp :(