third_party/WebKit/LayoutTests/fast/css/style-enumerate-properties.html - Issue 1710003002: Unprefix multicol properties.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/css/style-enumerate-properties.html

Issue 1710003002: Unprefix multicol properties. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase master Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css/remove-shorthand-expected.txt ('k') | third_party/WebKit/LayoutTests/fast/multicol/nested-columns.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <head>	1 <head>

2 <script src="../../resources/js-test.js"></script>	2 <script src="../../resources/js-test.js"></script>

3 <script>	3 <script>

4 if (window.testRunner)	4 if (window.testRunner)

5 testRunner.dumpAsText();	5 testRunner.dumpAsText();

6	6

7	7

8 </script>	8 </script>

9 </head>	9 </head>

10 <body style="text-decoration: underline; border-top-color: green">	10 <body style="text-decoration: underline; border-top-color: green">

(...skipping 24 matching lines...) Expand all Loading...
35 if (p === "alignmentBaseline")	35 if (p === "alignmentBaseline")

36 started = true;	36 started = true;

37 if (!started)	37 if (!started)

38 continue;	38 continue;

39 if (p === "filter")	39 if (p === "filter")

40 seenFilter = true;	40 seenFilter = true;

41 if (previous && previous >= p) {	41 if (previous && previous >= p) {

42 testFailed("Invalid CSS-mapped property order: '" + p + "' after '" + previous + "'");	42 testFailed("Invalid CSS-mapped property order: '" + p + "' after '" + previous + "'");

43 break;	43 break;

44 }	44 }

45 if (++cssPropertyCount <= 100)	45 if (++cssPropertyCount <= 150)
	leviw_travelin_and_unemployed 2016/02/18 19:32:57 Where'd this number come from? Where'd this number come from? mstensho (USE GERRIT) 2016/02/18 19:59:31 Suddenly, there are more than 100 properties betwe Show quoted text On 2016/02/18 19:32:57, leviw wrote: > Where'd this number come from? Suddenly, there are more than 100 properties between "alignmentBaseline" and "filter", because I've added a few "column*" properties. I guess 150 should last a few years. :) I suppose it would be possible to rewrite the test to run through the entire set of properties, rather than stopping at some arbitrary number, like 100 or 150.
46 previous = p;	46 previous = p;

47 else {	47 else {

48 if (seenFilter)	48 if (seenFilter)

49 testPassed("The CSS property order is correct");	49 testPassed("The CSS property order is correct");

50 else	50 else

51 testFailed("The 'filter' property was not enumerated");	51 testFailed("The 'filter' property was not enumerated");

52 break;	52 break;

53 }	53 }

54 }	54 }

55 </script>	55 </script>

56 </body>	56 </body>

OLD	NEW