Add CSS parser support for the snap-height property

Add CSS parser support for the snap-height property

This patch adds CSS parser support for the snap-height property, behind
the CSSSnapSize runtime flag.

Supporting layout will be in following patches.

A test was imported from csswg-test and was marked as failure. This
patch makes the test pass.

Spec: https://drafts.csswg.org/css-snap-size/
Dashboard: https://www.chromestatus.com/features/5734273533345792

BUG=586413
TEST=imported/csswg-test/css-snap-size-1/snap-height-parsing-001.html

Committed: https://crrev.com/856c2d86e6b57825e9afa596f326f7ff45e4c208
Cr-Commit-Position: refs/heads/master@{#376051}

[kojii, 2016-02-17 05:56:35]

Description was changed from

==========
WIP: snap-height parsing

BUG=
==========

to

==========
Add CSS parser support for the snap-height property

This patch adds CSS parser support for the snap-height property, behind
the CSSSnapSize runtime flag.

Supporting layout will be in following patches.

Spec: https://drafts.csswg.org/css-snap-size/
Dashboard: https://www.chromestatus.com/features/5734273533345792

BUG=586413
==========

[kojii, 2016-02-17 05:58:00]

Description was changed from

==========
Add CSS parser support for the snap-height property

This patch adds CSS parser support for the snap-height property, behind
the CSSSnapSize runtime flag.

Supporting layout will be in following patches.

Spec: https://drafts.csswg.org/css-snap-size/
Dashboard: https://www.chromestatus.com/features/5734273533345792

BUG=586413
==========

to

==========
Add CSS parser support for the snap-height property

This patch adds CSS parser support for the snap-height property, behind
the CSSSnapSize runtime flag.

Supporting layout will be in following patches.

A test was imported from csswg-test and was marked as failure. This
patch makes the test pass.

Spec: https://drafts.csswg.org/css-snap-size/
Dashboard: https://www.chromestatus.com/features/5734273533345792

BUG=586413
==========

[kojii, 2016-02-17 05:58:36]

Description was changed from

==========
Add CSS parser support for the snap-height property

This patch adds CSS parser support for the snap-height property, behind
the CSSSnapSize runtime flag.

Supporting layout will be in following patches.

A test was imported from csswg-test and was marked as failure. This
patch makes the test pass.

Spec: https://drafts.csswg.org/css-snap-size/
Dashboard: https://www.chromestatus.com/features/5734273533345792

BUG=586413
==========

to

==========
Add CSS parser support for the snap-height property

This patch adds CSS parser support for the snap-height property, behind
the CSSSnapSize runtime flag.

Supporting layout will be in following patches.

A test was imported from csswg-test and was marked as failure. This
patch makes the test pass.

Spec: https://drafts.csswg.org/css-snap-size/
Dashboard: https://www.chromestatus.com/features/5734273533345792

BUG=586413
TEST=imported/csswg-test/css-snap-size-1/snap-height-parsing-001.html
==========

[kojii, 2016-02-17 08:05:50]

kojii@chromium.org changed reviewers:
+ timloh@chromium.org

[kojii, 2016-02-17 08:10:44]

timloh@, PTAL.

Is the use of converter more recommended than custom? This CL uses custom in
order to save memory in StyleRareInheritedData. Currently this feature uses 15
bits, and fits in unused memory in StyleRareInheritedData. It may go up to 16 or
24 bits in future.

If this is too much worry and is not worth, please let me know so and I'll
switch to the converter.

[Timothy Loh, 2016-02-18 00:25:26]

On 2016/02/17 08:10:44, kojii wrote:
> timloh@, PTAL.
> 
> Is the use of converter more recommended than custom? This CL uses custom in
> order to save memory in StyleRareInheritedData. Currently this feature uses 15
> bits, and fits in unused memory in StyleRareInheritedData. It may go up to 16
or
> 24 bits in future.
> 
> If this is too much worry and is not worth, please let me know so and I'll
> switch to the converter.

It's fine either way, I'd just leave it as is. We haven't really been consistent
with this so some types have a class and waste a bit of space, some types have a
class used temporarily but get unpacked to not waste space, and some are just
completely unpacked.

[Timothy Loh, 2016-02-18 00:25:50]

On 2016/02/18 00:25:26, Timothy Loh wrote:
> On 2016/02/17 08:10:44, kojii wrote:
> > timloh@, PTAL.
> > 
> > Is the use of converter more recommended than custom? This CL uses custom in
> > order to save memory in StyleRareInheritedData. Currently this feature uses
15
> > bits, and fits in unused memory in StyleRareInheritedData. It may go up to
16
> or
> > 24 bits in future.
> > 
> > If this is too much worry and is not worth, please let me know so and I'll
> > switch to the converter.
> 
> It's fine either way, I'd just leave it as is. We haven't really been
consistent
> with this so some types have a class and waste a bit of space, some types have
a
> class used temporarily but get unpacked to not waste space, and some are just
> completely unpacked.

lgtm

[kojii, 2016-02-18 00:33:58]

Thank you for your prompt review and advice!

[kojii, 2016-02-18 00:34:02]

The CQ bit was checked by kojii@chromium.org

[commit-bot: I haz the power, 2016-02-18 00:35:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1696373003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1696373003/40001

[commit-bot: I haz the power, 2016-02-18 00:47:25]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-02-18 00:49:40]

Description was changed from

==========
Add CSS parser support for the snap-height property

This patch adds CSS parser support for the snap-height property, behind
the CSSSnapSize runtime flag.

Supporting layout will be in following patches.

A test was imported from csswg-test and was marked as failure. This
patch makes the test pass.

Spec: https://drafts.csswg.org/css-snap-size/
Dashboard: https://www.chromestatus.com/features/5734273533345792

BUG=586413
TEST=imported/csswg-test/css-snap-size-1/snap-height-parsing-001.html
==========

to

==========
Add CSS parser support for the snap-height property

This patch adds CSS parser support for the snap-height property, behind
the CSSSnapSize runtime flag.

Supporting layout will be in following patches.

A test was imported from csswg-test and was marked as failure. This
patch makes the test pass.

Spec: https://drafts.csswg.org/css-snap-size/
Dashboard: https://www.chromestatus.com/features/5734273533345792

BUG=586413
TEST=imported/csswg-test/css-snap-size-1/snap-height-parsing-001.html

Committed: https://crrev.com/856c2d86e6b57825e9afa596f326f7ff45e4c208
Cr-Commit-Position: refs/heads/master@{#376051}
==========

[commit-bot: I haz the power, 2016-02-18 00:49:40]

Patchset 3 (id:??) landed as
https://crrev.com/856c2d86e6b57825e9afa596f326f7ff45e4c208
Cr-Commit-Position: refs/heads/master@{#376051}