Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 1709793002: MIPS: [turbofan] Add RoundUint32ToFloat32 operator to Turbofan. (Closed)

Created:
4 years, 10 months ago by akos.palfi.imgtec
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: [turbofan] Add RoundUint32ToFloat32 operator to Turbofan. Port 187b3f2845a39f428ac46d72450373c678d011de BUG= Committed: https://crrev.com/3cf56fe0195e2fab93ddba3e44e56bc8e9cf379f Cr-Commit-Position: refs/heads/master@{#34130}

Patch Set 1 #

Patch Set 2 : Remove unused var. #

Total comments: 1

Patch Set 3 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -2 lines) Patch
M src/compiler/mips/code-generator-mips.cc View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M src/compiler/mips/instruction-codes-mips.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/mips/instruction-selector-mips.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/mips64/instruction-codes-mips64.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/macro-assembler-mips64.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 1 2 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (9 generated)
akos.palfi.imgtec
PTAL.
4 years, 10 months ago (2016-02-17 22:54:13 UTC) #2
akos.palfi.imgtec
PTAL.
4 years, 10 months ago (2016-02-17 22:54:14 UTC) #3
Ilija.Pavlovic1
Missing the test for cvt_s_uw in test-assembler-mips64.cc. https://codereview.chromium.org/1709793002/diff/20001/src/mips64/macro-assembler-mips64.cc File src/mips64/macro-assembler-mips64.cc (right): https://codereview.chromium.org/1709793002/diff/20001/src/mips64/macro-assembler-mips64.cc#newcode1662 src/mips64/macro-assembler-mips64.cc:1662: // Convert ...
4 years, 10 months ago (2016-02-18 08:44:35 UTC) #5
balazs.kilvady
lgtm
4 years, 10 months ago (2016-02-18 11:55:47 UTC) #6
Ilija.Pavlovic1
lgtm
4 years, 10 months ago (2016-02-18 12:26:43 UTC) #7
Ilija.Pavlovic1
lgtm
4 years, 10 months ago (2016-02-18 12:26:44 UTC) #8
commit-bot: I haz the power
This CL has an open dependency (Issue 1709793002 Patch 1). Please resolve the dependency and ...
4 years, 10 months ago (2016-02-18 12:31:44 UTC) #11
commit-bot: I haz the power
This CL has an open dependency (Issue 1709793002 Patch 1). Please resolve the dependency and ...
4 years, 10 months ago (2016-02-18 14:24:47 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1709793002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1709793002/40001
4 years, 10 months ago (2016-02-18 22:57:09 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-18 23:23:58 UTC) #18
commit-bot: I haz the power
4 years, 10 months ago (2016-02-18 23:24:51 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3cf56fe0195e2fab93ddba3e44e56bc8e9cf379f
Cr-Commit-Position: refs/heads/master@{#34130}

Powered by Google App Engine
This is Rietveld 408576698