Add option BIONIC toolchain to NaCl SDK output

Adds the BIONIC toolchain to the SDK when building with --bionic. 

Only affects SDK build, not Chrome.

NOTRY=true
BUG=344575
TEST=build_sdk.py --bionic

see also parent issue:
  https://code.google.com/p/chromium/issues/detail?id=344574

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251870

[noelallen1, 2014-02-18 19:23:44]

ptal

[Sam Clegg, 2014-02-18 20:27:20]

lgtm

https://codereview.chromium.org/170973003/diff/1/native_client_sdk/src/build_...
File native_client_sdk/src/build_tools/build_projects.py (right):

https://codereview.chromium.org/170973003/diff/1/native_client_sdk/src/build_...
native_client_sdk/src/build_tools/build_projects.py:255:
options.toolchain.append('bionic')
Maybe the --bionic option should be used here, like it is in build_sdk.py?

https://codereview.chromium.org/170973003/diff/1/native_client_sdk/src/build_...
File native_client_sdk/src/build_tools/build_sdk.py (right):

https://codereview.chromium.org/170973003/diff/1/native_client_sdk/src/build_...
native_client_sdk/src/build_tools/build_sdk.py:906: action='store_true')
I think this (and some of the lines below) fits on a single line.

[binji, 2014-02-18 20:30:23]

lgtm

[noelallen1, 2014-02-18 20:43:39]

https://codereview.chromium.org/170973003/diff/1/native_client_sdk/src/build_...
File native_client_sdk/src/build_tools/build_projects.py (right):

https://codereview.chromium.org/170973003/diff/1/native_client_sdk/src/build_...
native_client_sdk/src/build_tools/build_projects.py:255:
options.toolchain.append('bionic')
On 2014/02/18 20:27:21, Sam Clegg wrote:
> Maybe the --bionic option should be used here, like it is in build_sdk.py?  

There are two things going on here.
  1- We already allow you to pick toolchains using the '-t' command-line option.
  2- We do experimental things with '-x'

Seems to me that -t bionic already covers the --bionic case.  So this '-x' is to
just to add bionic to the experimental switch.

[Sam Clegg, 2014-02-18 21:34:55]

On 2014/02/18 20:43:39, noelallen1 wrote:
>
https://codereview.chromium.org/170973003/diff/1/native_client_sdk/src/build_...
> File native_client_sdk/src/build_tools/build_projects.py (right):
> 
>
https://codereview.chromium.org/170973003/diff/1/native_client_sdk/src/build_...
> native_client_sdk/src/build_tools/build_projects.py:255:
> options.toolchain.append('bionic')
> On 2014/02/18 20:27:21, Sam Clegg wrote:
> > Maybe the --bionic option should be used here, like it is in build_sdk.py?  
> 
> There are two things going on here.
>   1- We already allow you to pick toolchains using the '-t' command-line
option.
>   2- We do experimental things with '-x'
> 
> Seems to me that -t bionic already covers the --bionic case.  So this '-x' is
to
> just to add bionic to the experimental switch.

Ok, lgtm.

[noelallen1, 2014-02-18 23:10:04]

The CQ bit was checked by noelallen@chromium.org

[commit-bot: I haz the power, 2014-02-18 23:10:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/noelallen@chromium.org/170973003/1

[commit-bot: I haz the power, 2014-02-18 23:13:24]

Change committed as 251870