Add option BIONIC toolchain to NaCl SDK output

native_client_sdk/src/build_tools/build_projects.py

 #!/usr/bin/env python
 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import multiprocessing
 import optparse
 import os
 import sys
 
@@ skipping 11 matching lines @@
 import getos
 import http_download
 
 
 MAKE = 'nacl_sdk/make_3.99.90-26-gf80222c/make.exe'
 LIB_DICT = {
   'linux': [],
   'mac': [],
   'win': ['x86_32']
 }
-VALID_TOOLCHAINS = ['newlib', 'glibc', 'pnacl', 'win', 'linux', 'mac']
+VALID_TOOLCHAINS = [
+  'bionic',
+  'newlib',
+  'glibc',
+  'pnacl',
+  'win',
+  'linux',
+  'mac',
+]
 
 # Global verbosity setting.
 # If set to try (normally via a command line arg) then build_projects will
 # add V=1 to all calls to 'make'
 verbose = False
 
 
 def CopyFilesFromTo(filelist, srcdir, dstdir):
   for filename in filelist:
     srcpath = os.path.join(srcdir, filename)
@@ skipping 193 matching lines @@
 
   pepper_ver = str(int(build_version.ChromeMajorVersion()))
   pepperdir = os.path.join(OUT_DIR, 'pepper_' + pepper_ver)
 
   if not options.toolchain:
     # Order matters here: the default toolchain for an example's Makefile will
     # be the first toolchain in this list that is available in the example.
     # e.g. If an example supports newlib and glibc, then the default will be
     # newlib.
     options.toolchain = ['pnacl', 'newlib', 'glibc', 'host']
+    if options.experimental:
+      options.toolchain.append('bionic')

[Sam Clegg, 2014/02/18 20:27:21]

Maybe the --bionic option should be used here, like it is in build_sdk.py?  

[noelallen1, 2014/02/18 20:43:39]

There are two things going on here.
  1- We already allow you to pick toolchains using the '-t' command-line option.
  2- We do experimental things with '-x'

Seems to me that -t bionic already covers the --bionic case.  So this '-x' is to
just to add bionic to the experimental switch.

 
   if 'host' in options.toolchain:
     options.toolchain.remove('host')
     options.toolchain.append(getos.GetPlatform())
     print 'Adding platform: ' + getos.GetPlatform()
 
   ValidateToolchains(options.toolchain)
 
   filters = {}
   if options.toolchain:
@@ skipping 34 matching lines @@
 
 
 if __name__ == '__main__':
   script_name = os.path.basename(sys.argv[0])
   try:
     sys.exit(main(sys.argv))
   except parse_dsc.ValidationError as e:
     buildbot_common.ErrorExit('%s: %s' % (script_name, e))
   except KeyboardInterrupt:
     buildbot_common.ErrorExit('%s: interrupted' % script_name)