Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Unified Diff: native_client_sdk/src/build_tools/build_projects.py

Issue 170973003: Add option BIONIC toolchain to NaCl SDK output (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: native_client_sdk/src/build_tools/build_projects.py
diff --git a/native_client_sdk/src/build_tools/build_projects.py b/native_client_sdk/src/build_tools/build_projects.py
index 8ca133d7db4c1f14ebab53e76b5f3054f886db23..3ca794199f2c9c4c9bd64e63315cd25de05de737 100755
--- a/native_client_sdk/src/build_tools/build_projects.py
+++ b/native_client_sdk/src/build_tools/build_projects.py
@@ -29,7 +29,15 @@ LIB_DICT = {
'mac': [],
'win': ['x86_32']
}
-VALID_TOOLCHAINS = ['newlib', 'glibc', 'pnacl', 'win', 'linux', 'mac']
+VALID_TOOLCHAINS = [
+ 'bionic',
+ 'newlib',
+ 'glibc',
+ 'pnacl',
+ 'win',
+ 'linux',
+ 'mac',
+]
# Global verbosity setting.
# If set to try (normally via a command line arg) then build_projects will
@@ -243,6 +251,8 @@ def main(argv):
# e.g. If an example supports newlib and glibc, then the default will be
# newlib.
options.toolchain = ['pnacl', 'newlib', 'glibc', 'host']
+ if options.experimental:
+ options.toolchain.append('bionic')
Sam Clegg 2014/02/18 20:27:21 Maybe the --bionic option should be used here, lik
noelallen1 2014/02/18 20:43:39 There are two things going on here. 1- We alread
if 'host' in options.toolchain:
options.toolchain.remove('host')
« no previous file with comments | « no previous file | native_client_sdk/src/build_tools/build_sdk.py » ('j') | native_client_sdk/src/build_tools/build_sdk.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698